Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-05-09Bug 547053 - [block selection] Default font is still "Monaco" on macOSI20190519-1800I20190518-1800I20190517-1800I20190516-1800I20190516-1405I20190516-1335I20190516-1250I20190516-1200I20190516-1055I20190515-1800I20190515-0205I20190513-1800I20190512-1800I20190511-1800I20190510-1800I20190509-1800Pierre-Yves B.1-1/+1
Change-Id: Ib328e9f3407db5ed0ea27f31044055585deb3cb6 Signed-off-by: Pierre-Yves B. <PyvesDev@gmail.com>
2019-05-02Bug 546920 - FileDocumentProvider.createElementInfo(Object) should notI20190508-1800I20190508-0450I20190508-0150I20190507-1800I20190507-0155I20190506-1800I20190505-1800I20190504-1800I20190503-1800I20190502-1800Andrey Loskutov1-4/+9
refresh unconditionally An attempt to call refreshFile() while workspace is locked results in a blocking progress dialog. This is not needed if the file is not out-of-sync, which can be tested via *non-blocking* file.isSynchronized() API. This patch does exact that. Change-Id: Ia1b0b7ba250f92e49bbe4343ba542a5d5c4e752b Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-05-02Bug 546828 - Editors based on FileDocumentProvider /Andrey Loskutov9-11/+406
TextFileDocumentProvider lock UI on attempt to edit while build is running The change modifies FileDocumentProvider.getValidateStateRule() and DocumentProviderOperation created in TextFileDocumentProvider.validateState() to return non-null rule (referenced IFile) for IFileEditorInput's if the IResourceRuleFactory.validateEditRule() has no rule for us. This prevents UI freeze on attempt to modify a file while build is running. Instead of a freeze, we get a progress dialog with a possibility to cancel the (blocking) attempt to modify the file. Change-Id: I23a6ddab2ca8f31b5ba134301356c34250f5087c Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-05-02Bug 546910 - [code mining] Char drawn w/ wrong color when selectedMickael Istria1-24/+39
Change-Id: I8c8ca72c9c5d16ceee4cc7944018e24198a1fca0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-30Fixed compile warning introduced by bug 546706I20190501-1800I20190501-0525I20190430-1800Dani Megert1-2/+0
2019-04-29Bug 546706 - multi-line code minings rendered erroneouslyI20190429-1800Mickael Istria5-7/+87
Change-Id: I1a89962176d2583551e4fcd28b2511a69b62aa23 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-23Bug 546594 - GUI freeze when using Compare Viewer with large filesI20190429-0240I20190428-1800I20190427-1800I20190426-1800I20190425-1800I20190425-0030I20190424-1800I20190423-1800zeljko.zurzic1-1/+13
Changes the line tracker used for DocumentClone. If the line delimiters are equal to the default ones, use the DefaultLineTracker instead of the ConfigurableLineTracker - for performance improvement Change-Id: I9b6b570d87eade205f4984f04001ec8170f09c3e Signed-off-by: zeljko.zurzic <zeljko.zurzic@amiq.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-04-22Remove redundant implements.Alexander Kurtakov1-2/+1
Extended class already implements this interface. Change-Id: I6157205224c2cdf7d7d2f8f54c1c3cf63d4c244e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-04-16Added API Tools filter for bug 515570 - [api] org.eclipse.ui.editorActions ↵I20190422-1800I20190421-1800I20190420-1800I20190419-1800I20190418-1800I20190417-1800I20190416-1800Dani Megert1-0/+8
should allow modifiers
2019-04-15Bug 515570 - [api] org.eclipse.ui.editorActions should allow modifiersI20190415-1800Sarika Sinha2-2/+2
as part of actionID Change-Id: I8be418aca1956d878c673f3d3ae42e58c128a54f Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2019-04-15Bug 515570 - [api] org.eclipse.ui.editorActions should allow modifiersI20190415-0300Sarika Sinha3-5/+23
as part of actionID
2019-04-08Bug 529011 - Remove garbage System.err lineS4_12_0_M1I20190414-1800I20190414-0210I20190413-1800I20190412-1800I20190412-0520I20190411-0625I20190410-1800I20190410-0600I20190409-1800I20190409-0600I20190408-1800Mickael Istria1-1/+0
This was introduced for debugging purpose and I forgot to remove it in previous patch. Change-Id: Ib3f5ec7fc72fd29fd7fb84953256ab7b8d1ef7f0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-08Bug 529011 - Better handle folding when using TextPresentationI20190408-0600Mickael Istria4-16/+31
Some editors rely on TextPresentation, when those are combined with folding, code minings could draw spaces at wrong locations, because the widget coordinates (expected by widget) were not translated for usage in TextPresentation (which expects model coordinate). Change-Id: I6cb17b30b269ebd60eb0253987a99cd4c62e5624 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-01Bug 546020 - [code mining] "Index out of Bounds" when inline w/ foldingI20190407-1800I20190406-1800I20190405-1800I20190404-1800I20190403-1800I20190402-1800Mickael Istria11-24/+236
Change-Id: I7b10e2d8122372bec5452225313142cf6ec58f3c Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-25Bug 545531 - Define compare/merge viewer for Generic EditorI20190401-1800I20190331-1800I20190330-1800I20190329-1800I20190329-0120I20190328-1800I20190327-1800I20190326-2305I20190326-1800I20190325-1800Mickael Istria19-189/+265
Change-Id: Ia77dedcd18d38fed343817a3d003e83dd76fe9e0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-21Bug 533194 - [Code mining] Cannot position the caret on 1st letterI20190325-0105I20190324-1800I20190323-1800I20190322-1800Mickael Istria5-39/+127
This change the drawing strategy to draw the code mining on the right of the previous character, so caret always is just before the next char. Change-Id: I3951a14faafebf3d947652e8dab2a8bdde27aa13 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-20Bug 545565 - ListLineTracker returns wrong results after content set toI20190321-1800I20190321-0435I20190321-0245I20190320-1800Paul Pazderski4-4/+65
null If tracked text is set to null the tracked content length was not updated. Change-Id: I26ed7b21879ff77a1e3b7828a4e4a4d969608cb8 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-03-19Bug 545530 - Test for TextViewer's default IDocumentAdapterPaul Pazderski3-8/+69
Test cases derived from IDocumentAdapter JavaDoc to check if TextViewer's default implementation of IDocumentAdapter adhere to its interface. Change-Id: I03d122e608662b6b65528c479910c797cf2397b1 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-03-11Revert "Revert "Bug 541404 - improve UndoableCompoundTextChange with single ↵I20190318-1800I20190314-1800I20190312-1800I20190312-0340I20190311-1800Mickael Istria3-40/+74
change"" This reverts commit b0d63d9ce8037c9f304ee2e669621266df54820c. Change-Id: I95250fbba8390e7cf01601272d21e8bc218aee75
2019-03-08Bug 545094 - POM and product version change for 4.12 releaseI20190311-0410I20190309-1830I20190308-1830I20190308-1525I20190308-1055I20190308-0740Niraj Modi19-21/+21
Change-Id: Ideffb628508e4505ec7b55afd5ba9f2c5fd75f3c Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-03-06Revert "Bug 541404 - improve UndoableCompoundTextChange with single change"Y20190320-2200Y20190319-2305Y20190316-1220Y20190313-2200Y20190313-0215Y20190308-0715Y20190307-1015Y20190306-2200S4_11_0_RC2R4_11I20190307-0500I20190306-2135I20190306-1800R4_11_maintenanceNoopur Gupta1-72/+38
This reverts commit dd94c4b6d3b87eb57d89f2afa3ef4dc7b96e8488. Change-Id: Ibee48390dd5f4c0a2b580972a4f7f1d2ccfdcd3f
2019-03-06Bug 541404 - improve UndoableCompoundTextChange with single changeMickael Istria1-38/+72
When the compound change has only 1 change, it can be processed as a basic change, using the "text change" strategy rather than the "text set". This goes into a simpler redraw loop, which prevent some issues with code minings. Change-Id: Ie54960195b89317e21b182e16704babd52d8d43b Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-05Bug 545006 - Reuse existing API for screenshots during testsI20190306-0600I20190305-1800I20190305-0600Mickael Istria4-40/+10
This should allow screenshots to be found more easily in official tests and allow to more easily spot tests disabled on Mac. Change-Id: I7d57891ef83976401d5fdf165f7655b6f783f6fe Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-05Bug 540143 - StackOverflowError with async content-assistMickael Istria7-6/+269
A long running failing completion proposal cause StackOverflowError because it's completion state isn't retrieved correctly so the ContentAssistant assume it's not done. Instead, detect the error case and return future normally (error will be logged in console). Change-Id: I82dc511fdcbc7c61f1e575f975ef221e5d0ac160 Signed-off-by: Mickael Istria <mistria@redhat.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-03-03Bug 541415 - disable tests on MacI20190304-1800I20190304-0600I20190303-1800Andrey Loskutov2-0/+20
Change-Id: Iafd6875fe46e2ad8ebbb3aab8141925b5dab5fd8 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-03-02Bug 541415 - fixed testsI20190303-0600Andrey Loskutov2-15/+24
Change-Id: I3d5a21c60e5f83ddcb061a781a1f2b558d3f11b3 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-02-28Bug 544867 - [Generic Editor] ExtensionBasedTextEditor does not allowS4_11_0_RC1I20190302-1800I20190302-0600I20190301-1800I20190301-0040Bin Zou1-2/+6
its subclasses to setKeyBindingScopes. Delete setKeyBindingScopes method and override initializeKeyBindingScopes method instead. Signed-off-by: Bin Zou <bin.zou@cs.ox.ac.uk>
2019-02-28Bug 541415 - [Test] Use MOD1 instead of CONTROLMickael Istria1-2/+2
So it should also work on Mac. Change-Id: Ic725f485d6d52f867005964edde1211a1ab87645 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-02-27Bug 541415 - [Test] Add test for code mining Ctrl+Home/EndY20190227-2200I20190228-0300I20190227-1800Mickael Istria7-6/+388
Change-Id: Id50805fd1e5b6f91de27d573a2b6c1850902931f Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-02-18Bug 543933 - Build javadocs with Java 11Y20190225-0415Y20190222-0110Y20190220-2200S4_11_0_M3I20190227-0600I20190226-1800I20190226-1020I20190226-0715I20190226-0600I20190225-1800I20190225-0600I20190225-0200I20190224-1800I20190224-0930I20190224-0600I20190223-1800I20190223-0600I20190222-1800I20190222-0645I20190222-0440I20190220-1800I20190220-0600I20190219-1800I20190219-0600I20190218-1800Alexander Kurtakov9-76/+105
After fixing majority of Xdoclint:html issues there are warnings even with Xdoclint:none. Change-Id: I9be510daa74198061f829b73116c38c19dfd400f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-18Bug 543933 - Build javadocs with Java 11Alexander Kurtakov4-20/+22
Fix javadoc warnings catched by Java 11 tool with XDoclint:syntax. Change-Id: I853d804bf9d86ee16c5876478e4e40962c68d4f8 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-18Bug 543933 - Build javadocs with Java 11Alexander Kurtakov26-200/+216
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I361b79bda124f98380dec2c87ca41b09f4098643 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-16Bug 543933 - Build javadocs with Java 11I20190218-0600I20190217-1800I20190217-0600I20190216-1800Alexander Kurtakov8-106/+118
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I9d4dfa7c57b47c5d130c8d0c50069b0ed15b70fa Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-16Bug 543933 - Build javadocs with Java 11I20190216-0600Alexander Kurtakov11-64/+74
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: Iac131bfc027cf0d7de92992b6518764ce0b568d9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-15Bug 543933 - Build javadocs with Java 11I20190215-1800Alexander Kurtakov1-1/+1
Fix javadoc warnings in MultiTextEdit.java. Change-Id: I7de36c65ccd113d2df11d322ba1015d92f8cf932 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-15Bug 543933 - Build javadocs with Java 11Alexander Kurtakov16-172/+208
Fix warnings catched by java 11 javadoc. (take 4) Change-Id: I64da26cfb07bb1f02e18f87954b24ce93546316e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Bug 543933 - Build javadocs with Java 11I20190215-0630I20190215-0055I20190214-1800Alexander Kurtakov43-545/+516
Fix warnings catched by java 11 javadoc. (take 3) Change-Id: I6e7fd7d2f60b67dfdfe31e89d80c871cfd6c443f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Bug 543933 - Build javadocs with Java 11Alexander Kurtakov4-14/+15
Fix warnings catched by java 11 javadoc. (take 2) Change-Id: Iccf5071777c27d00d2bd06d9301e175b4ce820dc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Bug 479273 - Prefer usage of Boolean.parseBoolean instead ofLars Vogel4-6/+6
Boolean.ValueOf Change-Id: If9a679f44f99a373b38f8f16623eaa45b4704f5a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-02-13Bug 543933 - Build javadocs with Java 11Y20190213-2200I20190213-1800Alexander Kurtakov5-6/+14
Fix warnings catched by java 11 javadoc. Change-Id: I9e35131d8314575d81c186d5c418b6be5137d46c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-13Bug 538439 - org.eclipse.ui.genericeditor.tests 4 tests fail on MacY20190213-0305Andrey Loskutov3-17/+20
Change-Id: I68e642651a1627e3544c54cc0b5825d781eb58fc Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-02-12Add missing Override annotation.I20190212-1800Alexander Kurtakov1-4/+2
Change-Id: I2a3d9fef5587d641d18761b9b8b78820427799dc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-12Remove unused problem filter.Alexander Kurtakov1-11/+0
Change-Id: I40b9ff42d261536ff653d2907da5d678b2a70029 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-12Bug 544315 - DocumentProviderRegistry: also try IPath to get extensionThomas Wolf7-4/+121
Make getDocumentProvider(IEditorInput) try a little harder by trying to figure out an IPath from the editor input and use the extension of that path, if one can be determined. Change-Id: I6426e0e9fa09b71bd472d5ca545d1333c17323ce Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2019-02-11Bug 544309 - Add doc link to bugI20190211-1800Karsten Thoms4-4/+4
Change-Id: I9142a10c51abc1ea27316ad72cf274ae1f09561e Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-02-11Bug 544309 - Mark EncodingActionGroup & related for removalKarsten Thoms5-7/+54
Change-Id: Id70eb30bd39b59a20f41209689f8cf2aa5ca95e0 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-02-10Bug 518569 - Use StandardCharset constantsI20190210-2135I20190210-1800Karsten Thoms21-76/+44
Also: version bump for 4.11 Change-Id: I7055e6a2ceb521dbe6065888b735ac62caa73ef6 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-02-06Bug 538594 - [content assist] Default size is too smallY20190208-0505Y20190206-2200I20190209-1800I20190208-1800I20190207-1800I20190206-1800Andrey Loskutov1-3/+3
This change increases the content assist width from height x 1.62 to height x 2. Change-Id: I054c3464998c27bbb1a95378371254507051a129 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-02-03Bug 537642 - The junit testY20190205-0115I20190205-1800I20190204-1800I20190203-1800Andrey Loskutov3-4/+4
FindReplaceDialogTest.testFocusNotChangedWhenEnterPressed fails on Mac Change-Id: I5888399a8c45d60456dbf0c1c501e8bcce4caaea Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-01-31Bug 514054 - Fix typo so Templates View maintains a sorted order.Y20190201-0030I20190202-1800I20190201-1800I20190201-0600I20190131-1800Roland Grunberg3-3/+3
Change-Id: I14ea3667721af7d8ff627a8aa4ce0224626206e8 Signed-off-by: Roland Grunberg <rgrunber@redhat.com> Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>

Back to the top