Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2016-11-18Bug 506954 - [Generic Editor] Editor doesn't have position on status barY20161124-1000I20161128-0600I20161128-0330I20161127-2000I20161127-1300I20161126-2000I20161126-0815I20161125-2000I20161124-2000I20161123-2000I20161122-2000I20161121-2000I20161120-2000I20161119-2000I20161118-2000Michal Niewrzal1-0/+1
Change-Id: I22ee73f0c7ca291eeda7f73df837b35164b68d20 Signed-off-by: Michal Niewrzal <>
2016-11-15Bug 507400 - Search dialog should not be modalY20161117-1000I20161117-2000I20161116-2000Lars Vogel2-0/+16
This make the search dialog non-blocking anymore, so that the user can still select text from the editor, even if the dialog is open. Opening multiple times the dialog is not possible due to a check in the related action. Change-Id: Ic4ae870a3097e8f16aba708f138c2e05fe1d8cc2 Signed-off-by: Lars Vogel <>
2016-11-09[Generic Editor] Code cleanupY20161110-1000I20161115-2000I20161114-2000I20161114-0355I20161113-2000I20161112-2000I20161112-0405I20161111-2000I20161111-1220I20161111-0900I20161111-0740I20161111-0510I20161110-2030I20161110-1630I20161110-1225I20161110-1130I20161110-0710I20161110-0510I20161109-2000Mickael Istria5-9/+107
Change-Id: Idd22c81f4aa102c4a808f3d1868806244aa86017 Signed-off-by: Mickael Istria <>
2016-11-08Bug 500755: [Generic Editor] attach completion to all token contenttypesMickael Istria2-14/+68
As some extension can provide some specific document partitioner, we need to attach completion dynamically to all supported token content-types. Change-Id: Ibfb55c7c254d78b6b6da61916af8b789bb50dfd5 Signed-off-by: Mickael Istria <>
2016-11-07Clean up after bug 506427I20161108-1015I20161108-0800Dani Megert3-3/+8
2016-11-07Bug 507106 - Don't ask strange questions before showing revision infoAndrey Loskutov1-1/+2
for the first time Flipping the default, so that the org.eclipse.ui.internal.texteditor.LineNumberColumn.ensureQuickDiffProvider(String) by default never opens a dialog asking strange question. Change-Id: I9deeff9cc408a9adb794b4955a3513ca7dbd25f0 Signed-off-by: Andrey Loskutov <>
2016-11-05Bug 506427 - Insufficient is-disposed check in LineNumberRulerColumn::redrawRüdiger Herrmann5-3/+58
Signed-off-by: Rüdiger Herrmann <> Change-Id: I0ef8ae88f5612cb0c7302bbe37df9836f5f22d27
2016-10-24Bug 506446 - Removed usage of SubMonitor.step() in eclipse.platform.textY20161103-1000I20161101-0800Lars Vogel5-5/+7
Change-Id: I56725277aa7683705054c0be515d1c07d9b3fb55 Signed-off-by: Lars Vogel <>
2016-10-22Bug 506367 - EditorsTestSuite is leaking state between testsY20161027-1250Y20161027-1000Y20161024-2045Y20161024-1300Y20161024-0700I20161027-0700I20161027-0200I20161026-2000I20161026-1100I20161026-0800I20161025-2000I20161024-2000I20161024-1000I20161024-0410I20161023-2000Stefan Xenos8-77/+114
Wait for the job manager and SWT event queue to be idle before advancing to the next test. Change-Id: I8647ce00680e168d69785ba5d2e3988ac07abaaf Signed-off-by: Stefan Xenos <>
2016-10-21fixed unclosed <em>Y20161021-1200Y20161021-0600Markus Keller1-2/+2
2016-10-20Bug 505940 - NPE on overview ruler on editor for IFileRevision on plainY20161020-1800Andrey Loskutov2-2/+5
text file Fixed regression in org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.findSelectedOverviewRulerAnnotationLabel(), introduced via commit b6ac8fd637f7fa7343820fdff40b9b2cfd6bc54b. Updated javadoc of ISourceViewer to make clear that null return is possible. Change-Id: I0fa6b83a79499b9b2b59edc2527166e8e1fa80b1 Signed-off-by: Andrey Loskutov <>
2016-10-14Fixed bug 505958: [implementation] ↵Y20161020-1000Y20161018-1100I20161018-0800Dani Megert1-5/+7
org.eclipse.jface.text.TextUtilities.getDefaultLineDelimiter(IDocument) can return null
2016-10-14Bug 502837 - ext point allow binding existing editor and content-typeMickael Istria1-0/+7
Example of usage. Change-Id: I6a3d4288ce614cdf87bcab5cf6bcf980f04ce285 Signed-off-by: Mickael Istria <>
2016-10-14Revert "Bug 492202 - Zoom In/Out on block selection"Dani Megert1-1/+16
This reverts commit aa914d41a7dc9eda9677687190f78ac64bacf9be. That change destroys the block selection feature if a non-monospaced font is used. Change-Id: Iffca15bb9f5bc672e761d374344e3206310f653f
2016-10-13Bug 492202 - Zoom In/Out on block selectionMickael Istria1-16/+1
Making default block font default to the regular text font reduces the probability for non-operational zoom commands to happen (as long as user doesn't override the Block Selection font, both are in sync and zoom works with block selection). Change-Id: Ic3bbb7a9fcd2798c459222b0f15bf672a9710e6f Signed-off-by: Mickael Istria <>
2016-10-13Bug 505842 - [generic editor] Test failure in HoverTest.testHoverY20161013-1000Mickael Istria2-11/+21
Add more pauses to let event process Change-Id: I5005c4c8879cf07d2cad0ce11aa5057849ced55e Signed-off-by: Mickael Istria <>
2016-10-11Bug 503332 - Show pop-up for problems on text on Generic EditorMickael Istria3-7/+115
It's just a regular Hover extension with highest priority Change-Id: Ic01f765f6abae99a18dba5817e26a1a6e8d1cd7a Signed-off-by: Mickael Istria <>
2016-10-11Bug 496300 - Support contribution of multiple Hovers to Generic EditorMickael Istria6-16/+250
Multiple hovers are now supported. Contributors can control some sorting using the isBefore and isAfter extension attributes. Change-Id: I622fe6b5c541033ba6c3140e8ad7ceab759a57cb Signed-off-by: Mickael Istria <>
2016-10-11Bug 505447 - [generic editor] Make sure all files have copyright noticeI20161011-0800Mickael Istria1-0/+10
Change-Id: I9f3054195b6050bfa049cbc3045cee90902f8b78 Signed-off-by: Mickael Istria <>
2016-10-10Bug 505632 - Generic Editor should support completion trigger charactersMickael Istria2-2/+33
Change-Id: Iae5e5c76e6d4006df4ffbc5a499ffdc3256a1f0f Signed-off-by: Mickael Istria <>
2016-10-08Bug 505447 - [generic editor] Make sure all files have copyright noticeMickael Istria5-0/+59
Missing copyright on plugin.xml (and added about.html to examples by the way) Change-Id: I90c14a5da40ac9134f534c2d1e811783d65ac5da Signed-off-by: Mickael Istria <>
2016-10-08Bug 505447 - [generic editor] Make sure all files have copyright noticeMickael Istria3-1/+21
Change-Id: If0f0b403d51b6bace1e4d20aa99fa245e0bdcb6e Signed-off-by: Mickael Istria <>
2016-10-07Fixed CHKPII errorsDani Megert1-1/+0
2016-10-04Bug 503149 - IndexException thrown during TextViewerHoverManager$4.runStefan Xenos1-0/+3
Handle and ignore OperationCanceledException in TextViewerHoverManager$ Change-Id: Iccace86e0031e48bf3833e24dac699e610047e9b Signed-off-by: Stefan Xenos <>
2016-10-04Bug 503326 - a default PresentationReconcilier for Generic EditorY20161006-1000I20161005-1430I20161005-1045I20161005-0815I20161004-1000Mickael Istria1-1/+1
A default PresentationReconcilier allows Problem markers to be visible with underline text. Change-Id: Ic4bd0798fd081179c37f55da49aa7bc7054ec5a5 Signed-off-by: Mickael Istria <>
2016-10-02PolishI20161004-0800Dani Megert4-1/+44
2016-09-30Bug 497871 - Provide a Generic and extensible Text EditorSopot Cela1-1/+1
Fix test class FQN. Change-Id: I0e928ddbf0a0aaeca7e91851bc4e9e20deac510e Signed-off-by: Sopot Cela <>
2016-09-29Bug 497871: Fix Generic Editor test configY20160929-1000Mickael Istria1-1/+1
Signed-off-by: Mickael Istria <>
2016-09-26Bug 499811 - .project edition contributing to Generic EditorMickael Istria11-0/+290
This is an example of a usable and feature rich editor for .project files which contributes to the Generic Editor proposal. Bug: 499811 Bug: 497871 Signed-off-by: Mickael Istria <> Signed-off-by: Sopot Cela <> Change-Id: I131e00cbca566e3dc2413c7b5db8c9d724b46bfb
2016-09-26Bug 497871 - Generic and extensible text editorSopot Cela43-5/+2524
This change creates a new extensible text editor, with extension points for: * contentAssist * hover * syntax highlighting Some unit tests show examples of extensions. You can load an IDE with the suggested change (including org.eclipse.ui.editors.tests) and get a syntax highlighter, a hover support and some content assist on the plain text editor. Bug: 497871 Bug: 496117 Bug: 496115 Bug: 496300 Signed-off-by: Mickael Istria <> Signed-off-by: Sopot Cela <> Change-Id: I2eec71e4620364aa11c500ec07e54c693863cf44
2016-09-23Bug 500153: Cleanup warnings in file buffer classesI20160927-0800Bruno Medeiros6-81/+27
Change-Id: I17d70791969dcdf77ecda462a154ee8b430ed98c Signed-off-by: Bruno Medeiros <>
2016-09-23Bug 482354 - SVN checkout deadlocks EclipseAndrey Loskutov7-11/+442
FileDocumentProvider.refreshFile(IFile) is called from UI thread but in worst case (if the IFile is out-of-sync with file system state) it acquires workspace lock for refreshing the resource state. If at same time any workspace job holding a lock on a parent project will try to use IOConsoleOutputStream.write(String) to report lot of data (> 160000 characters) to the console, the IOConsolePartitioner.streamAppended() call will block forever waiting for queue processed by the (locked) UI thread. Proposed solution: FileDocumentProvider.refreshFile(IFile) should run DocumentProviderOperation in providers runnable context to avoid such deadlocks. In the case the resource tree is locked, a "User Operation is Waiting" progress dialog will be shown, giving the user a chance to resolve the deadlock situation by canceling one of the affected tasks. To be consistent with existing API and to allow clients override the supplied refresh rule, new API is introduced in FileDocumentProvider: protected ISchedulingRule.getRefreshRule(Object element). Default implementation in FileDocumentProvider uses ResourceRuleFactory.refreshRule for given file. Change-Id: Id742d98403cc546fad4a21d25eb18ab7bef48776 Signed-off-by: Andrey Loskutov <>
2016-09-21Bug 501122 - Add Organize imports to save actions inY20160922-1000Lars Vogel1-1/+1
org.eclipse.core.filebuffers Change-Id: I7ad3bcb752559bd004d1563899ef4ebc126f93c5 Signed-off-by: Lars Vogel <>
2016-09-21Revert "Bug 501122 - Add Organize imports to save actions in ↵Lars Vogel1-1/+1
org.eclipse.core.filebuffers" This reverts commit 956bf7047023d764d9aed7494a7b5842bcff819d. Change-Id: I5a995192226816bd094312231a8660aad3262491
2016-09-21Bug 479523 - Replace usage of SubProgressMonitor with SubMonitor inLars Vogel2-108/+32
eclipse.platform.text Final change to remove Change-Id: I8e50441151151937e9c4b34004ba14aef61e0577 Signed-off-by: Lars Vogel <>
2016-09-20Bug 501121 - Remove org.eclipse.core.internal.filebuffers.Progress andLars Vogel5-82/+41
convert to SubMonitor Migrates the following classes to get started with the change - ResourceFileBuffer - RemoveTrailingWhitespaceOperation - TextFileBufferOperation - ResourceTextFileBuffer - ConvertLineDelimitersOperation Change-Id: Id607fdb868d264f102c09acbeb32b8ccdaf8ed47 Signed-off-by: Lars Vogel <Lars.Vogel@vogella
2016-09-20Bug 479523 - Replace usage of SubProgressMonitor with SubMonitor inLars Vogel4-75/+40
eclipse.platform.text Also using split for automatic cancelation checking Change-Id: I0d78f0071a0b1d25683bd4404b489dd4334c6b5a Signed-off-by: Lars Vogel <>
2016-09-20Bug 428417 - ConcurrentModificationException inI20160920-0800Andrey Loskutov1-1/+2
AbstractMarkerAnnotationModel The fDeletedAnnotations field in AbstractMarkerAnnotationModel uses ArrayList, which is not thread safe and does not allow concurrent modification and iteration. Introducing new locks around fDeletedAnnotations seem to be dangerous. Replacing this with CopyOnWriteArrayList however seem to be a better solution - it does not add any new locks and should allow safe iteration while other thread modifies the list. Looking at the usage of fDeletedAnnotations, it should be OK to iterate on "old" state. Change-Id: I17fea70fcccf578212e9fdb557a9f0f68aa64dc4 Signed-off-by: Andrey Loskutov <>
2016-09-19Bug 501127 - Remove outdated _buildnotes_text_*.html fromLars Vogel6-2422/+0
org.eclipse.ui.editors Change-Id: I5529f35a09cb97d31d012821c40cf19d378cca40 Signed-off-by: Lars Vogel <>
2016-09-14Bug 501451: Colors in appendStyleSheet should not be hard-coded.Sergey Prigogin1-4/+4
Change-Id: I5c9fc5794453756ef95c43f47467bc591810f0ef
2016-09-14Revert "Bug 501451: Colors in appendStyleSheet should not be hard-coded."Y20160915-1000I20160915-0230I20160915-0200I20160914-2300I20160914-2000Sergey Prigogin1-4/+4
This reverts commit 043666743b59bda1ebadb96816b6493d8f8f4605. Change-Id: I70941392b9a80e5d87a955c66238ac7fae7f6113
2016-09-14Bug 501451: Colors in appendStyleSheet should not be hard-coded.Leo Ufimtsev1-4/+4
See bug for screenshots that demonstrate issue. Change-Id: Ic78e694447bf35f74a97cff76289daf75c5ca93c Task-Url: Signed-off-by: Leo Ufimtsev <>
2016-09-09Bug 501116 Replace gif files in org.eclipse.jface.text with png filesI20160914-0800I20160914-0430I20160914-0030I20160913-2000I20160913-0800I20160912-2000I20160912-1005I20160912-0800I20160912-0430I20160912-0225I20160912-0140I20160911-2015Matthias Becker10-1/+1
Replace gif with png files and also add high resolution png files Change-Id: I2c48207328017f9fbf70c902754051e5367f1042 Signed-off-by: Matthias Becker <>
2016-09-09Bug 493301 - Remove method concatenates strings using + in a loopLars Vogel2-16/+20
warnings reported by Sonar (non test code) Change-Id: I6efd2ee63c04a596c7cd04a90784f67e6919fd3e Signed-off-by: Lars Vogel <>
2016-09-09Revert "Bug 501116 Replace gif files in org.eclipse.jface.text with png files"Lars Vogel10-1/+1
This reverts commit 797b6837d8bf09a59a3bba06ebfd319ef39976e9. Change-Id: I07d5d04e5c0262df4c2f06bf93e83a6fffe9c39e
2016-09-09Bug 501116 Replace gif files in org.eclipse.jface.text with png filesMatthias Becker10-1/+1
Replace gif with png files and also add high resolution png files Change-Id: I30648d60a9f343e85c41a37913606ba4d5538c36 Signed-off-by: Matthias Becker <>
2016-09-09Ignore MacOS .DS_Store filesMatthias Becker1-0/+1
Change-Id: I8a355f5a1aee26321f20e54dd1b89cce56cc1c1c Signed-off-by: Matthias Becker <>
2016-09-09Bug 501122 - Add Organize imports to save actions inLars Vogel1-1/+1
org.eclipse.core.filebuffers Change-Id: I77765e11e694285fdc0ad1bd2e4777bbd7c131e8 Signed-off-by: Lars Vogel <>
2016-09-09Bug 501115 Replace gif files in with png filesMatthias Becker163-37/+37
Replace GIF with PNGs and also add high resolution PNGs Change-Id: I3581cfd91e12afc6a179f14d29e6bf372552e564 Signed-off-by: Matthias Becker <>
2016-09-09Revert "Bug 479523 - Replace usage of SubProgressMonitor with SubMonitor in ↵Lars Vogel4-43/+70
eclipse.platform.text" This was unintentially commited, I selected the wrong tab in the browser. Reverting. I want to commit this early M3 and not late M2. This reverts commit 17c9cb2d257048b6cbfc5a6c7afa89680da4864c. Change-Id: I7efae943288e94f34ca38b8b4bd87408dbea8208

Back to the top