diff options
author | Carsten Reckord | 2017-12-13 19:43:40 +0000 |
---|---|---|
committer | Carsten Reckord | 2018-02-15 16:43:46 +0000 |
commit | 2c0d582b95dc66e48afd0c00bd7b2a8c338d6aea (patch) | |
tree | ee727ff702c928b152e200e7317dccd050a5faf2 /org.eclipse.ui.genericeditor | |
parent | 5f9b6cbb6603918dbda75cd1398a64799f62d49d (diff) | |
download | eclipse.platform.text-2c0d582b95dc66e48afd0c00bd7b2a8c338d6aea.tar.gz eclipse.platform.text-2c0d582b95dc66e48afd0c00bd7b2a8c338d6aea.tar.xz eclipse.platform.text-2c0d582b95dc66e48afd0c00bd7b2a8c338d6aea.zip |
528345 - [Generic Editor] Move Toggle Highlight button to "Editor Presentation"I20180219-2000I20180218-2000I20180217-1500I20180216-2000I20180216-0415I20180215-2000
Contribute "Toggle Highlight" button to "Editor Presentation" instead of
a dedicated toolbar section
For some reason, doing that also makes the hidden separator used as a
group marker for the "Presentation" group visible, so make it invisible
again via an additional contribution. And make sure to do that separately,
because although it's always present, it can't be addressed in a menuContribution otherwise for some reason.
Change-Id: Ie5dab5d45ea420e3af81a2b370fc2a40cd2dbb89
Signed-off-by: Carsten Reckord <reckord@yatta.de>
Diffstat (limited to 'org.eclipse.ui.genericeditor')
-rw-r--r-- | org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF | 3 | ||||
-rw-r--r-- | org.eclipse.ui.genericeditor/plugin.xml | 27 |
2 files changed, 28 insertions, 2 deletions
diff --git a/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF b/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF index 511fd8f13ea..625eeb982d0 100644 --- a/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF +++ b/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF @@ -13,7 +13,8 @@ Require-Bundle: org.eclipse.ui.workbench.texteditor;bundle-version="3.10.0", org.eclipse.ui.workbench;bundle-version="3.109.0", org.eclipse.jface;bundle-version="3.12.0", org.eclipse.ui.ide;bundle-version="3.12.0", - org.eclipse.core.resources;bundle-version="3.11.0" + org.eclipse.core.resources;bundle-version="3.11.0", + org.eclipse.core.expressions;bundle-version="3.6.0" Export-Package: org.eclipse.ui.internal.genericeditor;x-internal:=true, org.eclipse.ui.internal.genericeditor.hover;x-internal:=true, org.eclipse.ui.internal.genericeditor.markers;x-internal:=true diff --git a/org.eclipse.ui.genericeditor/plugin.xml b/org.eclipse.ui.genericeditor/plugin.xml index 9b966636cc0..f2c4b4af6fc 100644 --- a/org.eclipse.ui.genericeditor/plugin.xml +++ b/org.eclipse.ui.genericeditor/plugin.xml @@ -86,11 +86,24 @@ </menuContribution> <menuContribution allPopups="false" - locationURI="toolbar:org.eclipse.ui.genericeditor.GenericEditor"> + locationURI="toolbar:org.eclipse.ui.edit.text.actionSet.presentation?after=additions"> + <separator + name="Presentation" + visible="false"> + </separator> + </menuContribution> + <menuContribution + allPopups="false" + locationURI="toolbar:org.eclipse.ui.edit.text.actionSet.presentation?before=Presentation"> <command commandId="org.eclipse.ui.genericeditor.togglehighlight" label="%command.toggle.highlight.label" style="toggle"> + <visibleWhen> + <reference + definitionId="org.eclipse.ui.genericeditor.GenericEditor.active"> + </reference> + </visibleWhen> </command> </menuContribution> </extension> @@ -173,4 +186,16 @@ </part> </actionSetPartAssociation> </extension> + <extension + point="org.eclipse.core.expressions.definitions"> + <definition + id="org.eclipse.ui.genericeditor.GenericEditor.active"> + <with + variable="activeEditorId"> + <equals + value="org.eclipse.ui.genericeditor.GenericEditor"> + </equals> + </with> + </definition> + </extension> </plugin> |