Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/org.eclipse.ui.editors
diff options
context:
space:
mode:
authorLars Vogel2019-12-19 18:11:36 +0000
committerAlexander Kurtakov2020-01-15 08:17:32 +0000
commit6ded71d47a2c4b3c2acc086040e4d75f2341ceb7 (patch)
treeb151b4b8bf4dc65975387b80ec5eed3dd0792c7a /org.eclipse.ui.editors
parentf4cc6a3ffa8fa4ea7b2dfdcd2709ca27936fcdcd (diff)
downloadeclipse.platform.text-6ded71d47a2c4b3c2acc086040e4d75f2341ceb7.tar.gz
eclipse.platform.text-6ded71d47a2c4b3c2acc086040e4d75f2341ceb7.tar.xz
eclipse.platform.text-6ded71d47a2c4b3c2acc086040e4d75f2341ceb7.zip
Remove unnecessary array creation for varargs in bundlesI20200116-0930I20200116-0330I20200116-0310I20200115-1800
Using the batch cleanup operation via Source -> Cleanup -> "Remove unnecessary array creation for varargs " from standard JDT. See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=559175 applying this cleanup to LinkedModeConfigurationBlock results in a syntax error Change-Id: I097502952bbb3263c8b3253efff95a0d1981acf2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Diffstat (limited to 'org.eclipse.ui.editors')
-rwxr-xr-xorg.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java8
-rw-r--r--org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/NLSUtility.java2
-rw-r--r--org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractDecoratedTextEditor.java2
-rw-r--r--org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/DefaultMarkerAnnotationAccess.java4
4 files changed, 8 insertions, 8 deletions
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java
index 4b85bb89426..67b83d3c85f 100755
--- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java
+++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java
@@ -205,13 +205,13 @@ class LinkedModeConfigurationBlock implements IPreferenceConfigurationBlock {
private List<String[]> getStyles(Object type) {
if (type.equals(MASTER))
- return Arrays.asList(new String[][] {BOX, DASHED_BOX, HIGHLIGHT, UNDERLINE, SQUIGGLES});
+ return Arrays.asList(BOX, DASHED_BOX, HIGHLIGHT, UNDERLINE, SQUIGGLES);
if (type.equals(SLAVE))
- return Arrays.asList(new String[][] {BOX, DASHED_BOX, HIGHLIGHT, UNDERLINE, SQUIGGLES});
+ return Arrays.asList(BOX, DASHED_BOX, HIGHLIGHT, UNDERLINE, SQUIGGLES);
if (type.equals(TARGET))
- return Arrays.asList(new String[][] {BOX, DASHED_BOX, HIGHLIGHT, UNDERLINE, SQUIGGLES});
+ return Arrays.asList(BOX, DASHED_BOX, HIGHLIGHT, UNDERLINE, SQUIGGLES);
if (type.equals(EXIT))
- return Arrays.asList(new String[][] {IBEAM});
+ return Arrays.asList(new String[][] { IBEAM });
return new ArrayList<>();
}
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/NLSUtility.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/NLSUtility.java
index 224b8d2c76b..b4a3c9e799e 100644
--- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/NLSUtility.java
+++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/NLSUtility.java
@@ -30,7 +30,7 @@ public class NLSUtility {
* @return the formatted string
*/
public static String format(String message, Object argument) {
- return MessageFormat.format(message, new Object[] { argument });
+ return MessageFormat.format(message, argument);
}
/**
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractDecoratedTextEditor.java b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractDecoratedTextEditor.java
index 2134f7142ad..2e8b1e69476 100644
--- a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractDecoratedTextEditor.java
+++ b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractDecoratedTextEditor.java
@@ -1938,7 +1938,7 @@ public abstract class AbstractDecoratedTextEditor extends StatusTextEditor {
if (!descriptor.isIncludedInMenu() || !support.isColumnSupported(descriptor))
continue;
final boolean isVisible= support.isColumnVisible(descriptor);
- IAction action= new Action(MessageFormat.format(TextEditorMessages.AbstractDecoratedTextEditor_show_ruler_label, new Object[] {descriptor.getName()}), IAction.AS_CHECK_BOX) {
+ IAction action= new Action(MessageFormat.format(TextEditorMessages.AbstractDecoratedTextEditor_show_ruler_label, descriptor.getName()), IAction.AS_CHECK_BOX) {
@Override
public void run() {
if (descriptor.isGlobal())
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/DefaultMarkerAnnotationAccess.java b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/DefaultMarkerAnnotationAccess.java
index d7e22f8d267..51b557bdbcb 100644
--- a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/DefaultMarkerAnnotationAccess.java
+++ b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/DefaultMarkerAnnotationAccess.java
@@ -275,8 +275,8 @@ public class DefaultMarkerAnnotationAccess implements IAnnotationAccess, IAnnota
// backward compatibility, ignore exceptions, just don't paint
try {
- Method method= annotation.getClass().getMethod("paint", new Class[] { GC.class, Canvas.class, Rectangle.class }); //$NON-NLS-1$
- method.invoke(annotation, new Object[] {gc, canvas, bounds });
+ Method method= annotation.getClass().getMethod("paint", GC.class, Canvas.class, Rectangle.class); //$NON-NLS-1$
+ method.invoke(annotation, gc, canvas, bounds);
} catch (SecurityException x) {
} catch (IllegalArgumentException x) {

Back to the top