Use addAll, deleteAll instead of looping through a collectionI20190623-1800I20190621-1800I20190620-1800I20190620-0130I20190619-1820I20190619-1800

Change-Id: I35edd6a934a0f65f357a54e710c77c190706bb45
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

2 files changed, 4 insertions, 8 deletions

diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/SelectResourcesBlock.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/SelectResourcesBlock.java
index cc409450fbb..fe63c93786c 100644
--- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/SelectResourcesBlock.java
+++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/SelectResourcesBlock.java
@@ -15,6 +15,7 @@ package org.eclipse.ui.internal.editors.text;
 
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
@@ -416,9 +417,7 @@ class SelectResourcesBlock implements ICheckStateListener, ISelectionChangedList
 
 			@Override
 			public void filterElements(Object[] elements) throws InterruptedException {
-				for (Object element : elements) {
-					returnValue.add(element);
-				}
+				Collections.addAll(returnValue, elements);
 			}
 		};
 
@@ -697,9 +696,7 @@ class SelectResourcesBlock implements ICheckStateListener, ISelectionChangedList
 
 		Object[] listItems= listContentProvider.getElements(treeElement);
 		List<Object> listItemsChecked= new ArrayList<>();
-		for (int i= 0; i < listItems.length; ++i) {
-			listItemsChecked.add(listItems[i]);
-		}
+		Collections.addAll(listItemsChecked, listItems);
 
 		checkedStateStore.put(treeElement, listItemsChecked);
 	}
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractMarkerAnnotationModel.java b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractMarkerAnnotationModel.java
index 49612303d76..83c7f9f3e47 100644
--- a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractMarkerAnnotationModel.java
+++ b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/AbstractMarkerAnnotationModel.java
@@ -532,8 +532,7 @@ public abstract class AbstractMarkerAnnotationModel extends AnnotationModel impl
 			}
 		}
 
-		for (int i= 0; i < toBeDeleted.size(); i++)
-			fMarkerUpdaterSpecifications.remove(toBeDeleted.get(i));
+		fMarkerUpdaterSpecifications.removeAll(toBeDeleted);
 	}
 
 	/**