diff options
| author | Andrey Loskutov | 2017-03-11 23:15:33 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2017-03-11 23:15:33 +0000 |
| commit | c88654a1094f40f402575bfd0e258aade7dac74b (patch) | |
| tree | 0f68b5c92fed7b39946bfd43445cf0d33a4edcb6 /org.eclipse.jface.text | |
| parent | 8253bfb80f6510e5d1c7e2e757af04dd11343cac (diff) | |
| download | eclipse.platform.text-c88654a1094f40f402575bfd0e258aade7dac74b.tar.gz eclipse.platform.text-c88654a1094f40f402575bfd0e258aade7dac74b.tar.xz eclipse.platform.text-c88654a1094f40f402575bfd0e258aade7dac74b.zip | |
Bug 513517 - printStackTrace() should not be used in production codeI20170315-0500I20170314-2000I20170313-2000I20170312-2000
Change-Id: I7b4a4d0a1af3979852269b1ee53fb9a8ba444e93
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Diffstat (limited to 'org.eclipse.jface.text')
4 files changed, 2 insertions, 5 deletions
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java index af3863ab185..34cdcaaabb4 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java @@ -1029,7 +1029,6 @@ public final class RevisionPainter { widgetStartLine= Math.max(0, range.getStartLine() - visibleStartLine); widgetEndLine= Math.min(visibleEndLine, end(range) - 1); } catch (BadLocationException x) { - x.printStackTrace(); // ignore and return null } } diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java index efb19eb5c95..12a381ec1e4 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java @@ -228,8 +228,7 @@ class AsyncCompletionProposalPopup extends CompletionProposalPopup { try { processors= fContentAssistant.getContentAssistProcessors(getTokenContentType(invocationOffset)); } catch (BadLocationException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + // ignore } if (processors == null) { return Collections.emptyList(); diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java index 940dfcb4518..0946f5d995f 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java @@ -492,7 +492,6 @@ public final class ChangeRulerColumn implements IChangeRulerColumn, IRevisionRul if (lastLine < bottomLine || bottomLine == -1) bottomLine= lastLine; } catch (BadLocationException x) { - x.printStackTrace(); return null; } diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java index 0d76668a983..0e7889b069a 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java @@ -292,7 +292,7 @@ public class TemplateStore { load(); } catch (IOException x) { // can't log from jface-text - x.printStackTrace(); + handleException(x); } if (oldValue != null) { |