Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2020-09-25 05:37:41 +0000
committerAlexander Kurtakov2020-09-25 06:49:59 +0000
commit88b7738f47e91630620220bbf93b5118859c212f (patch)
tree8b7b6d99c65866dbf34b1586ab328be174c08d75
parentf6850dfd36eb232af9f45238fffff5b3df9ac4e1 (diff)
downloadeclipse.platform.text-88b7738f47e91630620220bbf93b5118859c212f.tar.gz
eclipse.platform.text-88b7738f47e91630620220bbf93b5118859c212f.tar.xz
eclipse.platform.text-88b7738f47e91630620220bbf93b5118859c212f.zip
Improve TextEditorPluginTest
* Use assertEquals instead of assertTrue for better error messages in case of failure * Fix some warning about boxing operations. Change-Id: Ie1969f516f5590dae9ed17c4d9e648dc56a6fcef Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
-rw-r--r--org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/TextEditorPluginTest.java40
1 files changed, 20 insertions, 20 deletions
diff --git a/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/TextEditorPluginTest.java b/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/TextEditorPluginTest.java
index 57d2faea923..7c756fefb97 100644
--- a/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/TextEditorPluginTest.java
+++ b/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/TextEditorPluginTest.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2000, 2016 IBM Corporation and others.
+ * Copyright (c) 2000, 2020 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
@@ -50,20 +50,20 @@ public class TextEditorPluginTest {
assertEquals(0, history.getSize());
history.addOrReplace(10);
assertEquals(1, history.getSize());
- assertTrue(10 == history.getCurrentBrowsePoint());
+ assertEquals(10, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(20);
assertEquals(2, history.getSize());
- assertTrue(20 == history.getCurrentBrowsePoint());
+ assertEquals(20, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(30);
assertEquals(3, history.getSize());
- assertTrue(30 == history.getCurrentBrowsePoint());
+ assertEquals(30, history.getCurrentBrowsePoint().intValue());
checkContent(history, new Integer[] { 10, 20, 30 });
- int replaced = history.addOrReplace(40);
+ int replaced= history.addOrReplace(40).intValue();
assertEquals(3, history.getSize());
assertEquals(10, replaced);
assertEquals(Integer.valueOf(40), history.getCurrentBrowsePoint());
@@ -88,17 +88,17 @@ public class TextEditorPluginTest {
assertTrue(history.contains(31));
assertFalse(history.contains(30));
assertEquals(30, replaced);
- assertTrue(31 == history.getCurrentBrowsePoint());
+ assertEquals(31, history.getCurrentBrowsePoint().intValue());
checkContent(history, new Integer[] { 40, 22, 31 });
replaced = history.addOrReplace(60);
assertTrue(history.contains(60));
- assertTrue(60 == history.getCurrentBrowsePoint());
+ assertEquals(60, history.getCurrentBrowsePoint().intValue());
assertEquals(3, history.getSize());
checkContent(history, new Integer[] { 22, 31, 60 });
- assertTrue(31 == history.browseBackward());
- assertTrue(31 == history.getCurrentBrowsePoint());
+ assertEquals(31, history.browseBackward().intValue());
+ assertEquals(31, history.getCurrentBrowsePoint().intValue());
assertEquals(3, history.getSize());
//consuming size times should bring you full circle back to origin
@@ -135,17 +135,17 @@ public class TextEditorPluginTest {
assertEquals(0, history.getSize());
history.addOrReplace(10);
assertEquals(1, history.getSize());
- assertTrue(10 == history.getCurrentBrowsePoint());
+ assertEquals(10, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(20);
assertEquals(2, history.getSize());
- assertTrue(20 == history.getCurrentBrowsePoint());
+ assertEquals(20, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(30);
assertEquals(3, history.getSize());
- assertTrue(30 == history.getCurrentBrowsePoint());
+ assertEquals(30, history.getCurrentBrowsePoint().intValue());
- int replaced = history.addOrReplace(22);
+ int replaced= history.addOrReplace(22).intValue();
assertEquals(3, history.getSize());
assertEquals(20, replaced);
assertEquals(Integer.valueOf(22), history.getCurrentBrowsePoint());
@@ -167,15 +167,15 @@ public class TextEditorPluginTest {
assertEquals(0, history.getSize());
history.addOrReplace(10);
assertEquals(1, history.getSize());
- assertTrue(10 == history.getCurrentBrowsePoint());
+ assertEquals(10, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(10);
assertEquals(1, history.getSize());
- assertTrue(10 == history.getCurrentBrowsePoint());
+ assertEquals(10, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(11);
assertEquals(1, history.getSize());
- assertTrue(11 == history.getCurrentBrowsePoint());
+ assertEquals(11, history.getCurrentBrowsePoint().intValue());
}
@Test
@@ -217,15 +217,15 @@ public class TextEditorPluginTest {
assertEquals(0, history.getSize());
history.addOrReplace(10);
assertEquals(1, history.getSize());
- assertTrue(10 == history.getCurrentBrowsePoint());
+ assertEquals(10, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(20);
assertEquals(2, history.getSize());
- assertTrue(20 == history.getCurrentBrowsePoint());
+ assertEquals(20, history.getCurrentBrowsePoint().intValue());
history.addOrReplace(30);
assertEquals(3, history.getSize());
- assertTrue(30 == history.getCurrentBrowsePoint());
+ assertEquals(30, history.getCurrentBrowsePoint().intValue());
int replaced = history.addOrReplace(22);
assertEquals(3, history.getSize());
@@ -253,7 +253,7 @@ public class TextEditorPluginTest {
history.addOrReplace(20);
history.addOrReplace(30);
- int replaced = history.addOrReplace(22);
+ int replaced= history.addOrReplace(22).intValue();
assertEquals(3, history.getSize());
assertEquals(20, replaced);
assertEquals(Integer.valueOf(22), history.getCurrentBrowsePoint());

Back to the top