Bug 558510 partially revert: TextviewerY20200103-2350I20200105-0600I20200104-1800I20200104-0625I20200104-0600I20200103-1800

revert https://git.eclipse.org/r/#/c/152786/

Change-Id: I5cea88489165cc8741bd55efb05b5e9993fac355
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>

1 files changed, 13 insertions, 6 deletions

diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
index bc84985a25d..099931c4833 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
@@ -2633,7 +2633,8 @@ public class TextViewer extends Viewer implements
 		List<ISelectionChangedListener> listeners= fPostSelectionChangedListeners;
 		if (listeners != null) {
 			listeners= new ArrayList<>(listeners);
-			for (ISelectionChangedListener l : listeners) {
+			for (int i= 0; i < listeners.size(); i++) {
+				ISelectionChangedListener l= listeners.get(i);
 				l.selectionChanged(event);
 			}
 		}
@@ -2703,7 +2704,8 @@ public class TextViewer extends Viewer implements
 				event= ((SlaveDocumentEvent) event).getMasterEvent();
 
 			TextEvent e= new TextEvent(cmd.start, cmd.length, cmd.text, cmd.preservedText, event, redraws());
-			for (ITextListener l : textListeners) {
+			for (int i= 0; i < textListeners.size(); i++) {
+				ITextListener l= textListeners.get(i);
 				l.textChanged(e);
 			}
 		}
@@ -2745,7 +2747,8 @@ public class TextViewer extends Viewer implements
 	protected void fireInputDocumentAboutToBeChanged(IDocument oldInput, IDocument newInput) {
 		List<ITextInputListener> listener= fTextInputListeners;
 		if (listener != null) {
-			for (ITextInputListener l : listener) {
+			for (int i= 0; i < listener.size(); i++) {
+				ITextInputListener l= listener.get(i);
 				l.inputDocumentAboutToBeChanged(oldInput, newInput);
 			}
 		}
@@ -2761,7 +2764,8 @@ public class TextViewer extends Viewer implements
 	protected void fireInputDocumentChanged(IDocument oldInput, IDocument newInput) {
 		List<ITextInputListener> listener= fTextInputListeners;
 		if (listener != null) {
-			for (ITextInputListener l : listener) {
+			for (int i= 0; i < listener.size(); i++) {
+				ITextInputListener l= listener.get(i);
 				l.inputDocumentChanged(oldInput, newInput);
 			}
 		}
@@ -2978,7 +2982,8 @@ public class TextViewer extends Viewer implements
 			int topPixel= fTextWidget.getTopPixel();
 			if (topPixel >= 0 && topPixel != fLastTopPixel) {
 				if (fViewportListeners != null) {
-					for (IViewportListener l : fViewportListeners) {
+					for (int i= 0; i < fViewportListeners.size(); i++) {
+						IViewportListener l= fViewportListeners.get(i);
 						l.viewportChanged(topPixel);
 					}
 				}
@@ -4746,7 +4751,9 @@ public class TextViewer extends Viewer implements
 		 * and let them apply their presentation.
 		 */
 		if (fTextPresentationListeners != null) {
-			for (ITextPresentationListener listener : new ArrayList<>(fTextPresentationListeners)) {
+			ArrayList<ITextPresentationListener> listeners= new ArrayList<>(fTextPresentationListeners);
+			for (int i= 0, size= listeners.size(); i < size; i++) {
+				ITextPresentationListener listener= listeners.get(i);
 				listener.applyTextPresentation(presentation);
 			}
 		}