diff options
author | Mickael Istria | 2019-07-24 13:01:59 +0000 |
---|---|---|
committer | Mickael Istria | 2019-07-24 13:14:46 +0000 |
commit | dddf4f29b8a5d889d41e8e89d6aeadb0fdf9d6f3 (patch) | |
tree | 52201dcfef516e135a6ab9861daa043a601ed5b6 | |
parent | 8885a4e2cfbd3c7ef4323a16b71ce043c29fb586 (diff) | |
download | eclipse.platform.text-dddf4f29b8a5d889d41e8e89d6aeadb0fdf9d6f3.tar.gz eclipse.platform.text-dddf4f29b8a5d889d41e8e89d6aeadb0fdf9d6f3.tar.xz eclipse.platform.text-dddf4f29b8a5d889d41e8e89d6aeadb0fdf9d6f3.zip |
Bug 549415 - Remove useless fieldI20190724-1800
previousColor is not necessary any more as it's the value that's in the
preferenceStore already.
Change-Id: Ia40d18b8dc3adec4354d682045601d72ed02dc79
Signed-off-by: Mickael Istria <mistria@redhat.com>
-rw-r--r-- | org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorDefaultsPreferencePage.java | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorDefaultsPreferencePage.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorDefaultsPreferencePage.java index 058204564be..d932500102c 100644 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorDefaultsPreferencePage.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorDefaultsPreferencePage.java @@ -658,12 +658,10 @@ public class TextEditorDefaultsPreferencePage extends PreferencePage implements private class ColorEntry { public final String colorKey; public final String label; - public RGB previousColor; public final String isSystemDefaultKey; public ColorEntry(String colorKey, String label, String isSystemDefaultKey) { this.colorKey= colorKey; this.label= label; - this.previousColor= PreferenceConverter.getColor(fOverlayStore, colorKey); this.isSystemDefaultKey= isSystemDefaultKey; } @@ -680,7 +678,6 @@ public class TextEditorDefaultsPreferencePage extends PreferencePage implements } public void setColor(RGB rgb) { - this.previousColor= PreferenceConverter.getColor(fOverlayStore, this.colorKey); PreferenceConverter.setValue(fOverlayStore, this.colorKey, rgb); } @@ -965,7 +962,7 @@ public class TextEditorDefaultsPreferencePage extends PreferencePage implements SelectionListener colorDefaultSelectionListener= new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { - ColorEntry colorEntry = getSelectedAppearanceColorOption(); + ColorEntry colorEntry= getSelectedAppearanceColorOption(); if (colorEntry.allowSystemDefault()) { colorEntry.setSystemDefault(fAppearanceColorDefault.getSelection()); handleAppearanceColorListSelection(); // refresh color preview and checkbox state |