Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2021-04-09 05:49:09 +0000
committerLars Vogel2021-06-29 14:13:41 +0000
commit522a7a8f74e689900e28c557a5e1aed4fa0db899 (patch)
tree529ecdc23fcfb8b62f72255760b1961c118b4c6f
parent1ce367300d0e337e810abf85f6d6c88f4d539834 (diff)
downloadeclipse.platform.text-522a7a8f74e689900e28c557a5e1aed4fa0db899.tar.gz
eclipse.platform.text-522a7a8f74e689900e28c557a5e1aed4fa0db899.tar.xz
eclipse.platform.text-522a7a8f74e689900e28c557a5e1aed4fa0db899.zip
test code Using this cleanup brings: - It reviews the feature - For optimization: small memory usage reduction as the outer pointer is removed Change-Id: Id3b4fcee22e52183fd8f00740e0ba4d152954e1c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179071 Tested-by: Platform Bot <platform-bot@eclipse.org>
-rw-r--r--org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java2
-rw-r--r--org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java2
-rw-r--r--org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java2
-rw-r--r--org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java2
-rw-r--r--org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java2
5 files changed, 5 insertions, 5 deletions
diff --git a/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java b/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java
index 1eeaeb8c4..e4af1d0a7 100644
--- a/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java
+++ b/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java
@@ -55,7 +55,7 @@ import org.eclipse.jface.text.tests.util.DisplayHelper;
public class CodeMiningProjectionViewerTest {
- private final class RepeatLettersCodeMiningProvider implements ICodeMiningProvider {
+ private static final class RepeatLettersCodeMiningProvider implements ICodeMiningProvider {
@Override
public CompletableFuture<List<? extends ICodeMining>> provideCodeMinings(ITextViewer viewer, IProgressMonitor monitor) {
List<LineContentCodeMining> codeMinings = new ArrayList<>();
diff --git a/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java b/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java
index 8e1b117ad..e4b7b9503 100644
--- a/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java
+++ b/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java
@@ -40,7 +40,7 @@ import org.eclipse.jface.text.source.IAnnotationModelListener;
*/
public class AnnotationModelExtension2Test {
- public class OldAnnotationModel implements IAnnotationModel {
+ public static class OldAnnotationModel implements IAnnotationModel {
private final HashMap<Annotation, Position> fAnnotations= new HashMap<>();
diff --git a/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java b/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java
index ddec67907..c701103bb 100644
--- a/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java
+++ b/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java
@@ -830,7 +830,7 @@ public class LinkedModeModelTest {
" Ich habe schon so viel fur dich getan,\n" +
" Das mir zu tun fast nichts mehr ubrigbleibt.";
- private class LinkedAdapter implements ILinkedModeListener {
+ private static class LinkedAdapter implements ILinkedModeListener {
@Override
public void left(LinkedModeModel environment, int flags) {}
@Override
diff --git a/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java b/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java
index 8277314c2..8a7c77978 100644
--- a/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java
+++ b/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java
@@ -114,7 +114,7 @@ public class MarkerAnnotationOrderTest {
}
- public class TestMarkerAnnotationModel extends AbstractMarkerAnnotationModel {
+ public static class TestMarkerAnnotationModel extends AbstractMarkerAnnotationModel {
@Override
protected IMarker[] retrieveMarkers() throws CoreException {
return null;
diff --git a/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java b/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java
index 0c9f94ad3..c3d6a09c9 100644
--- a/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java
+++ b/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java
@@ -41,7 +41,7 @@ public class MinimapPageTest {
None, ITextViewer, ITextOperationTarget
}
- class MyTextEditor extends StatusTextEditor {
+ static class MyTextEditor extends StatusTextEditor {
private final TextVieverAdapterKind kind;

Back to the top