Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis Ungemach2022-03-17 11:20:55 +0000
committerSebastian Ratz2022-03-17 13:24:22 +0000
commitbe2ef6867a344a6ed42a235f139ab695bd8e31e8 (patch)
treeb58b19aab3ce62e92d3da66746896c3d9ee38828
parent99a2f5ea1eded2d0cae375b581af1354d973cb22 (diff)
downloadeclipse.platform.text-be2ef6867a344a6ed42a235f139ab695bd8e31e8.tar.gz
eclipse.platform.text-be2ef6867a344a6ed42a235f139ab695bd8e31e8.tar.xz
eclipse.platform.text-be2ef6867a344a6ed42a235f139ab695bd8e31e8.zip
Bug 579294: NPE in TextViewer.computeSelectionI20220318-0220I20220317-1800
fTextWidget can be null at line 2525 Change-Id: I460e7d881f24a8f10926b26e6b50d299d0dfa87a Signed-off-by: Denis Ungemach <denis.ungemach@sap.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/191989 Reviewed-by: Tobias Melcher <tobias.melcher@sap.com> Reviewed-by: Sebastian Ratz <sebastian.ratz@sap.com> Tested-by: Platform Bot <platform-bot@eclipse.org>
-rw-r--r--org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java4
1 files changed, 4 insertions, 0 deletions
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
index 60c174a9103..eef1d5bd442 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
@@ -2522,6 +2522,10 @@ public class TextViewer extends Viewer implements
if (!redraws() && fViewerState != null) {
return toSelection(Arrays.stream(fViewerState.getSelection()).map(point -> new Region(point.x, point.y)).toArray(IRegion[]::new));
}
+
+ if (fTextWidget == null)
+ return TextSelection.emptySelection();
+
int[] ranges= fTextWidget.getSelectionRanges();
IRegion[] selectedRanges= new IRegion[ranges.length / 2];
for (int i= 0; i < selectedRanges.length; i++) {

Back to the top