Use JDT static inner class clean up for search plug-insI20210616-1800

This ticket uses and tests the "Use static inner class" cleanup feature:
 - It reviews the feature
 - It reduces the memory consumption as it avoids the pointer to the
outer class

Example:

Before:

public class Outer {

public class InnerClass {
    int i;

    public boolean anotherMethod() {
        return true;
    }
}
}

After:

public class Outer {

public static class InnerClass {
    int i;

    public boolean anotherMethod() {
        return true;
    }
}
}


Change-Id: If2fd5457666e4161e3eafa25893b0ec38d8eb36a
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181576
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>

2 files changed, 2 insertions, 2 deletions

diff --git a/org.eclipse.search/search/org/eclipse/search/internal/core/text/FileCharSequenceProvider.java b/org.eclipse.search/search/org/eclipse/search/internal/core/text/FileCharSequenceProvider.java
index 080ac46459b..1a2ef398886 100644
--- a/org.eclipse.search/search/org/eclipse/search/internal/core/text/FileCharSequenceProvider.java
+++ b/org.eclipse.search/search/org/eclipse/search/internal/core/text/FileCharSequenceProvider.java
@@ -232,7 +232,7 @@ public class FileCharSequenceProvider {
 		}
 	}
 
-	private final class FileCharSequence implements CharSequence {
+	private static final class FileCharSequence implements CharSequence {
 		private Reader fReader;
 		private int fReaderPos;
 
diff --git a/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchQuickAccessComputer.java b/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchQuickAccessComputer.java
index 9a29502d247..552bf46ccd4 100644
--- a/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchQuickAccessComputer.java
+++ b/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchQuickAccessComputer.java
@@ -85,7 +85,7 @@ public class QuickSearchQuickAccessComputer extends QuickTextSearchRequestor imp
 		return false;
 	}
 
-	private class LineItemQuickAccessElement extends QuickAccessElement {
+	private static class LineItemQuickAccessElement extends QuickAccessElement {
 
 		private final LineItem item;