diff options
| author | Lars Vogel | 2021-06-08 09:54:54 +0000 |
|---|---|---|
| committer | Lars Vogel | 2021-06-22 10:02:06 +0000 |
| commit | 5a8824f73257a5cf03c6eebf5268bc7f4d30c310 (patch) | |
| tree | a90b57627347a60a272184e82ba6a82f518f547c | |
| parent | dc887d8ec3e58d68a617566f92d8646be4e7fc63 (diff) | |
| download | eclipse.platform.text-5a8824f73257a5cf03c6eebf5268bc7f4d30c310.tar.gz eclipse.platform.text-5a8824f73257a5cf03c6eebf5268bc7f4d30c310.tar.xz eclipse.platform.text-5a8824f73257a5cf03c6eebf5268bc7f4d30c310.zip | |
Use JDT static inner class clean up forY20210629-0800Y20210623-0320Y20210622-1150I20210629-0210I20210628-1800I20210627-1800I20210626-1800I20210625-1800I20210624-1800I20210624-1210I20210622-1800
ui.editors
This ticket uses and tests the "Use static inner class" cleanup feature:
- It reviews the feature
- It reduces the memory consumption as it avoids the pointer to the
outer class
Example:
Before:
public class Outer {
public class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
After:
public class Outer {
public static class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
Change-Id: Id13454b3c8e1e8ca6628d4f15cc6f0aec37cd62a
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181573
Tested-by: Platform Bot <platform-bot@eclipse.org>
3 files changed, 3 insertions, 3 deletions
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java index deb90eef64c..2d009b22ce3 100644 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java @@ -59,7 +59,7 @@ import org.eclipse.ui.editors.text.ITextEditorHelpContextIds; public class AccessibilityPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { - private abstract class Initializer { + private abstract static class Initializer { protected final Preference fPreference; diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java index cd43988586a..35b7aae8b91 100644 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java @@ -109,7 +109,7 @@ class AnnotationsConfigurationBlock implements IPreferenceConfigurationBlock { } - private final class ItemLabelProvider extends LabelProvider { + private static final class ItemLabelProvider extends LabelProvider { @Override public String getText(Object element) { diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java index 2d8255effee..ea11e2426ff 100755 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java @@ -108,7 +108,7 @@ class LinkedModeConfigurationBlock implements IPreferenceConfigurationBlock { } } - private final class ItemLabelProvider extends LabelProvider { + private static final class ItemLabelProvider extends LabelProvider { @Override public String getText(Object element) { |