diff options
| author | Lars Vogel | 2021-04-09 05:49:09 +0000 |
|---|---|---|
| committer | Lars Vogel | 2021-06-29 14:13:41 +0000 |
| commit | 522a7a8f74e689900e28c557a5e1aed4fa0db899 (patch) | |
| tree | 529ecdc23fcfb8b62f72255760b1961c118b4c6f | |
| parent | 1ce367300d0e337e810abf85f6d6c88f4d539834 (diff) | |
| download | eclipse.platform.text-I20210711-1800.tar.gz eclipse.platform.text-I20210711-1800.tar.xz eclipse.platform.text-I20210711-1800.zip | |
[dogfooding][cleanup] Use static inner class clean up forY20210708-0800Y20210706-1050Y20210706-0800Y20210701-0800Y20210630-0410Y20210630-0230S4_21_0_M1I20210712-1800I20210712-0340I20210712-0240I20210711-1800I20210710-1800I20210710-0000I20210709-0030I20210707-1800I20210707-0600I20210706-1800I20210706-0600I20210705-1800I20210705-0600I20210704-1800I20210704-0600I20210703-1800I20210703-0600I20210702-1800I20210701-1800I20210630-1800I20210629-1800
test code
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: Id3b4fcee22e52183fd8f00740e0ba4d152954e1c
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179071
Tested-by: Platform Bot <platform-bot@eclipse.org>
5 files changed, 5 insertions, 5 deletions
diff --git a/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java b/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java index 1eeaeb8c47b..e4af1d0a71e 100644 --- a/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java +++ b/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningProjectionViewerTest.java @@ -55,7 +55,7 @@ import org.eclipse.jface.text.tests.util.DisplayHelper; public class CodeMiningProjectionViewerTest { - private final class RepeatLettersCodeMiningProvider implements ICodeMiningProvider { + private static final class RepeatLettersCodeMiningProvider implements ICodeMiningProvider { @Override public CompletableFuture<List<? extends ICodeMining>> provideCodeMinings(ITextViewer viewer, IProgressMonitor monitor) { List<LineContentCodeMining> codeMinings = new ArrayList<>(); diff --git a/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java b/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java index 8e1b117ad60..e4b7b9503bf 100644 --- a/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java +++ b/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java @@ -40,7 +40,7 @@ import org.eclipse.jface.text.source.IAnnotationModelListener; */ public class AnnotationModelExtension2Test { - public class OldAnnotationModel implements IAnnotationModel { + public static class OldAnnotationModel implements IAnnotationModel { private final HashMap<Annotation, Position> fAnnotations= new HashMap<>(); diff --git a/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java b/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java index ddec67907ec..c701103bbf9 100644 --- a/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java +++ b/org.eclipse.text.tests/src/org/eclipse/text/tests/link/LinkedModeModelTest.java @@ -830,7 +830,7 @@ public class LinkedModeModelTest { " Ich habe schon so viel fur dich getan,\n" + " Das mir zu tun fast nichts mehr ubrigbleibt."; - private class LinkedAdapter implements ILinkedModeListener { + private static class LinkedAdapter implements ILinkedModeListener { @Override public void left(LinkedModeModel environment, int flags) {} @Override diff --git a/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java b/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java index 8277314c291..8a7c77978f8 100644 --- a/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java +++ b/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/MarkerAnnotationOrderTest.java @@ -114,7 +114,7 @@ public class MarkerAnnotationOrderTest { } - public class TestMarkerAnnotationModel extends AbstractMarkerAnnotationModel { + public static class TestMarkerAnnotationModel extends AbstractMarkerAnnotationModel { @Override protected IMarker[] retrieveMarkers() throws CoreException { return null; diff --git a/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java b/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java index 0c9f94ad317..c3d6a09c9d9 100644 --- a/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java +++ b/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/minimap/MinimapPageTest.java @@ -41,7 +41,7 @@ public class MinimapPageTest { None, ITextViewer, ITextOperationTarget } - class MyTextEditor extends StatusTextEditor { + static class MyTextEditor extends StatusTextEditor { private final TextVieverAdapterKind kind; |