Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKarsten Thoms2019-11-06 01:09:26 +0000
committerKarsten Thoms2019-11-07 07:44:34 +0000
commit17d364f73be3faff1fdf3cb359b133a901943273 (patch)
tree8245e25b59a29fe229b074a2b0ac7e4f599d7288
parent159deab97eeaad26f99a9234460f9ec87aac745f (diff)
downloadeclipse.platform.text-17d364f73be3faff1fdf3cb359b133a901943273.tar.gz
eclipse.platform.text-17d364f73be3faff1fdf3cb359b133a901943273.tar.xz
eclipse.platform.text-17d364f73be3faff1fdf3cb359b133a901943273.zip
Bug 431002 - Prevent execution when proposal table was disposed
Add a disposal guard to ProposalSelectionHandler.execute to check that fProposalTable was not disposed already. Change-Id: If41c3a02f1688dc68db5aac9d38208d3ceb08f8d Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
-rw-r--r--org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/CompletionProposalPopup.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/CompletionProposalPopup.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/CompletionProposalPopup.java
index 24ca3e733..cc928a901 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/CompletionProposalPopup.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/CompletionProposalPopup.java
@@ -141,6 +141,9 @@ class CompletionProposalPopup implements IContentAssistListener {
@Override
public Object execute(ExecutionEvent event) throws ExecutionException {
+ if (fProposalTable.isDisposed()) {
+ return null;
+ }
int itemCount= fProposalTable.getItemCount();
int selectionIndex= fProposalTable.getSelectionIndex();
switch (fOperationCode) {

Back to the top