135061 [api] make public constants for private edit menu groups

- also corrected component.xml entry for ITextEditorActionConstants which has been implementable since day 1.

3 files changed, 17 insertions, 6 deletions

diff --git a/org.eclipse.ui.workbench.texteditor/component.xml b/org.eclipse.ui.workbench.texteditor/component.xml
index d1bb09fd0ae..0733a62152e 100644
--- a/org.eclipse.ui.workbench.texteditor/component.xml
+++ b/org.eclipse.ui.workbench.texteditor/component.xml
@@ -17,7 +17,6 @@
    <type name="GotoAnnotationAction" subclass="false"/>
    <type name="GotoLineAction" subclass="false"/>
    <type name="IncrementalFindAction" subclass="false"/>
-   <type name="ITextEditorActionConstants" implement="false"/>
    <type name="ITextEditorDropTargetListener" implement="false"/>
    <type name="RevertToSavedAction" subclass="false"/>
    <type name="SaveAction" subclass="false"/>
diff --git a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/BasicTextEditorActionContributor.java b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/BasicTextEditorActionContributor.java
index e319cdf06ca..a216c7abb62 100644
--- a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/BasicTextEditorActionContributor.java
+++ b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/BasicTextEditorActionContributor.java
@@ -255,14 +255,12 @@ public class BasicTextEditorActionContributor extends EditorActionBarContributor
 			editMenu.prependToGroup(IWorkbenchActionConstants.FIND_EXT, fFindNext);
 
 			addOrInsert(editMenu, new Separator(ITextEditorActionConstants.GROUP_OPEN));
-			String GROUP_INFORMATION= "group.information"; //$NON-NLS-1$ // TODO make this an IWorkbenchActionConstants constant in 3.3
-			addOrInsert(editMenu, new Separator(GROUP_INFORMATION));
-			String GROUP_ASSIST= "group.assist"; //$NON-NLS-1$ // TODO make this an IWorkbenchActionConstants constant in 3.3
-			addOrInsert(editMenu, new Separator(GROUP_ASSIST));
+			addOrInsert(editMenu, new Separator(ITextEditorActionConstants.GROUP_INFORMATION));
+			addOrInsert(editMenu, new Separator(ITextEditorActionConstants.GROUP_ASSIST));
 			addOrInsert(editMenu, new Separator(ITextEditorActionConstants.GROUP_GENERATE));
 			addOrInsert(editMenu, new Separator(IWorkbenchActionConstants.MB_ADDITIONS));
 
-			editMenu.appendToGroup(GROUP_ASSIST, fHippieCompletion);
+			editMenu.appendToGroup(ITextEditorActionConstants.GROUP_ASSIST, fHippieCompletion);
 		}
 
 		IMenuManager navigateMenu= menu.findMenuUsingPath(IWorkbenchActionConstants.M_NAVIGATE);
diff --git a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/ITextEditorActionConstants.java b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/ITextEditorActionConstants.java
index 6ec5a839135..d22710dc40c 100644
--- a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/ITextEditorActionConstants.java
+++ b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/ITextEditorActionConstants.java
@@ -487,6 +487,20 @@ public interface ITextEditorActionConstants extends IWorkbenchActionConstants {
 	String GROUP_RESTORE= "restore"; //$NON-NLS-1$
 
 	/**
+	 * Context menu group for actions that display additional information. Value:
+	 * <code>"group.information"</code>.
+	 * @since 3.2
+	 */
+	String GROUP_INFORMATION= "group.information"; //$NON-NLS-1$
+
+	/**
+	 * Context menu group for typing aid actions such as content assist. Value:
+	 * <code>"group.assist"</code>.
+	 * @since 3.2
+	 */
+	String GROUP_ASSIST= "group.assist"; //$NON-NLS-1$
+
+	/**
 	 * Name of the action for showing the preferences from the editor context
 	 * menu. Value: <code>"Preferences.ContextAction"</code>
 	 * @since 3.1