Use addAll, deleteAll instead of looping through a collectionI20190618-1805

Change-Id: If74eec05fb721ceeb1f9f8d7fbac9d68be6e767f
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

2 files changed, 4 insertions, 6 deletions

diff --git a/tests/org.eclipse.team.tests.core/src/org/eclipse/team/tests/ui/synchronize/ResourceContentTests.java b/tests/org.eclipse.team.tests.core/src/org/eclipse/team/tests/ui/synchronize/ResourceContentTests.java
index f4d01f0b6..b37d930a9 100644
--- a/tests/org.eclipse.team.tests.core/src/org/eclipse/team/tests/ui/synchronize/ResourceContentTests.java
+++ b/tests/org.eclipse.team.tests.core/src/org/eclipse/team/tests/ui/synchronize/ResourceContentTests.java
@@ -14,6 +14,7 @@
 package org.eclipse.team.tests.ui.synchronize;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
@@ -101,9 +102,7 @@ public class ResourceContentTests extends TeamTest {
 	private void assertContentsMatch(IResource[] resources) {
 		Set paths = getPaths(ResourcesPlugin.getWorkspace().getRoot());
 		Set<Object> resourceSet = new HashSet<>();
-		for (IResource resource : resources) {
-			resourceSet.add(resource);
-		}
+		Collections.addAll(resourceSet, resources);
 		for (Iterator iterator = paths.iterator(); iterator.hasNext();) {
 			TreePath path = (TreePath) iterator.next();
 			Object o = path.getLastSegment();
diff --git a/tests/org.eclipse.team.tests.cvs.core/src/org/eclipse/team/tests/ccvs/core/mappings/model/ModelProject.java b/tests/org.eclipse.team.tests.cvs.core/src/org/eclipse/team/tests/ccvs/core/mappings/model/ModelProject.java
index 731e09963..639af6f61 100644
--- a/tests/org.eclipse.team.tests.cvs.core/src/org/eclipse/team/tests/ccvs/core/mappings/model/ModelProject.java
+++ b/tests/org.eclipse.team.tests.cvs.core/src/org/eclipse/team/tests/ccvs/core/mappings/model/ModelProject.java
@@ -14,6 +14,7 @@
 package org.eclipse.team.tests.ccvs.core.mappings.model;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 
 import org.eclipse.core.resources.IContainer;
@@ -38,9 +39,7 @@ public class ModelProject extends ModelObject {
 		IProjectDescription description = project.getDescription();
 		String[] natureIds = description.getNatureIds();
 		List<String> result = new ArrayList<>();
-		for (String natureId : natureIds) {
-			result.add(natureId);
-		}
+		Collections.addAll(result, natureIds);
 		result.add(ModelNature.NATURE_ID);
 		description.setNatureIds(result.toArray(new String[result
 				.size()]));