diff options
author | Alexander Kurtakov | 2019-04-17 10:55:16 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2019-04-17 11:24:36 +0000 |
commit | ca7a24d40322f481ddee4bef4a5bdf5bdc317730 (patch) | |
tree | 913c0d3d664494f904325ac4e9e01ffb718a6f87 /examples/org.eclipse.team.examples.filesystem | |
parent | 13e262c90c87ff0d0261ab9706b151e915cb0b11 (diff) | |
download | eclipse.platform.team-ca7a24d40322f481ddee4bef4a5bdf5bdc317730.tar.gz eclipse.platform.team-ca7a24d40322f481ddee4bef4a5bdf5bdc317730.tar.xz eclipse.platform.team-ca7a24d40322f481ddee4bef4a5bdf5bdc317730.zip |
Remove useless non-javadoc/@see comments. (take 4)I20190417-1800
Put @Override instead where needed.
Change-Id: I3798bfbb5fd3c05c16531f7fac7885d2f6eb65b7
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Diffstat (limited to 'examples/org.eclipse.team.examples.filesystem')
11 files changed, 33 insertions, 67 deletions
diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/DisconnectAction.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/DisconnectAction.java index 76b52e88a..b945dc303 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/DisconnectAction.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/DisconnectAction.java @@ -26,20 +26,19 @@ import org.eclipse.team.internal.ui.actions.TeamAction; */ public class DisconnectAction extends TeamAction { + @Override protected void execute(IAction action) { IProject projects[] = getSelectedProjects(); try { - for (int i = 0; i < projects.length; i++) { - RepositoryProvider.unmap(projects[i]); + for (IProject project : projects) { + RepositoryProvider.unmap(project); } } catch (TeamException e) { ErrorDialog.openError(getShell(), Policy.bind("DisconnectAction.errorTitle"), null, e.getStatus()); //$NON-NLS-1$ } } - /** - * @see TeamAction#isEnabled() - */ + @Override public boolean isEnabled() { return true; } diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/FileSystemPropertiesPage.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/FileSystemPropertiesPage.java index ba912f4cf..b837bc758 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/FileSystemPropertiesPage.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/filesystem/ui/FileSystemPropertiesPage.java @@ -18,7 +18,9 @@ import org.eclipse.core.runtime.IAdaptable; import org.eclipse.swt.SWT; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; -import org.eclipse.swt.widgets.*; +import org.eclipse.swt.widgets.Composite; +import org.eclipse.swt.widgets.Control; +import org.eclipse.swt.widgets.Label; import org.eclipse.ui.dialogs.PropertyPage; /* * A property page which displays the file system specific properties @@ -64,9 +66,7 @@ public class FileSystemPropertiesPage extends PropertyPage { return resource; } - /* - * @see PreferencePage#createContents(Composite) - */ + @Override protected Control createContents(Composite parent) { Composite composite = new Composite(parent, SWT.NONE); GridLayout layout = new GridLayout(); diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/model/ModelResource.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/model/ModelResource.java index 2a4dceb7e..47f12a6e2 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/model/ModelResource.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/model/ModelResource.java @@ -46,21 +46,22 @@ public abstract class ModelResource extends ModelObject{ return resource; } + @Override public String getName() { return getResource().getName(); } + @Override public String getPath() { return getResource().getFullPath().makeRelative().toString(); } + @Override public ModelObject getParent() { return ModelObject.create(getResource().getParent()); } - /* (non-Javadoc) - * @see java.lang.Object#equals(java.lang.Object) - */ + @Override public boolean equals(Object obj) { if (obj instanceof ModelResource) { ModelResource mr = (ModelResource) obj; @@ -69,23 +70,17 @@ public abstract class ModelResource extends ModelObject{ return super.equals(obj); } - /* (non-Javadoc) - * @see java.lang.Object#hashCode() - */ + @Override public int hashCode() { return getResource().hashCode(); } - /* (non-Javadoc) - * @see org.eclipse.team.examples.model.ModelObject#delete() - */ + @Override public void delete() throws CoreException { getResource().delete(false, null); } - /* (non-Javadoc) - * @see org.eclipse.team.examples.model.ModelObject#getProject() - */ + @Override public ModelProject getProject() { return (ModelProject)ModelObject.create(getResource().getProject()); } diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticFilesystemProvider.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticFilesystemProvider.java index cb01bf474..07c5ee344 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticFilesystemProvider.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticFilesystemProvider.java @@ -322,9 +322,6 @@ public class PessimisticFilesystemProvider extends RepositoryProvider { return new ByteArrayInputStream(byteOut.toByteArray()); } - /* - * @see IProjectNature#setProject(IProject) - */ @Override public void setProject(IProject project) { if (PessimisticFilesystemProviderPlugin.getInstance().isDebugging()) { diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticModificationValidator.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticModificationValidator.java index ee77e88b9..1fb183f2b 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticModificationValidator.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/PessimisticModificationValidator.java @@ -57,9 +57,6 @@ extends FileModificationValidator { fProvider= provider; } - /** - * @see IFileModificationValidator#validateEdit(IFile[], Object) - */ @Override public IStatus validateEdit(IFile[] files, FileModificationValidationContext context) { if (files.length == 0) { @@ -146,9 +143,6 @@ extends FileModificationValidator { return new MultiStatus( getUid(), IStatus.OK, children, "Some files were not successfully checked out", null); } - /** - * @see IFileModificationValidator#validateSave(IFile) - */ @Override public IStatus validateSave(IFile file) { int checkedInFilesSaved = getPreferences().getInt(IPessimisticFilesystemConstants.PREF_CHECKED_IN_FILES_SAVED); diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ResourceChangeListener.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ResourceChangeListener.java index 4c35307e0..3ee5c2ba6 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ResourceChangeListener.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ResourceChangeListener.java @@ -120,9 +120,6 @@ public class ResourceChangeListener implements IResourceDeltaVisitor, IResourceC return resources; } - /** - * @see IResourceChangeListener#resourceChanged(IResourceChangeEvent) - */ @Override public void resourceChanged (IResourceChangeEvent event) { try { diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckInAction.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckInAction.java index f19c5abfb..0168b9932 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckInAction.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckInAction.java @@ -29,6 +29,7 @@ public class CheckInAction extends SourceManagementAction { * * @see PessimisticProviderAction#shouldEnableFor(IResource) */ + @Override protected boolean shouldEnableFor(IResource resource) { if (resource == null) return false; @@ -42,9 +43,7 @@ public class CheckInAction extends SourceManagementAction { return provider.isCheckedout(resource); } - /* - * @see SourceControlAction#manageResources(PessimisticFilesystemProvider, IResource[], IProgressMonitor) - */ + @Override protected void manageResources(PessimisticFilesystemProvider provider, IResource[] resources, IProgressMonitor monitor) { provider.checkin(resources, monitor); } diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckOutAction.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckOutAction.java index f3ea2df21..38ca10a8e 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckOutAction.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/CheckOutAction.java @@ -28,6 +28,7 @@ public class CheckOutAction extends SourceManagementAction { * * @see PessimisticProviderAction#shouldEnableFor(IResource) */ + @Override protected boolean shouldEnableFor(IResource resource) { if (resource == null) return false; @@ -41,9 +42,7 @@ public class CheckOutAction extends SourceManagementAction { return !provider.isCheckedout(resource); } - /* - * @see SourceControlAction#manageResources(PessimisticFilesystemProvider, IResource[], IProgressMonitor) - */ + @Override protected void manageResources(PessimisticFilesystemProvider provider, IResource[] resources, IProgressMonitor monitor) { provider.checkout(resources, monitor); } diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/ConfigurationWizard.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/ConfigurationWizard.java index c713ec4d8..14c058d13 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/ConfigurationWizard.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/ConfigurationWizard.java @@ -31,17 +31,13 @@ public class ConfigurationWizard extends Wizard implements IConfigurationWizard */ private IProject project; - /* - * @see Wizard#addPages() - */ + @Override public void addPages() { // workaround the wizard problem addPage(new BlankPage()); } - /* - * @see Wizard#performFinish() - */ + @Override public boolean performFinish() { try { RepositoryProvider.map(project, PessimisticFilesystemProviderPlugin.NATURE_ID); @@ -52,9 +48,7 @@ public class ConfigurationWizard extends Wizard implements IConfigurationWizard return true; } - /* - * @see IConfigurationWizard#init(IWorkbench, IProject) - */ + @Override public void init(IWorkbench workbench, IProject project) { this.project = project; } diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/PessimisticPreferencesPage.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/PessimisticPreferencesPage.java index 158e4a9f9..322a13705 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/PessimisticPreferencesPage.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/PessimisticPreferencesPage.java @@ -18,7 +18,11 @@ import org.eclipse.jface.preference.PreferencePage; import org.eclipse.swt.SWT; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; -import org.eclipse.swt.widgets.*; +import org.eclipse.swt.widgets.Button; +import org.eclipse.swt.widgets.Combo; +import org.eclipse.swt.widgets.Composite; +import org.eclipse.swt.widgets.Control; +import org.eclipse.swt.widgets.Label; import org.eclipse.team.examples.pessimistic.IPessimisticFilesystemConstants; import org.eclipse.team.examples.pessimistic.PessimisticFilesystemProviderPlugin; import org.eclipse.ui.IWorkbench; @@ -114,9 +118,7 @@ public class PessimisticPreferencesPage IPessimisticFilesystemConstants.OPTION_DO_NOTHING, }; - /* - * @see org.eclipse.jface.preference.PreferencePage#doGetPreferenceStore() - */ + @Override protected IPreferenceStore doGetPreferenceStore() { return PessimisticFilesystemProviderPlugin.getInstance().getPreferenceStore(); } @@ -139,9 +141,7 @@ public class PessimisticPreferencesPage group.setLayoutData(data); } - /* - * @see org.eclipse.jface.preference.PreferencePage#createContents(Composite) - */ + @Override protected Control createContents(Composite parent) { Composite composite = new Composite(parent, SWT.NULL); setDefaultLayout(composite, 1); @@ -237,16 +237,12 @@ public class PessimisticPreferencesPage return composite; } - /* - * @see org.eclipse.ui.IWorkbenchPreferencePage#init(IWorkbench) - */ + @Override public void init(IWorkbench workbench) { // do nothing } - /* - * @see org.eclipse.jface.preference.PreferencePage#performDefaults() - */ + @Override protected void performDefaults() { IPreferenceStore store = getPreferenceStore(); @@ -265,9 +261,7 @@ public class PessimisticPreferencesPage super.performDefaults(); } - /* - * @see org.eclipse.jface.preference.IPreferencePage#performOk() - */ + @Override public boolean performOk() { IPreferenceStore store = getPreferenceStore(); diff --git a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/UncheckOutAction.java b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/UncheckOutAction.java index 7055dbc2d..a06bf4668 100644 --- a/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/UncheckOutAction.java +++ b/examples/org.eclipse.team.examples.filesystem/src/org/eclipse/team/examples/pessimistic/ui/UncheckOutAction.java @@ -22,9 +22,7 @@ import org.eclipse.team.examples.pessimistic.PessimisticFilesystemProvider; * selected all of its children are recursively unchecked out. */ public class UncheckOutAction extends CheckInAction { - /** - * @see org.eclipse.team.examples.pessimistic.ui.SourceManagementAction#manageResources(PessimisticFilesystemProvider, IResource[], IProgressMonitor) - */ + @Override protected void manageResources(PessimisticFilesystemProvider provider, IResource[] resources, IProgressMonitor monitor) { provider.uncheckout(resources, monitor); } |