diff options
| author | Carsten Hammer | 2019-08-25 16:07:36 +0000 |
|---|---|---|
| committer | Karsten Thoms | 2019-09-16 13:26:29 +0000 |
| commit | 362cc70b11209d820a098e050dd0ce357a7d4bf1 (patch) | |
| tree | 1311f2c0f93ea384f012e4fb014cc91744c58ecc /bundles/org.eclipse.team.ui | |
| parent | a90d4d49227d5f466e5f0b704f4b08c2ff6bf4a1 (diff) | |
| download | eclipse.platform.team-362cc70b11209d820a098e050dd0ce357a7d4bf1.tar.gz eclipse.platform.team-362cc70b11209d820a098e050dd0ce357a7d4bf1.tar.xz eclipse.platform.team-362cc70b11209d820a098e050dd0ce357a7d4bf1.zip | |
Manual array copy
Use Arrays.asList or System.arraycopy instead of copying array in a for
loop
Change-Id: I339f0b950d86f6d4edebe0cc10881f274c77ecdb
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
Diffstat (limited to 'bundles/org.eclipse.team.ui')
3 files changed, 3 insertions, 7 deletions
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/mapping/ResourceDragAdapterAssistant.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/mapping/ResourceDragAdapterAssistant.java index 181852bd0..32d0476f1 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/mapping/ResourceDragAdapterAssistant.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/mapping/ResourceDragAdapterAssistant.java @@ -82,8 +82,7 @@ public class ResourceDragAdapterAssistant extends CommonDragAdapterAssistant { if (actualLength < length) { String[] tempFileNames = fileNames; fileNames = new String[actualLength]; - for (int i = 0; i < actualLength; i++) - fileNames[i] = tempFileNames[i]; + System.arraycopy(tempFileNames, 0, fileNames, 0, actualLength); } anEvent.data = fileNames; diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/actions/CopyToClipboardAction.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/actions/CopyToClipboardAction.java index 5efd85260..f87077178 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/actions/CopyToClipboardAction.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/actions/CopyToClipboardAction.java @@ -163,8 +163,7 @@ class CopyToClipboardAction extends SelectionListenerAction { if (actualLength < length) { String[] tempFileNames = fileNames; fileNames = new String[actualLength]; - for (int i = 0; i < actualLength; i++) - fileNames[i] = tempFileNames[i]; + System.arraycopy(tempFileNames, 0, fileNames, 0, actualLength); } setClipboard(resources, fileNames, text); } diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/patch/ApplyPatchModelSynchronizeParticipant.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/patch/ApplyPatchModelSynchronizeParticipant.java index a922426ab..48454450a 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/patch/ApplyPatchModelSynchronizeParticipant.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/patch/ApplyPatchModelSynchronizeParticipant.java @@ -129,9 +129,7 @@ public class ApplyPatchModelSynchronizeParticipant extends return enabledProviders; } ModelProvider[] extended = new ModelProvider[enabledProviders.length + 1]; - for (int i = 0; i < enabledProviders.length; i++) { - extended[i] = enabledProviders[i]; - } + System.arraycopy(enabledProviders, 0, extended, 0, enabledProviders.length); PatchModelProvider provider = PatchModelProvider.getProvider(); if (provider == null) return enabledProviders; |