diff options
| author | Carsten Hammer | 2019-11-26 22:25:04 +0000 |
|---|---|---|
| committer | Lars Vogel | 2020-03-19 11:42:51 +0000 |
| commit | 993bc1eed15ef5502ff3e005e2f76f7334b80b14 (patch) | |
| tree | 70fde7cb368755f8756587d9a1f7a7c3abad93a7 /bundles/org.eclipse.team.cvs.core | |
| parent | ce4ee64f0c0ddf4733ab946f2171587cc35d4fcd (diff) | |
| download | eclipse.platform.team-993bc1eed15ef5502ff3e005e2f76f7334b80b14.tar.gz eclipse.platform.team-993bc1eed15ef5502ff3e005e2f76f7334b80b14.tar.xz eclipse.platform.team-993bc1eed15ef5502ff3e005e2f76f7334b80b14.zip | |
Use .isEmpty() instead of .size()==0 or .equals("")I20200402-2250I20200402-1800I20200402-0850I20200402-0410I20200401-1800I20200331-1800I20200330-1800I20200329-1800I20200328-1800I20200327-1800I20200326-1800I20200325-1800I20200324-1800I20200323-1800I20200322-1800I20200322-1150
Change-Id: If2db9cef6eddb2d79e3fd1c312b2c8248dd288d6
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
Diffstat (limited to 'bundles/org.eclipse.team.cvs.core')
3 files changed, 3 insertions, 3 deletions
diff --git a/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/CVSTag.java b/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/CVSTag.java index 7400f582e..95b9088e6 100644 --- a/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/CVSTag.java +++ b/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/CVSTag.java @@ -135,7 +135,7 @@ public class CVSTag implements ITag { public static IStatus validateTagName(String tagName) { if (tagName == null) return new CVSStatus(IStatus.ERROR, CVSMessages.CVSTag_nullName); - if (tagName.equals("")) //$NON-NLS-1$ + if (tagName.isEmpty()) return new CVSStatus(IStatus.ERROR, CVSMessages.CVSTag_emptyName); if (!Character. isLetter(tagName.charAt(0))) return new CVSStatus(IStatus.ERROR, CVSMessages.CVSTag_beginName); diff --git a/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/client/Request.java b/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/client/Request.java index 60f38737d..b74e099e4 100644 --- a/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/client/Request.java +++ b/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/client/Request.java @@ -153,7 +153,7 @@ public abstract class Request { // handle completion responses if (response.equals("ok")) { //$NON-NLS-1$ break; - } else if (response.equals("error") || (isCVSNT && response.equals(""))) { //$NON-NLS-1$ //$NON-NLS-2$ + } else if (response.equals("error") || (isCVSNT && response.isEmpty())) { //$NON-NLS-1$ argument = argument.trim(); boolean serious = false; if (argument.length() == 0) { diff --git a/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/filesystem/CVSURI.java b/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/filesystem/CVSURI.java index eb98eefc9..827098b25 100644 --- a/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/filesystem/CVSURI.java +++ b/bundles/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/filesystem/CVSURI.java @@ -181,7 +181,7 @@ public class CVSURI { int i = f.lastIndexOf(','); if (i != -1) { String s = f.substring(i + 1); - if (!s.equals("")) //$NON-NLS-1$ + if (!s.isEmpty()) return s; } } |