diff options
author | Alexander Kurtakov | 2019-04-17 05:33:20 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2019-04-17 06:37:51 +0000 |
commit | eaf7e086953a77a044e97cfb889e378f814a97eb (patch) | |
tree | 543b08fcc1b8e60281a1ba23d6b3ce51ad3ed3ab /bundles/org.eclipse.jsch.ui/src | |
parent | 759da51e4b7f0d0d0e5b5bf5cb58cc1f67bf1817 (diff) | |
download | eclipse.platform.team-eaf7e086953a77a044e97cfb889e378f814a97eb.tar.gz eclipse.platform.team-eaf7e086953a77a044e97cfb889e378f814a97eb.tar.xz eclipse.platform.team-eaf7e086953a77a044e97cfb889e378f814a97eb.zip |
Remove useless non-javadoc/@see comments.
Put @Override instead where needed.
Change-Id: Ib198807a342501579ed484a02e5231a4f06e5a59
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.jsch.ui/src')
6 files changed, 40 insertions, 66 deletions
diff --git a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/KeyboardInteractiveDialog.java b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/KeyboardInteractiveDialog.java index 49f0a8a86..028908ce3 100644 --- a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/KeyboardInteractiveDialog.java +++ b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/KeyboardInteractiveDialog.java @@ -297,9 +297,7 @@ public class KeyboardInteractiveDialog extends TrayDialog { super.cancelPressed(); } - /* (non-Javadoc) - * @see org.eclipse.jface.dialogs.Dialog#close() - */ + @Override public boolean close(){ if(keyLockImage!=null){ keyLockImage.dispose(); diff --git a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/UserValidationDialog.java b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/UserValidationDialog.java index c9e4efa9c..08578c2b3 100644 --- a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/UserValidationDialog.java +++ b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/UserValidationDialog.java @@ -14,8 +14,9 @@ package org.eclipse.jsch.internal.ui; -import org.eclipse.jface.dialogs.*; import org.eclipse.jface.dialogs.Dialog; +import org.eclipse.jface.dialogs.IDialogConstants; +import org.eclipse.jface.dialogs.TrayDialog; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.window.Window; import org.eclipse.swt.SWT; @@ -24,7 +25,12 @@ import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; -import org.eclipse.swt.widgets.*; +import org.eclipse.swt.widgets.Button; +import org.eclipse.swt.widgets.Composite; +import org.eclipse.swt.widgets.Control; +import org.eclipse.swt.widgets.Label; +import org.eclipse.swt.widgets.Shell; +import org.eclipse.swt.widgets.Text; import org.eclipse.ui.PlatformUI; /** @@ -65,6 +71,7 @@ public class UserValidationDialog extends TrayDialog { /** * @see Window#configureShell */ + @Override protected void configureShell(Shell newShell) { super.configureShell(newShell); newShell.setText(Messages.UserValidationDialog_0); @@ -74,6 +81,7 @@ public class UserValidationDialog extends TrayDialog { /** * @see Window#create */ + @Override public void create() { super.create(); // add some default values @@ -92,6 +100,7 @@ public class UserValidationDialog extends TrayDialog { /** * @see Dialog#createDialogArea */ + @Override protected Control createDialogArea(Composite parent) { Composite top = new Composite(parent, SWT.NONE); GridLayout layout = new GridLayout(); @@ -147,6 +156,7 @@ public class UserValidationDialog extends TrayDialog { data.horizontalSpan = 3; allowCachingButton.setLayoutData(data); allowCachingButton.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent e) { allowCaching = allowCachingButton.getSelection(); } @@ -224,6 +234,7 @@ public class UserValidationDialog extends TrayDialog { * and closes the dialog. Subclasses may override. * </p> */ + @Override protected void okPressed() { password = passwordField.getText(); username = usernameField.getText(); @@ -231,6 +242,7 @@ public class UserValidationDialog extends TrayDialog { super.okPressed(); } + @Override protected void cancelPressed(){ password = null; username = null; @@ -248,9 +260,7 @@ public class UserValidationDialog extends TrayDialog { isUsernameMutable = value; } - /* (non-Javadoc) - * @see org.eclipse.jface.dialogs.Dialog#close() - */ + @Override public boolean close() { if(keyLockImage != null) { keyLockImage.dispose(); diff --git a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/KeyboardInteractiveDialog.java b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/KeyboardInteractiveDialog.java index 962f14068..2a0a1f5aa 100644 --- a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/KeyboardInteractiveDialog.java +++ b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/KeyboardInteractiveDialog.java @@ -15,9 +15,13 @@ *******************************************************************************/ package org.eclipse.jsch.internal.ui.authenticator; -import org.eclipse.jface.dialogs.*; import org.eclipse.jface.dialogs.Dialog; +import org.eclipse.jface.dialogs.IDialogConstants; +import org.eclipse.jface.dialogs.TrayDialog; import org.eclipse.jface.window.Window; +import org.eclipse.jsch.internal.ui.IUIConstants; +import org.eclipse.jsch.internal.ui.JSchUIPlugin; +import org.eclipse.jsch.internal.ui.Messages; import org.eclipse.osgi.util.NLS; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; @@ -25,13 +29,14 @@ import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; -import org.eclipse.swt.widgets.*; +import org.eclipse.swt.widgets.Button; +import org.eclipse.swt.widgets.Composite; +import org.eclipse.swt.widgets.Control; +import org.eclipse.swt.widgets.Label; +import org.eclipse.swt.widgets.Shell; +import org.eclipse.swt.widgets.Text; import org.eclipse.ui.PlatformUI; -import org.eclipse.jsch.internal.ui.IUIConstants; -import org.eclipse.jsch.internal.ui.JSchUIPlugin; -import org.eclipse.jsch.internal.ui.Messages; - /** * A dialog for keyboard-interactive authentication for the ssh2 connection. * @since 1.1 @@ -97,7 +102,8 @@ public class KeyboardInteractiveDialog extends TrayDialog{ /** * @see Window#configureShell */ - protected void configureShell(Shell newShell){ + @Override +protected void configureShell(Shell newShell){ super.configureShell(newShell); if(isPasswordAuth){ newShell.setText(Messages.UserValidationDialog_required); @@ -113,7 +119,8 @@ public class KeyboardInteractiveDialog extends TrayDialog{ /** * @see Window#create */ - public void create(){ + @Override +public void create(){ super.create(); if(isPasswordAuth&&usernameField!=null){ @@ -129,7 +136,8 @@ public class KeyboardInteractiveDialog extends TrayDialog{ /** * @see Dialog#createDialogArea */ - protected Control createDialogArea(Composite parent){ + @Override +protected Control createDialogArea(Composite parent){ Composite top=new Composite(parent, SWT.NONE); GridLayout layout=new GridLayout(); layout.numColumns=2; @@ -201,7 +209,8 @@ public class KeyboardInteractiveDialog extends TrayDialog{ data.horizontalSpan=3; allowCachingButton.setLayoutData(data); allowCachingButton.addSelectionListener(new SelectionAdapter(){ - public void widgetSelected(SelectionEvent e){ + @Override + public void widgetSelected(SelectionEvent e){ allowCaching=allowCachingButton.getSelection(); } }); @@ -279,7 +288,8 @@ public class KeyboardInteractiveDialog extends TrayDialog{ * and closes the dialog. Subclasses may override. * </p> */ - protected void okPressed(){ + @Override +protected void okPressed(){ result=new String[prompt.length]; for(int i=0; i<texts.length; i++){ result[i]=texts[i].getText(); @@ -306,14 +316,13 @@ public class KeyboardInteractiveDialog extends TrayDialog{ * and closes the dialog. Subclasses may override. * </p> */ + @Override protected void cancelPressed(){ result=null; super.cancelPressed(); } - /* (non-Javadoc) - * @see org.eclipse.jface.dialogs.Dialog#close() - */ + @Override public boolean close(){ if(keyLockImage!=null){ keyLockImage.dispose(); diff --git a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/UserValidationDialog.java b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/UserValidationDialog.java index 3266bd767..e9aa300b6 100644 --- a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/UserValidationDialog.java +++ b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/UserValidationDialog.java @@ -267,11 +267,7 @@ public class UserValidationDialog extends TrayDialog{ isUsernameMutable=value; } - /* - * (non-Javadoc) - * - * @see org.eclipse.jface.dialogs.Dialog#close() - */ + @Override public boolean close(){ if(keyLockImage!=null){ keyLockImage.dispose(); diff --git a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/WorkbenchUserAuthenticator.java b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/WorkbenchUserAuthenticator.java index 789ef71e9..111bef09b 100644 --- a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/WorkbenchUserAuthenticator.java +++ b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/authenticator/WorkbenchUserAuthenticator.java @@ -172,9 +172,6 @@ public String[] promptForKeyboradInteractive( } - /* (non-Javadoc) - * @see org.eclipse.team.internal.ccvs.core.IUserAuthenticator#prompt(org.eclipse.team.internal.ccvs.core.ICVSRepositoryLocation, int, java.lang.String, java.lang.String, int[], int) - */ @Override public int prompt(IJSchLocation location, final int promptType, final String title, final String message, final int[] promptResponses, diff --git a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/ui/UserInfoPrompter.java b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/ui/UserInfoPrompter.java index 4504fb848..85791a697 100644 --- a/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/ui/UserInfoPrompter.java +++ b/bundles/org.eclipse.jsch.ui/src/org/eclipse/jsch/ui/UserInfoPrompter.java @@ -67,21 +67,11 @@ public class UserInfoPrompter implements UserInfo, UIKeyboardInteractive{ return session; } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UserInfo#getPassphrase() - */ @Override public String getPassphrase(){ return passphrase; } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UserInfo#getPassword() - */ @Override public String getPassword(){ return password; @@ -111,11 +101,6 @@ public String getPassword(){ this.password=password; } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UserInfo#promptPassphrase(java.lang.String) - */ @Override public boolean promptPassphrase(String message){ String _passphrase=promptSecret(message); @@ -125,11 +110,6 @@ public boolean promptPassphrase(String message){ return _passphrase!=null; } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UserInfo#promptPassword(java.lang.String) - */ @Override public boolean promptPassword(String message){ String _password=promptSecret(message); @@ -166,12 +146,6 @@ public boolean promptPassword(String message){ return dialog.getPassword(); } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UIKeyboardInteractive#promptKeyboardInteractive(java.lang.String, - * java.lang.String, java.lang.String, java.lang.String[], boolean[]) - */ @Override public String[] promptKeyboardInteractive(String destination, String name, String instruction, String[] prompt, boolean[] echo){ @@ -231,11 +205,6 @@ public String[] promptKeyboardInteractive(String destination, String name, return _result; } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UserInfo#promptYesNo(java.lang.String) - */ @Override public boolean promptYesNo(String question){ int prompt=prompt(MessageDialog.QUESTION, Messages.UserInfoPrompter_0, @@ -247,11 +216,6 @@ public boolean promptYesNo(String question){ return prompt==0; } - /* - * (non-Javadoc) - * - * @see com.jcraft.jsch.UserInfo#showMessage(java.lang.String) - */ @Override public void showMessage(String message){ prompt(MessageDialog.INFORMATION, Messages.UserInfoPrompter_1, message, |