diff options
| author | Szymon Brandys | 2009-03-02 11:23:23 +0000 |
|---|---|---|
| committer | Szymon Brandys | 2009-03-02 11:23:23 +0000 |
| commit | 5dbfd7c3df3158c82b6b7256888e494137dfe8b5 (patch) | |
| tree | fb87a279100900e1191a59e0a7b9b7fd01ceaa09 /bundles/org.eclipse.core.net/src | |
| parent | 7ffc049ff5c00db88a5cfc8d7cf4b8c11a8c9468 (diff) | |
| download | eclipse.platform.team-5dbfd7c3df3158c82b6b7256888e494137dfe8b5.tar.gz eclipse.platform.team-5dbfd7c3df3158c82b6b7256888e494137dfe8b5.tar.xz eclipse.platform.team-5dbfd7c3df3158c82b6b7256888e494137dfe8b5.zip | |
Bug 265957 - [Net] ProxyType.setProxyData(...) contains parameter that is never used
Diffstat (limited to 'bundles/org.eclipse.core.net/src')
| -rw-r--r-- | bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyManager.java | 5 | ||||
| -rw-r--r-- | bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyType.java | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyManager.java b/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyManager.java index 06a75d4a3..de2e210ff 100644 --- a/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyManager.java +++ b/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyManager.java @@ -204,7 +204,7 @@ public class ProxyManager implements IProxyService, IPreferenceChangeListener { for (int i = 0; i < proxyDatas.length; i++) { IProxyData proxyData = proxyDatas[i]; ProxyType type = getType(proxyData); - if (type != null && type.setProxyData(proxyData, internalIsProxiesEnabled())) { + if (type != null && type.setProxyData(proxyData)) { result.add(proxyData); } } @@ -447,7 +447,6 @@ public class ProxyManager implements IProxyService, IPreferenceChangeListener { } // migrate proxy data - boolean proxiesEnabled = netConfigurationPrefs.getBoolean(PREF_ENABLED, true); for (int i = 0; i < proxies.length; i++) { ProxyType type = proxies[i]; IProxyData data = type.getProxyData(ProxyType.DO_NOT_VERIFY); @@ -455,7 +454,7 @@ public class ProxyManager implements IProxyService, IPreferenceChangeListener { ProxyType instanceType = new ProxyType(type.getName(),netInstancePrefs); IProxyData instanceData = instanceType.getProxyData(ProxyType.DO_NOT_VERIFY); if (instanceData.getHost() != null) - type.setProxyData(instanceData, proxiesEnabled); + type.setProxyData(instanceData); } } diff --git a/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyType.java b/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyType.java index b544efba2..f1dcd6d9d 100644 --- a/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyType.java +++ b/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyType.java @@ -156,7 +156,7 @@ public class ProxyType implements INodeChangeListener, IPreferenceChangeListener return proxyData; } - public boolean setProxyData(IProxyData proxyData, boolean proxiesEnabled) { + public boolean setProxyData(IProxyData proxyData) { Assert.isTrue(proxyData.getType().equals(getName())); IProxyData oldData = getProxyData(VERIFY_EQUAL); if (oldData.equals(proxyData)) |