Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2017-07-13 17:47:46 +0000
committerLars Vogel2017-07-13 17:48:31 +0000
commit5e68a2495fd52df9cf9a6bf6650ebd512fd11162 (patch)
tree8e777c1e57b426c19e001c2ad33f6d9f18db6716 /bundles/org.eclipse.compare
parent14966c3475406cefc3cde00382997b50aae6dc60 (diff)
downloadeclipse.platform.team-5e68a2495fd52df9cf9a6bf6650ebd512fd11162.tar.gz
eclipse.platform.team-5e68a2495fd52df9cf9a6bf6650ebd512fd11162.tar.xz
eclipse.platform.team-5e68a2495fd52df9cf9a6bf6650ebd512fd11162.zip
Bug 519655 - Use StringBuilder instead of StringBuffer in
org.eclipse.compare Change-Id: I0471c2364057896dd7f1338f9814968e2a9ba0a8 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Diffstat (limited to 'bundles/org.eclipse.compare')
-rw-r--r--bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ComparePreferencePage.java2
-rw-r--r--bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/Utilities.java2
-rw-r--r--bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/LineReader.java4
-rw-r--r--bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/Patcher.java2
-rw-r--r--bundles/org.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureCreator.java4
5 files changed, 7 insertions, 7 deletions
diff --git a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ComparePreferencePage.java b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ComparePreferencePage.java
index 3c0d74e2b..20c1f46c8 100644
--- a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ComparePreferencePage.java
+++ b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ComparePreferencePage.java
@@ -501,7 +501,7 @@ public class ComparePreferencePage extends PreferencePage implements IWorkbenchP
String preview= Utilities.getString(key);
String separator= System.getProperty("line.separator"); //$NON-NLS-1$
- StringBuffer buffer= new StringBuffer();
+ StringBuilder buffer= new StringBuilder();
for (int i= 0; i < preview.length(); i++) {
char c= preview.charAt(i);
if (c == '\n')
diff --git a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/Utilities.java b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/Utilities.java
index 6c9e7d665..89d3b4dc1 100644
--- a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/Utilities.java
+++ b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/Utilities.java
@@ -641,7 +641,7 @@ public class Utilities {
return null;
BufferedReader reader= null;
try {
- StringBuffer buffer= new StringBuffer();
+ StringBuilder buffer= new StringBuilder();
char[] part= new char[2048];
int read= 0;
reader= new BufferedReader(new InputStreamReader(is, encoding));
diff --git a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/LineReader.java b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/LineReader.java
index 9a14edafd..1e1348894 100644
--- a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/LineReader.java
+++ b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/LineReader.java
@@ -91,7 +91,7 @@ public class LineReader {
* Concatenates all strings found in the given List.
*/
public static String createString(boolean preserveLineDelimeters, List<String> lines) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
Iterator<String> iter = lines.iterator();
if (preserveLineDelimeters) {
while (iter.hasNext())
@@ -136,7 +136,7 @@ public class LineReader {
private boolean fSawEOF = false;
private BufferedReader fReader;
private boolean fIgnoreSingleCR = false;
- private StringBuffer fBuffer = new StringBuffer();
+ private StringBuilder fBuffer = new StringBuilder();
public LineReader(BufferedReader reader) {
fReader = reader;
diff --git a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/Patcher.java b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/Patcher.java
index 1477cc21f..81b7d617c 100644
--- a/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/Patcher.java
+++ b/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/patch/Patcher.java
@@ -425,7 +425,7 @@ public class Patcher implements IHunkFilter {
return null;
String lineSeparator= System.getProperty("line.separator"); //$NON-NLS-1$
- StringBuffer sb= new StringBuffer();
+ StringBuilder sb= new StringBuilder();
Iterator iter= failedHunks.iterator();
while (iter.hasNext()) {
Hunk hunk= (Hunk) iter.next();
diff --git a/bundles/org.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureCreator.java b/bundles/org.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureCreator.java
index 71be84ba7..32eb38ea8 100644
--- a/bundles/org.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureCreator.java
+++ b/bundles/org.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureCreator.java
@@ -468,8 +468,8 @@ public abstract class StructureCreator implements IStructureCreator2 {
List<String> lines2 = LineReader.readLines(new BufferedReader(new StringReader(
getContents(node2, false))));
- StringBuffer buffer1 = new StringBuffer();
- StringBuffer buffer2 = new StringBuffer();
+ StringBuilder buffer1 = new StringBuilder();
+ StringBuilder buffer2 = new StringBuilder();
int maxLines = Math.max(lines1.size(), lines2.size());
for (int i = 0; i < maxLines; i++) {

Back to the top