Shouldn't create status handlers outside of schedule() method. Made constructor protected.

2 files changed, 5 insertions, 32 deletions

diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/jobs/JobStatusHandler.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/jobs/JobStatusHandler.java
index 10be27bc0..47f54bd68 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/jobs/JobStatusHandler.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/jobs/JobStatusHandler.java
@@ -10,19 +10,10 @@
  *******************************************************************************/
 package org.eclipse.team.internal.ui.jobs;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
 
-import org.eclipse.core.runtime.ISafeRunnable;
-import org.eclipse.core.runtime.Platform;
-import org.eclipse.core.runtime.QualifiedName;
-import org.eclipse.core.runtime.jobs.IJobChangeEvent;
-import org.eclipse.core.runtime.jobs.Job;
-import org.eclipse.core.runtime.jobs.JobChangeAdapter;
+import org.eclipse.core.runtime.*;
+import org.eclipse.core.runtime.jobs.*;
 
 /**
  * This class is reponsible for notifying listeners when jobs registered
@@ -145,7 +136,7 @@ public class JobStatusHandler extends JobChangeAdapter {
 		}
 	}
 
-	public JobStatusHandler(QualifiedName jobType) {
+	protected JobStatusHandler(QualifiedName jobType) {
 		super();
 		this.jobType = jobType;
 	}
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/actions/SubscriberAction.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/actions/SubscriberAction.java
index 25dd8a495..9a653f56a 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/actions/SubscriberAction.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/actions/SubscriberAction.java
@@ -10,11 +10,7 @@
  *******************************************************************************/
 package org.eclipse.team.ui.synchronize.actions;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
 
 import org.eclipse.core.runtime.QualifiedName;
 import org.eclipse.jface.viewers.IStructuredSelection;
@@ -22,7 +18,6 @@ import org.eclipse.team.core.TeamException;
 import org.eclipse.team.core.subscribers.SyncInfo;
 import org.eclipse.team.internal.ui.TeamUIPlugin;
 import org.eclipse.team.internal.ui.actions.TeamAction;
-import org.eclipse.team.internal.ui.jobs.JobStatusHandler;
 import org.eclipse.team.ui.synchronize.ITeamSubscriberParticipantNode;
 import org.eclipse.ui.IViewActionDelegate;
 
@@ -40,19 +35,6 @@ public abstract class SubscriberAction extends TeamAction implements IViewAction
 	
 	public static final QualifiedName SUBSCRIBER_JOB_TYPE = new QualifiedName(TeamUIPlugin.ID, "subcriber_job"); //$NON-NLS-1$
 	
-	private static final JobStatusHandler feedbackManager = new JobStatusHandler(SUBSCRIBER_JOB_TYPE);
-	
-	/**
-	 * Return the <code>JobStatusHandler</code> that is used to show busy indication
-	 * in the Synchronize view. Subscribers should use the handler to schedule jobs
-	 * that affect the Synchronize view so that the view shows proper busy indication
-	 * to the user.
-	 * @return the JobStatusHandler linked to the Sychcronize view
-	 */
-	public static JobStatusHandler getJobStatusHandler() {
-		return feedbackManager;
-	}
-	
 	/**
 	 * This method returns all instances of SynchronizeViewNode that are in the current
 	 * selection. For a table view, this is any resource that is directly selected.