diff options
author | Lars Vogel | 2021-04-01 10:08:17 +0000 |
---|---|---|
committer | Lars Vogel | 2021-04-01 10:08:17 +0000 |
commit | 232c8080cadde423b4fd098056be297fd4148289 (patch) | |
tree | 0ae4e206eae842e77f21206204e3c7f222d6c7dd | |
parent | 5b945471cd20dc1f537651f9584c14e258dce07a (diff) | |
download | eclipse.platform.team-232c8080cadde423b4fd098056be297fd4148289.tar.gz eclipse.platform.team-232c8080cadde423b4fd098056be297fd4148289.tar.xz eclipse.platform.team-232c8080cadde423b4fd098056be297fd4148289.zip |
[dogfooding][cleanup] Use static inner class clean up for team codeI20210407-0600I20210407-0040I20210406-1800I20210406-0600I20210405-1800I20210405-0840I20210405-0630I20210405-0600I20210404-1800I20210404-0600I20210403-1800I20210403-0600I20210402-1800I20210402-0510
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I85c3e8d93c8b567296c3a7a4a0133d6ce635dda3
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
7 files changed, 9 insertions, 9 deletions
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java index 2cdc74a6c..c63db3767 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java @@ -115,7 +115,7 @@ public class CompareAction extends TeamAction { // see // org.eclipse.compare.internal.ResourceCompareInput.SelectAncestorDialog - private class SelectAncestorDialog extends MessageDialog { + private static class SelectAncestorDialog extends MessageDialog { private IResource[] theResources; IResource ancestorResource; IResource leftResource; diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java index 886b0e47c..09234355f 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java @@ -216,7 +216,7 @@ public class GenericHistoryView extends PageBookView implements IHistoryView, IP } } - abstract class MenuCreator implements IMenuCreator { + abstract static class MenuCreator implements IMenuCreator { private MenuManager menuManager; @Override diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java index 619e6730d..58e1c4953 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java @@ -131,7 +131,7 @@ public class LocalHistoryPage extends HistoryPage implements IHistoryCompareAdap private IFileRevision currentSelection; - private final class LocalHistoryContentProvider implements ITreeContentProvider { + private static final class LocalHistoryContentProvider implements ITreeContentProvider { @Override public Object[] getElements(Object inputElement) { if (inputElement instanceof IFileHistory) { diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java index ac10c047b..c93707016 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java @@ -40,7 +40,7 @@ public class RefreshModelParticipantJob extends RefreshParticipantJob { private IProgressMonitor group; private int groupTicks; - public class ChangeDescription implements IChangeDescription, IDiffChangeListener { + public static class ChangeDescription implements IChangeDescription, IDiffChangeListener { Map<IPath, IDiff> changes = new HashMap<>(); @Override diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java index b2e9c8e63..d5d442462 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java @@ -176,7 +176,7 @@ public abstract class RefreshParticipantJob extends Job { /** * Notification for safely notifying listeners of refresh lifecycle. */ - private abstract class Notification implements ISafeRunnable { + private abstract static class Notification implements ISafeRunnable { private IRefreshSubscriberListener listener; @Override public void handleException(Throwable exception) { diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java index bc8dbafcb..bcc9d7c62 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java @@ -78,7 +78,7 @@ public class SynchronizeModelUpdateHandler extends BackgroundEventHandler implem /** * Custom event for posting marker changes */ - class MarkerChangeEvent extends Event { + static class MarkerChangeEvent extends Event { private final ISynchronizeModelElement[] elements; public MarkerChangeEvent(ISynchronizeModelElement[] elements) { super(MARKERS_CHANGED); @@ -92,7 +92,7 @@ public class SynchronizeModelUpdateHandler extends BackgroundEventHandler implem /** * Custom event for posting busy state changes */ - class BusyStateChangeEvent extends Event { + static class BusyStateChangeEvent extends Event { private final ISynchronizeModelElement element; private final boolean isBusy; @@ -112,7 +112,7 @@ public class SynchronizeModelUpdateHandler extends BackgroundEventHandler implem /** * Custom event for posting sync info set changes */ - class SyncInfoSetChangeEvent extends Event { + static class SyncInfoSetChangeEvent extends Event { private final ISyncInfoSetChangeEvent event; public SyncInfoSetChangeEvent(ISyncInfoSetChangeEvent event) { super(SYNC_INFO_SET_CHANGED); diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java index 0a077550b..d79165e3e 100644 --- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java +++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java @@ -82,7 +82,7 @@ public abstract class SynchronizePageActionGroup extends ActionGroup { * page. Selection changed events are sent out when the model roots change * or their visible children change */ - private class VisibleRootsSelectionProvider extends SynchronizePageActionGroup implements ISelectionProvider { + private static class VisibleRootsSelectionProvider extends SynchronizePageActionGroup implements ISelectionProvider { private ListenerList<ISelectionChangedListener> selectionChangedListeners = new ListenerList<>(ListenerList.IDENTITY); private ISelection selection; |