Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2020-06-05 16:23:18 +0000
committerLars Vogel2020-06-10 11:05:43 +0000
commit35419416c5244232695bf7fda6fff539b2f95b7d (patch)
tree5ecf5bcd65a913eedccf3635acb3d387b1dcbd24
parent6e39faadabd4444676144a733c5eb4c64eed0edb (diff)
downloadeclipse.platform.team-35419416c5244232695bf7fda6fff539b2f95b7d.tar.gz
eclipse.platform.team-35419416c5244232695bf7fda6fff539b2f95b7d.tar.xz
eclipse.platform.team-35419416c5244232695bf7fda6fff539b2f95b7d.zip
Bug 564063 - Using ArrayContentProvider.getInstance() instead of new instance
ArrayContentProvider does not hold any data, hence it can be shared across instances. Change-Id: I70360f83b7f57b34ae867fdc98a0c370e77cb81f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
-rw-r--r--bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/PatchInaccessibleProjectsPage.java2
-rw-r--r--bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/WorkingSetsDialog.java2
2 files changed, 2 insertions, 2 deletions
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/PatchInaccessibleProjectsPage.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/PatchInaccessibleProjectsPage.java
index baceab88c..0572e8c52 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/PatchInaccessibleProjectsPage.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/PatchInaccessibleProjectsPage.java
@@ -71,7 +71,7 @@ public class PatchInaccessibleProjectsPage extends WizardPage {
checkList = CheckboxTableViewer.newCheckList(composite, SWT.H_SCROLL
| SWT.V_SCROLL | SWT.BORDER);
- checkList.setContentProvider(new ArrayContentProvider());
+ checkList.setContentProvider(ArrayContentProvider.getInstance());
checkList.setLabelProvider(new WorkbenchLabelProvider() {
@Override
public Color getForeground(Object element) {
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/WorkingSetsDialog.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/WorkingSetsDialog.java
index d783831eb..11584643d 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/WorkingSetsDialog.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/wizards/WorkingSetsDialog.java
@@ -88,7 +88,7 @@ public class WorkingSetsDialog extends TitleAreaDialog {
gd.heightHint = 250;
wsTableViewer.getTable().setLayoutData(gd);
- wsTableViewer.setContentProvider(new ArrayContentProvider());
+ wsTableViewer.setContentProvider(ArrayContentProvider.getInstance());
wsTableViewer.setLabelProvider(new WorkingSetLabelProvider());
wsTableViewer.setInput(PlatformUI.getWorkbench().getWorkingSetManager().getWorkingSets());

Back to the top