Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/tests
AgeCommit message (Collapse)AuthorFilesLines
2018-04-24Bug 480639: Provide monitor-specific DPI scaling / zoom levelLakshmi Shanmugam1-0/+11
Added JUnit test for Monitor.getZoom() API Change-Id: I67430320238f6ba6ea0a16001a260537e4385f34
2018-04-23Bug 533677 - [win32] calling Browser#refresh does not callLars Vogel1-0/+21
ProgressListener#completed Adds test to ensure a completed listener is called Change-Id: Ice4e6cbfa7ce2cc57a58739430581df56bd0ccb2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-20Bug 533799 - shrinking trees/tables can cause errors on standard errorSimeon Andreev1-0/+62
Resizing a GTK tree view so that the column header and the horizontal scrollbar overlap causes pixman bug error messages on standard error. Using standard GTK3 API, it doesn't seem possible to resize the table the tree view in such a way. SWT on the other hand allows this. This change ensures that the SWT fixed which contains the tree or table is resized as requested by resize operation, while the tree or table retains some minimum height to avoid the error. In result, parts of the horizontal scrollbar are no longer visible, when the tree or table is shrinked below about 40px, the column headers and the horizontal scrollbar are visible. Change-Id: I3b39596a0f4eba3e1bbb259ab30d9d8744bb62c1 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-04-19Bug 525946 [Webkit2] Port download functionality (rewrite some logic)Leo Ufimtsev1-15/+16
G_TYPE_CHECK_INSTANCE_TYPE is not a reliable method to check if type is webview or webcontext at run time. On my & Roland's system it works, but on Andrey's system it miss-fires. This is a macro and by the looks is not reliable method because we use it with dynamically loaded libraries and via JNI. Solution: Rewrite the callback logic to determine types of callback based on user_data instead of relying on type checking macro. Also, created task to remove usage of the macro to prevent simmila issues: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533833 Tests: - Environment: Webkit2 2.18, Gtk3.22, Fedora 27, wayland on host, x11 eclipse backend. - JUnit AllBrowserTests - ChildEclipse. - Bug Snippet attached to this patch. - Also tested with webkit1. - Andrey reports that this patch fixes his crash issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533545#c34 Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5259462 Change-Id: I485a54804285dbf114961422799ea34796413404 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-17Bug 533660 - Use method reference forLars Vogel1-22/+21
Test_org_eclipse_swt_browser_Browser#waitForPassCondition calls Change-Id: Ib4b4f6b8d94781378dfe7a0172d17977c369321f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-16Bug 529431: [GTK3.10+] Snippet294 fails to draw RegionEric Williams1-2/+5
Fix input handling for GTK3.10+ setRegion behaviour. This does a manual check to see if the incoming event coordinates are within the set region: if they are, ignore them. This prevents events like SWT.Selection, SWT.Mouse[Up/Down], etc. from triggering when they are spawned from within the set region. There are two main limitations though: 1) we cannot stop native GTK events as we are doing the region drawing on the SWT level. This means things like mouse enter/leave, button pre-light, etc. will still be visible. We block the selection/click events at the SWT level, but unfortunately there is no reliable way to block these on the GTK level. 2) we also can't block all selection events, as some widgets are selectable using the keyboard (which has no coordinates). This means we could potentially block out selection events that *should* be sent. Tested on GTK3.22, no AllNonBrowser JUnit test failures. Change-Id: Ifd8377feb7d71a366edcdf6083d2bc94ab779886 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-14Suppress deprecation warning.Alexander Kurtakov1-1/+2
In test of deprecated method. Change-Id: I07be2e39a69b3e926cf496f7955104d30880bc38 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-11Bug 529431: [GTK3.10+] Snippet294 fails to draw RegionEric Williams1-0/+103
This patch fixes drawing issues when setRegion is called on widgets that are children of Scrollable (like List, for example). The fix is to check if there are incoming draw events for paintHandle() in Control. If this is the case, and setRegion has been defined, we call gtk_draw(). This ensures that the clipping is applied to the right handle and that the region is drawn. Tested on GTK3.22. Compared behaviour with GTK3.8: most widgets work with the exception of Table/Tree and a few others. No AllNonBrowser JUnit tests fail. Functionality for Shell.setRegion() remains functional. Change-Id: Ife9a1688e58eef3c98cc6f74ff7d1bac1eac9986 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-10Bug 533145: [GTK] Contribute remaining manual snippets to GTK only repoEric Williams183-0/+13371
Add remaining reproducer snippets to the offical platform specific tests repo. Change-Id: Id8e63ce2650e3ad842d7fe1e7bbeb202a47e23e8 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-06Bug 531667 - GTK drawing and clipping issues after Control.print(GC) fixSimeon Andreev5-0/+571
With the fix for bug 531667, at least the following regressions were introduced: 1. and 2. CTabFolder with SWT.RIGHT_TO_LEFT flag is not drawn and code using GC.setTransform()/GC.getTransform() was broken in some cases. E.g. caused drawing artifacts in tools based on GEF, such as figures drawn with wrong coordinates and starting with 0,0 in a global window space. We observe these regressions, since the Cairo transformation matrix is overwritten on some occasions, causing Cairo to lose the current (x,y) translation relative to the widget parents. 3. Further drawing artifacts are seen when scrolling in a GEF editor, or when resizing neighboring part stacks so that they land over specific GEF editor elements (e.g. LED). Namely, some elements are painted over neighboring composites (e.g. ports of a LED). This is caused by bad clipping set by client code and GC.setClipping(0) removing current Cairo clipping. Since GC is able to to draw at any point in the shell after the fix for bug 531667 (as the Cairo handle is shared by all composites), this results in client code being able to draw over other unrelated composites. 4. Bug 478618 was re-introduced on GTK > 3.20, i.e. ControlDecoration of e.g. text fields would paint its error decoration at a wrong location. In result, two decorations per ControlDecoration are painted; one of which is misplaced while the other will not be repainted on correcting input. On GTK 3.14 the ControlDecorations aren't drawn at all independently from bug 531667 or this patch, see bug 533241. We resolve the first two issues by remembering the original Cairo transformation matrix in GC and applying this matrix on every transform set by the client code. The third regression is fixed by remembering the original Cairo clipping and intersecting the client clipping with it. The last regression in ControlDecoration is fixed by applying the patch for bug 478618 also for GTK 3.20 and above. For GTK 3.14 see bug 533241, because this is not a regression from the Control.print(GC) fix. Manual bug snippets are provided for all of the regressions. Change-Id: I1bcc3c72d14fc37b05c51ff6f0845667a95d160c Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-04-05Bug 532946 – Fix SwtTestUtil#isRunningOnEclipseOrgHudsonGTKLeo Ufimtsev1-2/+2
Changing to isRunningOnContinousIntegration Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532946 Change-Id: I13a8f9e69e83a6af274bbb0e14d1d9ac7c0b97df Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-04Bug 530678 [webkit2] UI hangs after navigating through Javadoc hover,Leo Ufimtsev1-0/+64
when clicking an icon or link to an image. TL;DR: Fix for bug. Details: Clicking on a javadoc like below, (after 2 or 3 times), breaks javadoc. /** <a href="https://bugs.eclipse.org/bugs/attachment.cgi?id=272647">Screenshot</a> */ It un-breaks if you manually kill Webkit* processes. I.e, Webkit process deadlocks if Browser is disposed in the middle of a callback. The fix is to delay disposal until callback is completed. This is achived by leaving a dangling reference until next display loop is executed. This also fixes the bug: 494158 - [Webkit1][Webkit2] JVM crash when javadoc hover has <embed> tags. In addition, I'm adding a jUnit to verify that the fix hasn't introduced memory leaks. (E.g if object is not unreferenced, then one can observe a memory leak. So by extension this fix does not introduce a memory leak since the test passes). (Note, it's not added to be ran automatically becaues it takes 5+ minutes to run). Tests & verification: (gtk3.22, Webkit2.18). - jUnit: AllTests - Child Eclipse opens external links (multiple times) in javadoc correctly. - Various Browser Snippets. - Test_Memory_leak.test_Browser(). https://bugs.eclipse.org/bugs/show_bug.cgi?id=530678 Change-Id: I2a0f0f7e2b44bce67a1212bfa4205561942e59de Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-04532946 – Fix SwtTestUtil#isRunningOnEclipseOrgHudsonGTKLeo Ufimtsev2-13/+11
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532946 Updating variable name and remvoing hudson reference. Also, since tests servers now run Webkit2, removing condition from tests that were skipped by test server because test server used to run Webkit1. Change-Id: I081c279ca7ac96735acb31e063f74c3851cfdf34 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-03Bug 529431: [GTK3.10+] Snippet294 fails to draw RegionEric Williams1-0/+67
Allow GtkWindow (usually Shells) to be shaped using gdk_window_shape_combine_region() instead of cairo_clip. GtkWindow is unaffected by the changes in GTK3.10 so this is fine. A snippet has been added to test this functionality, and to test for the case mentioned in comment 8 of bug 529431. Change-Id: I40c80599e015553576fc8979181577c1170146d2 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-03-28Bug 531928: [GTK3] Table editing is brokenEric Williams1-0/+98
The fix for bug 511133 introduced some logic which raises/lowers the GdkWindows of widgets who are children of Table or Tree. Unforunately, this breaks certain cases such as Tables/Trees that have more than one child widget. Additionally, changing the drawing handle from fixedHandle to handle meant that some child widgets were not getting their draw events properly. According to GTK, child widgets with non-native windows should receive draw events from their parent containers using gtk_container_propagate_draw(). This patch follows this advice and connects a Table/Tree's fixedHandle to the draw signal. The incoming draw events to that fixedHandle are then propagated to the respective child widgets using gtk_container_propagate_draw(). A reproducer snippet is attached. This patch also fixes a regression from bug 511133 which caused the file permissions table (right click file -> properties -> resources) to be empty/contain only one checkbox. Change-Id: I645a04df6773372aa27a360d3df9a3521437828f Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-03-27Bug 527738: Fix test_setUrl_remote_with_post test.Roland Grunberg1-3/+13
Use ProgressListener to determine when POST request has completed. Change-Id: I6c2d0cfaffb22a69f93a681451b54fc1b1ee4f2e Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-03-23Bug 532825 - Remove hpux/solaris clutter in the codebaseAlexander Kurtakov1-3/+1
Change-Id: I735be5853d393097c7d11c9abb43e9e5cbf93c8d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-03-23Bug 488431 - Provide SWT/GTK3 port on WindowsRolf Theunissen2-8/+10
Test for windows style newlines (os=windows) instead of windows platform (platform=win32) Change-Id: I97d96c4b24c6b7ff9152c715ada973acfeb01075 Signed-off-by: Rolf Theunissen <rolf.theunissen@altran.com>
2018-03-19Bug 532139 – Add Copyright to a java few files.Leo Ufimtsev10-288/+114
Adding missing copyright notices and removing old Command line interface that is no longer being used as such testing can be accomplished via launch groups. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532139 Change-Id: I9cc3e9a48e70adbd49c993e39100be1301ea5551 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-03-16Bug 531048 [GTK3] Problems drawing ownerdraw tables (Tests)Leo Ufimtsev4-219/+741
Adding/updating some tests I used for the fix. Useful for quickly running through a large set of snippets and visually insect that nothing broke. I often found the Waterbed effect, a small change in one place would break thing far far away... Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5310483 Change-Id: I284e01fb077361cc1a21ffff3c77528c9e25b491 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-03-16Bug 532548 - Update surefire to 2.21.0Alexander Kurtakov1-1/+1
Change-Id: I27ee0acc233dd44791f94a00537786882272ca60 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-03-16[Tests] Use dedicated SWT native lib cache folderI20180316-0455Mickael Istria1-0/+3
SWT tests often also involve testing a new snapshot of the native libraries. As SWT usually puts the libraries in a cache under user.home, it makes SWT tests more likely to used the cached version then the one that inside platform-specific fragments. SWT Tests are now configured to use a different user.home to not interact with the default cache directory. Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-15Bug 530019 - StyledText.setStyleRange resets less cacheangelozerr2-2/+261
Change-Id: Iaa4e0177de4e9d962fcdd4ea1aeeae6d6e8f2e54 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-14Bug 532173 - [StyledText] Wrong caret bounds with variable heightMickael Istria1-0/+39
Fix bug in getBoundsAtOffset to make it more reliable. Place caret to better location when it doesn't fit the whole line. May as well fix bug 118612 Change-Id: I381dcc9039dae62dfddbd069487f7ecec85057c4 Signed-off-by: Mickael Istria <mistria@redhat.com> Also-By: Angelo Zerr <angelozerr@gmail.com>
2018-03-14Revert "Bug 532173 - [StyledText] Wrong caret bounds with variable height"Mickael Istria1-39/+0
This reverts commit 2ef119e594da0ed9e93c88f3b32b03e82863870c. Change-Id: Ida4a0312d3a46498cff147982463ee933a508e80
2018-03-14Bug 532173 - [StyledText] Wrong caret bounds with variable heightMickael Istria1-0/+39
Fix bug in getBoundsAtOffset to make it more reliable. Place caret to better location when it doesn't fit the whole line. May as well fix bug 118612 Change-Id: I942787c801090ff504c8ed37183a97b312f78e18 Signed-off-by: Mickael Istria <mistria@redhat.com> Also-By: Angelo Zerr <angelozerr@gmail.com>
2018-03-07Revert "Bug 528498 - Combo menu is narrower than combo"Alexander Kurtakov1-70/+0
This reverts commit 2feeddb0172f839c43ea8087619a9ea912eb88fa. Change-Id: I32d4f75cda1fbd9c7e88d212124f06830291fcaa
2018-03-05Bug 508600: The average character width of a font is not integerLakshmi Shanmugam1-0/+6
Added Junit test for the new API Change-Id: I1f78e5fe55746a57a38ed7a579c39547666b6d05
2018-03-05Bug 531667 - [GTK3] Cannot draw Canvas with Control.print(GC)Simeon Andreev2-0/+301
Calling Canvas.pring(GC) results in no painted canvas on the GC. This is caused by a regression from the fix for Bug 421127. Control.print propagates the GC.handle as the last argument to Control.gtk_draw. With changes for Bug 421127 in Control.gtk_draw, the handle is no longer propagated to the actual onPaint event. The canvas (and canvas derived widgets) therefore no longer paint themselves on the GC. The problem which was fixed with the change in Control.gtk_draw, for Bug 421127, was that CTabFolder tabs were not painted. This is the case, since GC.getClipping returned broken values with GTK 3.10 and above. CTabFolder checks for intersection with the clipping region and doesn't paint itself. The clipping region was not computed properly, due to transformations done with the device space transformation matrix provided by Cairo. From GTK 3.10 onward, this matrix contains absolute coordinates of the widget, with respect to the shell. This causes the method to malfunction. With the fix for Bug 421127, the Cairo matrix is no longer propagated. As a result GC.getClipping only works with the identity matrix, resulting in correct clipping. This change reverts the change for Bug 421127 in Control.gtk_draw, for GTK versions 3.14 and above. The GC.getClipping method is adapted to first transform the local GC bounds to device space, before computing the intersection with the clipping region. This is done for GTK 3.14 and above. We validated the change with GTK 3.14 and GTK 3.22. A bug snippet is provided, show-casing clipping region and Cairo device space transformation matrix. Change-Id: Ib1d6bb866bcffa010a9e8f2a5e4296eba4e1d852 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-03-02Bug 531048 [GTK3] Large problems drawing ownerdraw tables (tests).Leo Ufimtsev4-0/+1501
Adding manual JUnit tests to verify changes to table don't break table. Tests are aimed at verifying visual glitches (like cheese). Going through these is quite quick (F1=pass, F2=Fail, F3=Skip, ESC=Quit). A lot of the tests originate from snippets. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5310483 Change-Id: I3ad13abd45110e528987b04f1061435d38127fa7 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-26Bug 531593 – [Webkit2] Crash in webkit on hoverLeo Ufimtsev1-1/+1
I can't reproduce the reported issue, but I can see a rare corner race condition where such a crash could occur. I.e, the race condition could be that webkit has internally disposed itself but we might be referencing it accidentally still. The fix is to guard against this. The fixes don't break anything as the jvm crash is occurring on webkit's disposal anyway. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=531593 Change-Id: Ia7394ce301b237dcf5ac43edb6590f0f5003e49f Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-20Bug 528498 - Combo menu is narrower than comboSimeon Andreev1-0/+70
In order to fix Bug 438992, wrap width of 1 was set for read-only combos. This results in drop-down menus which are narrower than the combo itself. Seen e.g. in the Eclipse Help preference page, where the combos are as long as the page, but their entries are relatively short. The drop-down menu is then only as short as the longest entry. This change ensures that the GTK style option -GtkComboBox-appears-as-list is used, for GTK versions above 3.22.5. This changes the drop-down menu style, preventing both Bug 438992 and Bug 528498. The option cannot be used in earlier versions, since due to a bug, the drop-down menu cannot be scrolled. Change-Id: I96aecae46c6edef65e69a9ae590e713bf607dd4b Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-02-15Bug 510803 [GTK3] Regression in table editing capabilities in tabfolder.I20180215-2000Leo Ufimtsev2-108/+124
Breakage occurred because tabItem reparented an item that had a non-standard gDk parent window. Solution: fix gdk window parent for such special controls. (I.e ControlEditors in tables). Verification: - Open child eclipse, change method signature. Now table cells can be edited via click. - Open attached snippet, with patch cells can be edited properly. - AllTests Gtk3.22 - X11/Wayland. Patchset 3: - Minor rename of methods to clarify that it's a *gdk* window, Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5108033 Change-Id: I8dcaac950eb0847dd97016b2140c607012550d2f Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-12Bug 530969: [GTK3] Control.print() doesn't seem to workEric Williams1-0/+113
In GTK3, gtk_widget_draw() relies on the priv->alloc_needed flag to be set to TRUE. This is an internal flag in a private struct so we cannot access it. The fix is to the get the topHandle's allocation, and simply re-set it. This triggers an allocation change without actually changing the size of the widget. Tested on GTK3.8+. No JUnit test failures. Change-Id: I81df53bfceaa988a2cce574ef7629c64c0ec6fb9 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-02-02Bug 481485: [GTK3.10+] Paint listener for button/label does not workEric Williams1-0/+45
On GTK3.10+, Buttons and Labels do not receive the proper draw signals. This is due to them drawing on their SwtFixed parents (fixedHandle), as GtkButton and GtkLabel do not have their own GdkWindows. This patch reverts parts of bug 483791 and fixes this bug by overriding windowProc() in Button and Label. There we check if the incoming handle is the paintHandle, and draw accordingly. Bug snippet is attached in this patch. Change-Id: I7c415985248ca5fda9e38aaf9b0c08ae834d762d Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-02-02Bug 530567 – Move BugSnippets into separate package and exclude fromLeo Ufimtsev56-5/+155
builds. (rename) Renaming bug snippets to 'ManualTests' to better express functionality. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530567 Change-Id: If0132056efaf7a952dbe9f9248180cb56c8f6c9d Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-01Suppress deprecation warnings.Alexander Kurtakov1-1/+3
For tests of deprecated methods. Change-Id: I58cd788ea798671d7d935480eb492886005e1384 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Suppress deprecations warnings.Alexander Kurtakov1-1/+2
For tests of deprecated method. Change-Id: I0d06befc87db71586784fd970d92efd4ce980d7f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Bug 530609 – Add missing license headers to bug snippetsLeo Ufimtsev42-35/+613
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530609 Change-Id: Idacfef6e77f9b9a4a3ecb75c8ad6b1746a86f50e Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-01Bug 529151 [Gtk] Move gtk function from OS.java to GTK.javaLeo Ufimtsev1-131/+132
Benefits: - Adding dynamic functions doesn't require one to manually link the function in os_custom.h anymore. This makes prototyping much faster and SWT development more user friendly. - NativeStats tool generates a separate category for gtk functions (from OS.java once). Technical details: - SWT Tools generates <CLASS_NAME>_LOAD_FUNCTION with GTK.java, we get GTK_LOAD_FUNCTION - we hard-code GTK_LOAD_FUNCTION to link to gtk lib (see os.h). - All native code is still put into os.(c|h) - I manually Updated a few special OS_LOAD_FUNCTION calls and removed old bindings in os_custom.h Verified with child eclipse. Fedora 27, Gtk3.22. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=529151 Change-Id: I6446ee5cca090022a8d984a1f92969c26e5e2f24 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-31Bug 530567 – Move BugSnippets into separate package and exclude fromLeo Ufimtsev8-33/+130
builds. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530567 Change-Id: I8cde9c76bf39ef8c1aa3e303012994e9c1473241 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-30Bug 529870 – [webkit2]BrowserProblemI20180130-2000Leo Ufimtsev1-0/+51
Fixing a corner case that can generate a deadlock. - A) User calls evaluate(SCRIPT) - B) The SCRIPT calls a BrowserFunction, (java/swt) - C) The BrowserFunction calls evaluate() Now webkit_web_view_run_javascript() in C never starts because webkit is still executing A. But A never finishes because it's waiting for C to complete to get a return value for A's callback. Solution: Don't allow blocking evaluation in BrowserFunction() callbacks. This shouldn't affect folks mostly, because from what I gather people use 'evaluate' as a form of execute(). This has gone unnoticed on Win32/Cocoa because issue isn't explicitly raised and 'evaluate()' return value wasn't used. Verified with AllBrowser JUnits. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5298702 Change-Id: Iddc8c753051455f6706ea81db85e0c6610be11a9 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-29Force qualifier update.I20180129-0540Alexander Kurtakov1-0/+1
Due to Bug 521182 - [compiler] method reference on null object should throw NPE at runtime (JLS compliance) Change-Id: I2acd20d411748d8e3c9d5b806aadff9cfa19f35d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-26Bug 530397 – [Gtk] Make gdbus initialization dynamicLeo Ufimtsev1-4/+7
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530397 Change-Id: Ia99129ce35b8e190402abea3a2eb75d668e8c825 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-22Bug 525305 – [API]Provide SWT.OpenUrl event (Linux implementation)Leo Ufimtsev1-0/+47
(For review/merge) Linux implementation for OpenUrl event, with use of GDBus. (As per original patch *1). URL vs file detection done via "new URI(file).getScheme()". I tested, this distinguishes URI's from files quite well. I.e: /myfile/ ./file file .. -> (OpenFile) http://www.eclipse.org mailto:my@mail.com .. -> (OpenUrl) I've tested with latest launcher: 1) Via launcher: eclipse http://www.eclipse.org /tmp/myFile 2) Via gdbus calls: gdbus call --session --dest org.eclipse.swt --object-path /org/eclipse/swt --method org.eclipse.swt.FileOpen "['http://www.google.com', '/tmp/myFile']" Patchset 2: - Updated URL detection logic so that files/urls are properly distinguished. Links: [1] Original patch: https://git.eclipse.org/r/#/c/30107/14/bundles/org.eclipse.swt/Eclipse+SWT/gtk/org/eclipse/swt/widgets/Display.java Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=525305 Change-Id: I6531989e3eb766fdf0715a0a9cb86c9ed2b973f3 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-17Bug 527738 [Webkit2] Add test case for calling setUrl with POST data.Roland Grunberg1-0/+28
Simply call bugs.eclipse.org and pass some x-www-form-urlencoded data in the POST message body. Change-Id: I9148ee19468c910044b5f2b93b4a7e96f3730edb Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-01-17Bug 528284: [GTK3] Toolbar: TCF dropdown control is cutoffEric Williams1-0/+79
Still testing, DO NOT MERGE. PART 1/2: SWT fix (other fix is for TCF UI code) Use gtk_button_set_image() instead of gtk_container_add() to prevent smaller buttons from having trimmed arrow icons when SWT.ARROW is specified. This change in logic is due to GTK3 using an actual GtkImage for icons, where GTK2 uses GtkArrow which is its own widget. Tested with ControlExample and the TCF Target Explorer ToolBar contribution. No AllNonBrowser JUnit tests fail. Change-Id: I3c4c33acb689ac36c4567cc8d7bbb5b3ff4e4c19 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-01-10Bug 529474 - [GTK] Fix array initialization problemRené Purrio2-2/+54
- Added test for treeitems also. - Added test for third column as well Change-Id: Ia16837a105bad053948faa079ab328aba88a8100 Signed-off-by: René Purrio <rpurrio@itemis.de> Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-01-09Bug 519295: [GTK3] Invisible settings button in validation preferencesEric Williams1-0/+74
Bug snippet to reproduce the issue. Change-Id: Ida0ebe281bc2fa7e6b73d6a63ff78f38b34412a8 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-01-07Bug 529494 - Convert to StringBuilderAlexander Kurtakov1-3/+3
Change-Id: Ic959ed6d7ae7aa50da85837105570b2b69ae66d3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>

Back to the top