Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/tests
AgeCommit message (Collapse)AuthorFilesLines
2018-10-12Bug 535075 - [Wayland] application rendered with an offset relatively toXi Yan1-0/+44
host window On Wayland, calling gtk_widget_size_allocate with a relative position to the GtkContainer causes window contents to be rendered outside of the actual GtkWindow. The fix is to map container's coordinate relative to the window's coordinate, and render the position according to the relative coordinate. Tested with child Eclipse Tip of the Day on Wayland (Bug 536153). Change-Id: I93d26be94f57fcb7556f4fe683f41783d5ebcdbc Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-09-28Bug 535083 - [Wayland] setRegion() and transparent shells don't work.Xi Yan1-0/+65
Platform Part-Drag causes eclipse black-out. 1) Replaced gdk_window_shape_combine_region with gtk_widget_shape_combine_region wrapper in Control#setRegion. 2) There is a bug in GTK on Wayland where pixels in window outside shape_region is black instead of transparent when the GtkWidget has opacity of 1.0. This causes the problem where part-drag rectangles introduces a black overlay shell covering Eclipse itself. This patch uses a hack where the opacity of the widget is set to 0.99 whenever we want to set a custom region. 3) Make the GTK_WINDOW_POPUP overlay in Tracker transient to the parent if possible to avoid window not mapped warning on Wayland. Tested on Wayland with Snippet134, Snippet 285, and child Eclipse. Change-Id: I5f2a1bdd3a7acee87b09ab23f8951da0dbbd5c53 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-09-26Bug 539367: [GTK3] Long text in Combo drawn over drop-down button andEric Williams2-0/+110
outside of combo Combos have a GtkCellView, which renders the text, and other icons. by default, GtkCellView has a "fit-model" property which is set to true. This means the content in the cell view will always expand to the maximum size. Setting it to false allows us to resize the cell view as desired. The fix for this bug is to set the clipping of the cell view to a smaller size: we find the x position of the drop down icon, minus its width. This stops the text from being drawn over the drop down icon, and sometimes over other widgets. Tested on GTK3.22 and 3.20, all other versions of GTK3 are unaffected. The snippets in this patch do not show the bug, nor does the one for bug 500703. Additionally, the keys preferences page does not exhibit any issues either. No AllNonBrowser JUnit tests fail. Change-Id: Iabfae03c7ee5b0279b87fa7054bc28c75d2d3b7e Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-09-20Bug 539274 - Test_org_eclipse_swt_widgets_Shell.test_activateEventSend()Ed Merks1-2/+1
doesn't compile on Windows Fix regression test Test_org_eclipse_swt_widgets_Shell.test_activateEventSend() so that it compiles on all platforms Change-Id: Ieb701f04d2fb33fe265b19499eb127531691ac58 Signed-off-by: Ed Merks <ed.merks@gmail.com>
2018-09-19Bug 533395 - [Gtk][Regression] Keyboard shortcuts are taken from firstXi Yan1-0/+43
item in "Input Source" instead of currently active input, thus breaking custom layouts (e.g Dvorak/Colemak/AZERTY) if it's not default layout. Previous patch to bug 61190 forces every keyboard layout to use any Latin layout group (depending on order of Map). For custom layouts that is a Latin layout group (i.e. contains alphabets a-z), there is no need to force an arbitrary Latin layout group for them as it might default to another layout if there are multiple input sources. Take the current active input layout if it is Latin group, otherwise take the default Latin group to prevent shortcuts not working for non-English keyboard. The patch applies to X11 only. On Wayland, GdkEventKey.group always defaults to the primary layout. Tested with attached snippet: Ctrl+i/Ctrl+. should copy/paste in both StyledText and Text in Dvorak. In child Eclipse: Ctrl+i/Ctrl+. copy/paste text in Dvorak, shortcuts should work under Russian keyboard. Change-Id: Iab4ee98060b3062bad1c5952436f2bed27225d07 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-09-19Bump versions for 4.10 stream.Alexander Kurtakov2-2/+2
Change-Id: Ie6cd01ef133af2634204dd34a8e8bf6707281bc2 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-09-18Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan1-0/+24
opening context menu Added regression test to ensure Activate events are send. Change-Id: I7d3aef73e14a86acd6f5edd544979a9c73b47741 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-09-18Even more GTK2 cleanups.Alexander Kurtakov2-152/+0
* Don't look for SWT_GTK3 * Remove GTK2 specific comments. * remove get_size from GtkCellRendererClass replaced by get_preferred_width Change-Id: If3f7f37a11310533257dc818fd1dd1f5112dbe91 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-09-18Remove Gtk3 check in tests.Alexander Kurtakov5-25/+11
SWT now requires Gtk 3.4+ so this check is of no use. Change-Id: I256c5aba82ebd173d1aa737c7af18c0fd38ceedb Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-09-18Remove unneeded SuppressWarning.Alexander Kurtakov1-1/+0
Change-Id: I9596050d28f33156ea6aea9f11dcce17cd4a2f0a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-09-14Bug 536766 - Drop 32 bit support in 4.10Sravan Kumar Lakkimsetti1-22/+0
Change-Id: I4bd55029efb18daad6efbe8172892b9911a6dc71 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-09-12Bug 464228 - [Gtk3] Combo box styling differencesXi Yan1-0/+57
Button on non-readonly Combo is not styled, so the background color of the button on combo is dependent on OS theme. GtkEntry and GtkToggleButton in Combo needs to be themed separately using different css providers. Added provider instance for button to load the background CSS to both entry and button instead of the entry only. Tested in child Eclipse in dark theme. On Ubuntu, Combo button is now dark instead of white. On Fedora, Combo button now has same background as entry. Change-Id: I77fbe01361c84309aadc9ab187ebaf80f560850c Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-09-12Bug 529534 - View content not fully updated after closing CTabFolder tabSimeon Andreev1-0/+108
Whenever an inactive tab is closed in a CTabFolder with a wrapped top right control, the tab area is not fully updated. This can result in an empty grey line, until the tab folder is resized. This change adds a layout request whenever an item of the CTabFolder is closed, ensuring correct layout of the current tab's client area. The change also adds a snippet show-casing the SWT bug. Change-Id: I0763b4e1a7c2e9aac08d030127e00f91e1087571 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-09-07Bug 533469 - [GTK3] Ghost button since upgrade to GTK 3.22Xi Yan1-0/+47
On GTK3.19+, widget are forced to be allocated the default minimum size regardless of the size of the fixed container, introduced after GTK commit 3e069428. This causes widgets with 0x0 size to be visible but unusable. The fix is to make 0x0 widgets invisible to the user explicitly using gtk_widget_hide. Resizing widget to a non-zero size later on shows the widget in setBounds. Tested with snippet, empty shell when size of Control were not set. No ghost button on Papyrus Property dialog. Change-Id: I6e47d838c3a4679e5b8f2140601b23ca57e13ee7 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-09-05Bug 538531 - POM version change for 4.10 releaseSravan Kumar Lakkimsetti5-5/+5
Change-Id: I22a7fa1170509c771d1284173aa708bf8ca6bee6 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-09-04Bug 538579 - DateTime SWT.DATE and SWT.Time styles do not allow to setXi Yan1-0/+47
value SWT.DATE & SWT.TIME need handle to be registered in widgetTable in order to function correctly. Added additional checks to register/deregister handle. Tested with attached snippet, no additional test breaks in AllNonBrowserTests. Change-Id: I928aa7122abba427af29242504c3a5feeacf141b Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-27Bug 538114 - [GTK3] Tree in ExpandBar has no content until resized orXi Yan1-0/+84
collapsed/expanded Internal widgets inside ExpandBar's control don't get sized properly when first created. The fix is to always show the control before setting any bounds. Change-Id: Id247d69efad52801813453e0ce9715c8a2ce2d7e Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-21Bug 530393 - EPL 2.0 update for SWT test plug-insLars Vogel338-1017/+2034
Update all sources files except .exsd files, Java pref files and pom files Staged via: git grep --name-only 'Eclipse Public License 2.0' > input.txt Manually added \ before the spaces in the directories with spaces cat input.txt | xargs git add Regex used: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I000f78a584a97bdd8d6749b3569cd953a4e7e0c1 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-20Bug 442831 - TextLayout.getLineBounds returns incorrect values for rightXi Yan1-0/+135
to left text pango_layout_iter_get_line_extents gets the extents in layout coordinates from top-left corner. Removed recalculation of x when using RTL since already in correct direction. Change-Id: Ib7e1bbb552805eab89ebf072481dfcdec7599caf Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-17Bug 536564: Test failures on Mac OS X 10.13 from I20180628-0230Lakshmi Shanmugam2-8/+0
Removed code to capture screenshots Change-Id: I0dae4bb46682bb7f3a85b22de820bd6e70c73e50
2018-08-16Added native C snippets for SWT bugs.Xi Yan3-0/+268
Change-Id: I16e310881955447d8d7e9244558c388a2cb6f907 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-16[WIP] Bug 537960 - Tree in SashForm doesnt paint last rows on resizeSimeon Andreev1-0/+109
When resizing tree views, e.g. the Package Explorer, the text and images of bottom rows are sometimes not painted. In particular, JFace OwnerDrawLabelProvider registers an paint and an item measure listener. Due to the registered measure listener, the paint listener is not triggered when the sash is moved. This behavior is seen due to the fix for bug 531667, which (among other changes) restricts widgets from painting over other widgets. This change adds an SWT bug snippet for the problem. Change-Id: I2f523565675907aaadad8e09a0f054698272885d Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-08-16Bug 536564: Test failures on Mac OS X 10.13 from I20180628-0230Lakshmi Shanmugam2-4/+25
Temp code in attempt to fix failing tests - added sleep before asserts and capture screenshots. Change-Id: I78920da73ff1ed91219174964f9fc80ca6ebf6b4
2018-08-15Bug 528819: [GTK3] StyledText draws carets if unfocusedEric Williams1-0/+53
Only draw the caret if it has focus: this logic existed for GTK3.20- but was removed in a fix for Wayland. Restoring this behaviour fixes the bug for GTK3.22 as well. Tested with the snippet attached and in the IDE. No reduction in Caret performance is observed. Change-Id: I91d78217e90ce7ac7d1ab3e0898b0dda6fad44d2 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-15Move to Surefire 2.22.0 in swt.tests.Alexander Kurtakov1-1/+1
Change-Id: Ie4133c4d80bce537f18761204740bfe7ff4cbf4c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-14Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan1-0/+79
opening context menu Fix test issues caused by previous patch. Previous patch prevents activate event to be send when they are necessary, causing several shell issues. This patch has the logic: when context menu is shown, ignore focus_out/deactivate event for shells. When context menu is hidden, ignore activate event for shells. Tested with WorkbenchTextEditorTestSuite (workbench.texteditor.tests), UIAllTests (e4.ui.tests), and UiTestSuite (ui.tests) locally. In child Eclipse, Ctrl+F and pasting text via Ctrl+V pastes text into search entry. Holding down Ctrl and pressing E multiple times cycles list. Change-Id: I2a2a023c798e1231a7c6c72e9cb94177af5f4aa2 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-14Bug 537713: [GTK3] Combo sizing problemsEric Williams1-0/+45
Do not perform resize calculations for Combos, as their large minimum and/or natural sizes causes API breakages with setBounds(). Tested with the snippets from this bug and bug 535323, AllNonBrowserTests, and the IDE: no allocation warnings occur. Change-Id: Ieefa0752fcb2dd3a743ebcc432eef939a46b73f4 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14Bug 536141: [Webkit2][Gtk] BrowserFunction lost after page reload onEric Williams1-0/+158
Linux/GTK The main cause of this bug is that web pages load too quickly -- by the time the BrowserFunctions are re-registered asynchronously from Java, the extension has loaded the page. BEFORE THIS PATCH: BrowserFunctions were registered asynchronously from Java into the web extension (C). This was done either at the outset (WebBrowser.createFunction()), or after every page load (Webkit.webkit_load_changed() callback). AFTER THIS PATCH: The fix is relatively straightforward, yet GDBus adds a lot of overhead. Instead of constantly registering BrowserFunctions from Java, we load them into the web extension on creation. This hands off the responsibility of re-registering BrowserFunctions to the web extension, which reduces overhead and ensures the functions are registered/executed before the page loads. The BrowserFunctions are stored at the C level in the extension, using a linked list. Whenever the "object-cleared" callback is triggered in the extension, the linked list is iterated over and any BrowserFunctions for that page are re-registered. Chronological ordering of information flow from SWT -> web extension via GDBus. 1) SWT Webkit class is loaded. SWT GDBus server is created. 2) SWT Webkit creates the extension, passing it the information of the SWT Webkit GDBus server. 3) The extension's initialization callback is called in C. 4) In this callback the extension contacts the SWT Webkit GDBus server and provides it with information such as its PID and name. 5) SWT Webkit acknowledges this information, and sends back any BrowserFunctions that were created before the extension loaded. 6) The extension adds these BrowserFunctions to its linked list. 7) Any subsequent BrowserFunctions are added to the extension's linked list by calling the extension's GDBus server synchronously. In the event of a GDBus timeout (happens sometimes when running tests), the GDBus call is made asynchronously. This functionality can be tested with the attached snippet. AllBrowserTests pass without issue, and there are no visible Browser issues in the IDE. The plugin attached to the initial bug report is now functional. Change-Id: Iddc5f2e69f0a7fd4500bd8228f0bc46c4b3a6322 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-13Revert "Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events when ↵Andrey Loskutov1-79/+0
opening context menu" This reverts commit 9f91c882bb8f96c689143525a71937171402a3d7.
2018-08-07Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan1-0/+79
opening context menu Activate/Deactivate events are sent when the context menu is shown. Use flag to ignore activate/deactivate events when context menu is open. Change-Id: Iaa7a55fca388220421ba1d7f6718874689f7d88b Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-04Bug 532941 - [Wayland] Error output about "a temporary window withoutXi Yan1-0/+86
parent" 1) Attached snippet was broken on GTK3 with both x11 and Wayland. The column width is 0 and the table appears as a thin line. See bug 509503. This was fixed by always showing the table before getting preferred size on GTK3. 2) The warnings on Wayland occurs due to having a popup window without a parent. Shells with SWT.ON_TOP style was always created as a GTK_WINDOW_POPUP, this causes issues when the shell has no parent on Wayland due to lack of global coordinates. The fix is to never create a popup window without a parent. 3) Fixed the issue with the open editor dialog (CTRL+E) having a title bar above, by preventing decorations for shells without SHELL_TRIM style set. Tested with attached snippet and open editor (Ctrl + E) in child Eclipse with GTK3.22 on X11 and Wayland. Change-Id: I6d33c2e9bb00a55f84a79303f7326d0c8cd0a3ec Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-04Bug 537025 - SWT + GTK3 + Sending key events programmaticallyXi Yan1-0/+231
Fixed regression from Bug 302171 where sending modifier as a separate key event does not work. Sending GDK_KEY_PRESS event using gdk_test_simulate_key will not hold key down infinitely until a GDK_KEY_RELEASE event is sent. The modifier is cached in case modifiers are sent in separate event to Display.post(). Tested using attached snippet and Snippet146. Change-Id: I2c9b617345b3f92c3a32299e64ce7f1ce5ef7992 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-04Bug 336238 - Shell.setBounds sometimes fails to set the right locationXi Yan1-0/+46
Calling gtk_widget_show for the first time before gtk_widget_resize assumes the initial default size for any subsequent calls to gtk_widget_move. This causes issue with shell.setBounds where the location can only be moved to a limited bound on the screen corresponding to the default size by the window manager, even when the new resized shell is smaller and is able to move to further x, y position without being cutoff by the screen. The fix is to set the default size to the smallest possible (1, 1) before gtk_widget_show. Tested with attached JUnit test. Change-Id: I3f20a6aaed5972bfda3775816aab96202bae7e5d Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-07-27Bug 537364 - restrict widgetTable leak tests to Linux onlyAndrey Loskutov1-2/+2
Change-Id: Ib989a8aec54874922e8cd1ba53ed128b509334e0 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-26Bug 532632 - add runtime checks for Display.widgetTable consistencyAndrey Loskutov2-2/+3
SWT unit tests will run now with -Dorg.eclipse.swt.internal.gtk.enableStrictChecks which will check Display.widgetTable consistency during add/removeWidget operations. Change-Id: I09b7ef178561fac4861be579f4f15ee329f99248 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-26Bug 537364 - [GTK] DateTime instances leaks in the widgetTable afterAndrey Loskutov1-0/+29
disposal Only register/deregister handles if they are not already registered/deregistered. The test checks leaking widget handle in the widgetTable: after disposal, no traces of a widget should be found there. Change-Id: I678996b5004d348d6f1e24c9e8e5708e8c46bd9d Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-20Bug 536934 - [GTK3] Tree does not allow painting the full itemXi Yan1-0/+80
Changes made to custom drawn trees which updates event.x from Cairo context causes paint to "jump" when scrolling horizontally and not scrolling to the end of the text on GTK3.16 and above. Checks for GTK versions >3.9 and <3.14.8 when making updating event.x from Cairo context. See bug 535124, and bug 465309. Tested on GTK3.22 with snippet attached to this patch, sample project in bug 535124, and the open type dialog, package explorer in a child Eclipse. Change-Id: Iaf464c6fee1d5ef288346abbd0ab5a60f20f1a95 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-07-13Bug 127132 - [GTK] TableColumn#pack does not work for virtual tableXi Yan1-0/+136
Fixed NPE when invoking pack on virtual table caused by previous patch. Change-Id: I3f1f6a995294d20a86c964d3b697888ebd427aac Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-07-11Use assertFalse in swt.tests instead of assertEquals(false,.)Alexander Kurtakov7-39/+43
Change-Id: I4b72dc2c4ce365407a2b26ac3f38f8689380a6cb Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-10Bug 531882 (Snippet230_tableCol_icon_packing) - [Gtk3] Snippet230,Xi Yan1-0/+112
tablecolumn icons on right size get cut off 1) In GTK3, event.width in PaintItem is the same as the one previously set in MeasureItem. Snippet230 paints icons at the default event.width position on the right of text in PaintItem, so the icons were painted too far right as a result. This was fixed by explicitly setting event.width to be used in PaintItem to the default event.width using gtk_cell_renderer_set_fixed_size. 2) Custom drawn icons in the expander column of Tree is not positioned correctly. Fixed by adding expander arrow indent in the x position. 3) Calling TreeColumn#pack() for the first time do not account for the indent in the expander column because gtk_tree_view_get_expander_column() returns 0 if expander column is not visible. This was fixed by setting column to visible beforehand in Tree#calculateWidth. Change-Id: I04a26c94ff716c1a52c84d2dbe8ef96386b17035 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-07-09Bug 340752 - [GTK3] Control getSize() behaves different in Linux andXi Yan1-108/+121
Windows. Getting wrong value on linux Removed visible check in ExpandItem#resizeControl to set bounds for items not expanded. Change-Id: Ibb926eb7784113d5b800eb236d8432a35e6f9df5 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-07-05[Bug 536564] Test failures on Mac OS X 10.13 from I20180628-0230Lakshmi Shanmugam2-2/+2
The tests pass locally, increasing timeouts further to check if they pass on the test machine. Change-Id: I9436ba63b23c09bda1dcf73c265558da87d84a29
2018-07-03Bug 475784: half transparent composite as overlay composite not workEric Williams1-0/+248
with gtk3 ATTEMPT #2: fix regression from original patch. Instead of keeping the NO_BACKGROUND flag, cache it in Control and remove it as intended in Composite.checkStyle(). Original commit message: We have to handle some corner case drawing situations, since Control.setRegion() now uses Cairo entirely. In particular, we need to handle the case where a user is using an SWT.NO_BACKGROUND Composite as an overlay. This means the Composite has a region set, and a paintListener attached to perform custom drawing. Previously, Control.setRegion() "physically" manipulate the Composite's GdkWindow to prevent any drawing outside the given region. Since Cairo is now responsible for drawing the set region we have to handle this geometry ourselves. This patch fixes numerous issues all rolled into one. First, it adds a field in GCData which corresponds to the Cairo region. This is set in gtk_draw() so that GC.fill* methods will clip themselves accordingly and not fill where they aren't supposed to. Second, it checks for a PaintListener, NO_BACKGROUND, and a region being set. If these conditions are met, we draw a transparent background in Control.drawBackground() to ensure the region and custom drawing succeeds. Last, we copy the region at the Cairo level to ensure there are no crashes when calling setRegion(region) followed by region.dispose(). Tested on GTK3.22 using the snippet attached and a child Eclipse. No AllNonBrowser JUnit tests fail. Change-Id: I6a6245052e9756d6c9bdd0e46ef20a74413acc6b Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-07-03Bug 536234 - [syntax highlighting] single char update not renderedMickael Istria2-0/+68
Change-Id: Ib8fcfc46e8e7ce2716e742c15da9cbb4338807c8 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-07-02[Bug 536564] Test failures on Mac OS X 10.13 from I20180628-0230Lakshmi Shanmugam2-1/+22
Adding/Increasing the timeout to fix the test failure on Mac 10.13. Todo: Need to verify if fix in test_setActive(), fixes test failure on GTK Change-Id: I8d6ac45fd3a5f55e16ecad549f864e9ba66e2a9b
2018-07-02Revert "Bug 475784: half transparent composite as overlay composite not work ↵Andrey Loskutov1-248/+0
with gtk3" This reverts commit 70cce8be1320532905ef82171b46309da5c59bc7.
2018-06-29Bug 475784: half transparent composite as overlay composite not workEric Williams1-0/+248
with gtk3 We have to handle some corner case drawing situations, since Control.setRegion() now uses Cairo entirely. In particular, we need to handle the case where a user is using an SWT.NO_BACKGROUND Composite as an overlay. This means the Composite has a region set, and a paintListener attached to perform custom drawing. Previously, Control.setRegion() "physically" manipulate the Composite's GdkWindow to prevent any drawing outside the given region. Since Cairo is now responsible for drawing the set region we have to handle this geometry ourselves. This patch fixes numerous issues all rolled into one. First, it adds a field in GCData which corresponds to the Cairo region. This is set in gtk_draw() so that GC.fill* methods will clip themselves accordingly and not fill where they aren't supposed to. Second, it checks for a PaintListener, NO_BACKGROUND, and a region being set. If these conditions are met, we draw a transparent background in Control.drawBackground() to ensure the region and custom drawing succeeds. Last, we copy the region at the Cairo level to ensure there are no crashes when calling setRegion(region) followed by region.dispose(). Tested on GTK3.22 using the snippet attached and a child Eclipse. No AllNonBrowser JUnit tests fail. Change-Id: Icdd04d8a4e0e504a5ee69688ba304af3956e4f77 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-06-28Bug 536384: Build failed 4.9.0 I-Build: I20180627-2020Lakshmi Shanmugam1-1/+1
Increment bundle version Change-Id: I98ec296398c1457297bd87a332e52352de4696d9
2018-06-26Bug 302171 - Characters requiring <Alt Gr> cannot be generated usingXi Yan1-0/+105
Display.post(Event) 1) Added SWT.ALT_GR constant mapping to ISO_Level3_Shift (0xfe03). 2) Replaced OS.XTestFakeKeyEvent in Display.post, which only supported US keyboards, with gdk_test_simulate_key to simulate key event. Added the option to send key modifier together with key character in a single event to Display.post on GTK. Change-Id: I97311e639b612ac1f6aed23beb68034f40d211b1 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-06-20Bug 535124: CSS tree selection issue on Linux onlyEric Williams1-0/+66
This patch reverts some changes made to custom drawn Trees which fixed bugs on lower versions of GTK3 (3.14 and below). Unfortunately these changes broke some basic Tree selection background/foreground drawing. On GTK3 we need to use the clipping from the cairo context provided by the gtk_cell_renderer_render() function. It provides the x and width values. The y and height values can continue to be fetched via gtk_tree_view_get_background_area(). Tested on GTK3.22 with the sample project provided in the bug report, and the snippet attached to this patch. Testing in a child Eclipse shows no ill effects in the call hierarchy, open type dialog, package explorer, etc. No AllNonBrowser JUnit tests fail. Change-Id: I57933468313376f6d3735644fc9a5eb19fee3c99 Signed-off-by: Eric Williams <ericwill@redhat.com>

Back to the top