Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-06-06Bug 319612: [Gtk] Shell.getSize() returns wrong value when created withEric Williams1-0/+16
style SWT.RESIZE | SWT.ON_TOP Ignore hardcoded trim when calculating sizes for shells with SWT.ON_TOP and SWT.RESIZE set (i.e. "custom resize" shells). These shells already use border as set by gtk_container_set_border_width() -- subtracting the trimming in Shell.setBounds() is unnecessary. Tested on GTK3.22 on X11 and Wayland. A JUnit test case to reproduce the issue is attached. No AllNonBrowser JUnit tests fail. Change-Id: I81ebd319b623dfb3b98c533996a43e6435e80d2f Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-06-05Bug 535318 - Update license to EPL-2.0 for platform.swt in about.htmlLars Vogel1-16/+24
Change-Id: I4526c5c3c2967d58e0e83f4d3eccfeabc268cff3 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-06-01Version 4.9 update in plaform.set as prep for the EPL 2.0 updateI20180601-0900Lars Vogel2-2/+2
Change-Id: I3ad44261dffe9d6d9097eb2c66a49ed31a57df25 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-05-29Bug 535191 - POM version change for 4.9 releaseAlexander Kurtakov1-1/+1
Change-Id: Icf2788319e154102ecb1002b3e9783824e709266 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-24Bug 480639: Provide monitor-specific DPI scaling / zoom levelLakshmi Shanmugam1-0/+11
Added JUnit test for Monitor.getZoom() API Change-Id: I67430320238f6ba6ea0a16001a260537e4385f34
2018-04-23Bug 533677 - [win32] calling Browser#refresh does not callLars Vogel1-0/+21
ProgressListener#completed Adds test to ensure a completed listener is called Change-Id: Ice4e6cbfa7ce2cc57a58739430581df56bd0ccb2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-17Bug 533660 - Use method reference forLars Vogel1-22/+21
Test_org_eclipse_swt_browser_Browser#waitForPassCondition calls Change-Id: Ib4b4f6b8d94781378dfe7a0172d17977c369321f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-14Suppress deprecation warning.Alexander Kurtakov1-1/+2
In test of deprecated method. Change-Id: I07be2e39a69b3e926cf496f7955104d30880bc38 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-05Bug 532946 – Fix SwtTestUtil#isRunningOnEclipseOrgHudsonGTKLeo Ufimtsev1-2/+2
Changing to isRunningOnContinousIntegration Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532946 Change-Id: I13a8f9e69e83a6af274bbb0e14d1d9ac7c0b97df Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-04Bug 530678 [webkit2] UI hangs after navigating through Javadoc hover,Leo Ufimtsev1-0/+64
when clicking an icon or link to an image. TL;DR: Fix for bug. Details: Clicking on a javadoc like below, (after 2 or 3 times), breaks javadoc. /** <a href="https://bugs.eclipse.org/bugs/attachment.cgi?id=272647">Screenshot</a> */ It un-breaks if you manually kill Webkit* processes. I.e, Webkit process deadlocks if Browser is disposed in the middle of a callback. The fix is to delay disposal until callback is completed. This is achived by leaving a dangling reference until next display loop is executed. This also fixes the bug: 494158 - [Webkit1][Webkit2] JVM crash when javadoc hover has <embed> tags. In addition, I'm adding a jUnit to verify that the fix hasn't introduced memory leaks. (E.g if object is not unreferenced, then one can observe a memory leak. So by extension this fix does not introduce a memory leak since the test passes). (Note, it's not added to be ran automatically becaues it takes 5+ minutes to run). Tests & verification: (gtk3.22, Webkit2.18). - jUnit: AllTests - Child Eclipse opens external links (multiple times) in javadoc correctly. - Various Browser Snippets. - Test_Memory_leak.test_Browser(). https://bugs.eclipse.org/bugs/show_bug.cgi?id=530678 Change-Id: I2a0f0f7e2b44bce67a1212bfa4205561942e59de Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-04532946 – Fix SwtTestUtil#isRunningOnEclipseOrgHudsonGTKLeo Ufimtsev2-13/+11
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532946 Updating variable name and remvoing hudson reference. Also, since tests servers now run Webkit2, removing condition from tests that were skipped by test server because test server used to run Webkit1. Change-Id: I081c279ca7ac96735acb31e063f74c3851cfdf34 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-03-27Bug 527738: Fix test_setUrl_remote_with_post test.Roland Grunberg1-3/+13
Use ProgressListener to determine when POST request has completed. Change-Id: I6c2d0cfaffb22a69f93a681451b54fc1b1ee4f2e Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-03-23Bug 532825 - Remove hpux/solaris clutter in the codebaseAlexander Kurtakov1-3/+1
Change-Id: I735be5853d393097c7d11c9abb43e9e5cbf93c8d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-03-23Bug 488431 - Provide SWT/GTK3 port on WindowsRolf Theunissen2-8/+10
Test for windows style newlines (os=windows) instead of windows platform (platform=win32) Change-Id: I97d96c4b24c6b7ff9152c715ada973acfeb01075 Signed-off-by: Rolf Theunissen <rolf.theunissen@altran.com>
2018-03-19Bug 532139 – Add Copyright to a java few files.Leo Ufimtsev2-288/+0
Adding missing copyright notices and removing old Command line interface that is no longer being used as such testing can be accomplished via launch groups. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532139 Change-Id: I9cc3e9a48e70adbd49c993e39100be1301ea5551 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-03-16Bug 532548 - Update surefire to 2.21.0Alexander Kurtakov1-1/+1
Change-Id: I27ee0acc233dd44791f94a00537786882272ca60 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-03-16[Tests] Use dedicated SWT native lib cache folderI20180316-0455Mickael Istria1-0/+3
SWT tests often also involve testing a new snapshot of the native libraries. As SWT usually puts the libraries in a cache under user.home, it makes SWT tests more likely to used the cached version then the one that inside platform-specific fragments. SWT Tests are now configured to use a different user.home to not interact with the default cache directory. Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-15Bug 530019 - StyledText.setStyleRange resets less cacheangelozerr2-2/+261
Change-Id: Iaa4e0177de4e9d962fcdd4ea1aeeae6d6e8f2e54 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-14Bug 532173 - [StyledText] Wrong caret bounds with variable heightMickael Istria1-0/+39
Fix bug in getBoundsAtOffset to make it more reliable. Place caret to better location when it doesn't fit the whole line. May as well fix bug 118612 Change-Id: I381dcc9039dae62dfddbd069487f7ecec85057c4 Signed-off-by: Mickael Istria <mistria@redhat.com> Also-By: Angelo Zerr <angelozerr@gmail.com>
2018-03-14Revert "Bug 532173 - [StyledText] Wrong caret bounds with variable height"Mickael Istria1-39/+0
This reverts commit 2ef119e594da0ed9e93c88f3b32b03e82863870c. Change-Id: Ida4a0312d3a46498cff147982463ee933a508e80
2018-03-14Bug 532173 - [StyledText] Wrong caret bounds with variable heightMickael Istria1-0/+39
Fix bug in getBoundsAtOffset to make it more reliable. Place caret to better location when it doesn't fit the whole line. May as well fix bug 118612 Change-Id: I942787c801090ff504c8ed37183a97b312f78e18 Signed-off-by: Mickael Istria <mistria@redhat.com> Also-By: Angelo Zerr <angelozerr@gmail.com>
2018-03-07Revert "Bug 528498 - Combo menu is narrower than combo"Alexander Kurtakov1-70/+0
This reverts commit 2feeddb0172f839c43ea8087619a9ea912eb88fa. Change-Id: I32d4f75cda1fbd9c7e88d212124f06830291fcaa
2018-03-05Bug 508600: The average character width of a font is not integerLakshmi Shanmugam1-0/+6
Added Junit test for the new API Change-Id: I1f78e5fe55746a57a38ed7a579c39547666b6d05
2018-02-26Bug 531593 – [Webkit2] Crash in webkit on hoverLeo Ufimtsev1-1/+1
I can't reproduce the reported issue, but I can see a rare corner race condition where such a crash could occur. I.e, the race condition could be that webkit has internally disposed itself but we might be referencing it accidentally still. The fix is to guard against this. The fixes don't break anything as the jvm crash is occurring on webkit's disposal anyway. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=531593 Change-Id: Ia7394ce301b237dcf5ac43edb6590f0f5003e49f Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-20Bug 528498 - Combo menu is narrower than comboSimeon Andreev1-0/+70
In order to fix Bug 438992, wrap width of 1 was set for read-only combos. This results in drop-down menus which are narrower than the combo itself. Seen e.g. in the Eclipse Help preference page, where the combos are as long as the page, but their entries are relatively short. The drop-down menu is then only as short as the longest entry. This change ensures that the GTK style option -GtkComboBox-appears-as-list is used, for GTK versions above 3.22.5. This changes the drop-down menu style, preventing both Bug 438992 and Bug 528498. The option cannot be used in earlier versions, since due to a bug, the drop-down menu cannot be scrolled. Change-Id: I96aecae46c6edef65e69a9ae590e713bf607dd4b Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-02-02Bug 530567 – Move BugSnippets into separate package and exclude fromLeo Ufimtsev8-3/+3
builds. (rename) Renaming bug snippets to 'ManualTests' to better express functionality. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530567 Change-Id: If0132056efaf7a952dbe9f9248180cb56c8f6c9d Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-01Suppress deprecation warnings.Alexander Kurtakov1-1/+3
For tests of deprecated methods. Change-Id: I58cd788ea798671d7d935480eb492886005e1384 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Suppress deprecations warnings.Alexander Kurtakov1-1/+2
For tests of deprecated method. Change-Id: I0d06befc87db71586784fd970d92efd4ce980d7f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-31Bug 530567 – Move BugSnippets into separate package and exclude fromLeo Ufimtsev8-33/+130
builds. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530567 Change-Id: I8cde9c76bf39ef8c1aa3e303012994e9c1473241 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-29Force qualifier update.I20180129-0540Alexander Kurtakov1-0/+1
Due to Bug 521182 - [compiler] method reference on null object should throw NPE at runtime (JLS compliance) Change-Id: I2acd20d411748d8e3c9d5b806aadff9cfa19f35d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-17Bug 527738 [Webkit2] Add test case for calling setUrl with POST data.Roland Grunberg1-0/+28
Simply call bugs.eclipse.org and pass some x-www-form-urlencoded data in the POST message body. Change-Id: I9148ee19468c910044b5f2b93b4a7e96f3730edb Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-01-10Bug 529474 - [GTK] Fix array initialization problemRené Purrio2-2/+54
- Added test for treeitems also. - Added test for third column as well Change-Id: Ia16837a105bad053948faa079ab328aba88a8100 Signed-off-by: René Purrio <rpurrio@itemis.de> Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-01-07Bug 529494 - Convert to StringBuilderAlexander Kurtakov1-3/+3
Change-Id: Ic959ed6d7ae7aa50da85837105570b2b69ae66d3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-05Bug 529442: [Webkit2] Add more restrictions on clearAllSessionCookies.Roland Grunberg1-1/+7
The clear all sessions functionality for Webkit2 is only available since version 2.16, so skip the test if this is not satisfied. Change-Id: I0ee752be9f5cc65191b31b1f4f101dea6c2e5570 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2017-12-22Bug 528968: [Wayland] JVM crashes when running JUnit tests on WaylandEric Williams2-4/+7
Guard call to takeScreenshot() so that running the SWT JUnit tests doesn't crash the JVM on Wayland. Change-Id: I0ea725a491dfc1f7781ccd647b706e5a5517fc59 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-12-21Bug 528746 - Added test for StyledText#getOffsetAtPoint(Point)Karsten Thoms2-2/+34
Change-Id: I4e9a0024ec8b5a167815f2a60d313e5596c5217d Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-12-18Bug 528415 - CTabFolder tabs vanish after mouse-overSimeon Andreev1-0/+47
If a CTabFolder specifies SWT.RIGHT_TO_LEFT as one of its styles, mouse-over on a tab will make the tab not draw. This painting artifact remains until another window becomes active. See the bug snippet. This is due to wrong clipping set to the draw event in Control.gtk_draw(). The event bounds are correctly set in the case of SWT.MIRRORED (derived from SWT.RIGHT_TO_LEFT), but for the clipping area SWT.MIRRORED is not taken into account. This is a regression coming from bug 421127. This change ensures the event clipping equals the event bounds, on draw event creation. This ensures the tabs of the CTabFolder are redrawn. Change-Id: I3bb9049bac98c5f5d360135771ef43ef1cc1a9b1 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-12-15Bug 475659 Data race asyncExecRanLeo Ufimtsev1-3/+5
Use AtomicBoolean instead an array to avoid concurrent read/write warning/issues. Bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=475659 Change-Id: I80f5e026e1cfa6503e45e65e074de855454989cc Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-12-13Bug 528251 - Test to check tab highlight with nested CTabFoldersSimeon Andreev1-0/+83
When a view contains a selected CTabFolder, selecting another view in the same part stack results in non-highlighted view tab. This is the case, since CTabFolder.onActivate/onDeactivate will tell ancestor CTabFolders to highlight resp. not highlight. Selecting another view results in deactivating the nested CTabFolder and so removing highlighting from the part stack tabs. This is a test for the missing highlight. Change-Id: Iad92b122883068114ddeebe96bc422da206d2c85 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2017-12-12Bug 528251 - view CTabFolders result in not highlighted part stack tabSimeon Andreev1-0/+96
When a view contains a selected CTabFolder, selecting another view in the same part stack results in non-highlighted view tab. This is the case, since CTabFolder.onActivate/onDeactivate will tell ancestor CTabFolders to highlight resp. not highlight. Selecting another view results in deactivating the nested CTabFolder and so removing highlighting from the part stack tabs. This regression was introduced with the fix for Bug 474444. With this change, highlighting is toggled only for the CTabFolder which is being activated/deactivated. The change was verified both on Windows and on RHEL+GTK3.14. The problem from Bug 474444 is not observed. Change-Id: I6fd4bf7f049e84d95bd5e83332a6484164623576 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2017-12-08Remove useless code.Alexander Kurtakov1-1/+1
Useless suppress warnings and semicolon. Change-Id: I23b782aae94b774c9a9b38f89f541c659c4c5566 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-12-01Bug 510905 [Webkit2] BrowserFunction with return value back toLeo Ufimtsev1-4/+0
Javascript (PRIOR TO MERGING, SWT BINARY REPO NEEDS TO BE PATCHED) Webkit2 moved it's webprocess into a separate process. For javascript to call a function, it needs to do so via the separate process. To interact with the separate process, we need to implement a webextension, which is a separate '.so' file loaded at run time. The extension needs to reside in it's own folder otherwise webkit will try to load the other .so files as extensions. (See Library.java changes). Communication between the extension and the main process is done via a gdbus channel. Javascript/Java types are packaged into GVariants and transmitted via gdbus. Compilation of the webextension requires webkit2gtk package to be present on build servers. Tests: - All jUnits pass - SWT Snippet (307) that use BrowserFunction work. - Attached local snippet can be used to test sending various paramaters over gdbus and receiving them back prints to main webview. - Child eclipse works fine with the patch. - Afaik, no known error/warnings are produced. (If there are, let me know). This might break 32bit build of SWT though, not tested on 32 bit. Patch set log: -------------- Patchset 6: - Passing webview as string in javascript function. Patchset 8: - Implemented dynamic gdbus bindigs on SWT/Java side. Works. (fairly large patch) Patchset 9: - Implemented gdbus bindings on client side, such that it can reach server. (working) Patchset 10: - Added GVariant conversion functions on SWT side. Works. - Moved code out of OS.java to reside only in WebKitGTK Patchset 11: - Figured out how to provide return value as an object array. Added snippet to show how to provide a string return value. (working) Patchset 12: - Passed webview pointer, index and token to Java. - Fixed typo in type definition. > (Working) Patchset 13: - Now passing javascript arguments along through gdbus to java. > (Working) Patchset 14: (Week 46) - Implemented support for 'null'. (use byte as magic number). - Found that there is a bug in how I deal with return value in gdbus, gdbus returns an array (always). Need to return first item in array. Patchset 15: (Week 46) - Implemented proper return value of java to javascript. - Found that js calls with no paramaters call() fail, need to fix. Patchset 16: (Week 46) - Implemented support for empty arrays (including calls without args). - Code tidy. - Found that I need to implement input argument verification from JS call and from java code ran by user, otherwise gdbus can crash. Patchset 17: (Week 46) - Implement checking of user-input arguments, to ensure it won't break gdbus connection. Patchset 18: (Week 46) - Implemented checking of return value from userfunction, so bad return value doesn't break gdbus. - Code tidy/polish. - Need to implement lazy loading of gdbus, only init gdbus for the first function that we instantiate. - Also still getting warning when loading webkit library. Patchset 19: [Week 47] - Implemented lazy loading of gdbus, to only load when needed. - wrapped getPID() into lock, otherwise had strange debug/execution behaviour. Patchset 20: [Week 47] - Two BrowserInstances with Two BrowserFunctions seem to hang (snippet), (need to investigate) Patchset 21: [W47] - Removed redundant print statements. Cleaned up code. Patchset 22: [W47] - Moved Webkit extension initialization logic into a callback, so that it's guaranteed to be loaded at the most optimal time. (All jUnits pass). Patchset 23: [W47] - Removed redundant println. Patchset 24: [W47] - Implemented mechanism by which webextension is compiled and loaded from a folder. (This needs a patch to binary project's build.properties) Patchset 25: [W47] - Code tidy. Patch complete (ish). Patchset 26: [W47] - forgot to add files to patchset 25. Patchset 27: [W47] - Verified that Browser widget will continue to work if webextension fails to load. - Added relevant warnings. Patchset 28: - Minor update on SWT_LIB_VERSIONS. Change-Id: Iccfc48bc78774ac4120aafd976186381f247c562 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-11-30Bug 527935 - Add Automatic-Module-Name to MANIFEST.MF in SWT repoAlexander Kurtakov1-0/+1
Change-Id: I7ac7f58b3c252b6baabaacae3ac4d3b197b76ba3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-11-28Bug 522020 - [API] Customize different line spacing of StyledText withangelozerr2-2/+88
LineSpacingProvider Change-Id: I5c622f791b6561c1af080cc455343b15c0fba784 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2017-11-20Bug 522181: [Webkit2] Implement clearSessions() on WebKit2.Roland Grunberg1-0/+107
The WebKit2 implementation of clearSessions() will remove session and non-session (those with an expiry) cookies. The API specifies only the former shall be removed but there is no way to be more selective for now. Tested on WEBKIT1 and WEBKIT2 using the JUnit test provided. The general test approach involves manipulating cookies through javascript. Some additional tests have also been added. test_evaluate_Cookie acts as a sanity check for the correct functioning of 'document.cookie' and the browser.evaluate() functionality. test_get_set_Cookies will eventually help with further implementation of the Cookie API on WEBKIT2. Change-Id: Icc17fe90bf4de38c8d5f0fbb7b5937552ce33d54 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2017-10-10Bug 525807 - Use surefire 2.20.1 for swt testsAlexander Kurtakov1-2/+3
Extract surefire version to property to change the version only in one place in the future. Change-Id: Ifbf8891084e0de990c268503639ce382b3cc2a3d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-10-02Bug 525340 [Gtk][Webkit2] Javascript evaluate fails with "SyntaxError:Leo Ufimtsev1-0/+18
Return statements are only valid inside functions" jUnit test to catch such issues in the future. Change-Id: Ib94b293232a42a3c14748a325ea388a3e37ff88b Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-09-27Bug 525264 - Use foreach in snippets and examplesAlexander Kurtakov2-8/+4
Change-Id: I083db281df708346964203015bd9663bb8e943e1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-21Bug 517264 – Refactor Test_*_Browser (setText issues on win)Leo Ufimtsev1-1/+2
On Windows, setTitle() sometimes seems to trigger multiple title changes, once to "about:blank" and then to the actual desired page. This patch skips over "about:blank" changes. Change-Id: I8b30988e32e23162cf81ea45ea267e1aa39445c7 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-18[Bug 500475] Guard 'doubleClickSelection' with 'doubleClickEnabled'.Arne Deutsch1-0/+34
The field 'doubleClickSelection' might be accessed only in case 'doubleClickEnabled' is true. Otherwise it will be null and NPE is the result. In case 'doubleClickEnabled = false" 'selectionAnchor' will already have the correct value. Added snippet to reproduce bug. Change-Id: Id5743435fd231dc03df8376122495a51b9bcb662 Signed-off-by: Arne Deutsch <arne@idedeluxe.com>

Back to the top