Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-08-01v4705v4705Arun Thondapu1-1/+1
2016-08-01v4705Arun Thondapu3-4/+4
2016-07-29Bug 498165 - [GTK3] Stackoverflow using MeasureItem listenerI20160731-2000Ian Pun1-2/+24
gtk_tree_view_column_cell_get_position() method is signalling into the redererGetPreferredWidthCallback everytime it is run, causing a recursive loop when MeasuredEvent has a listener in GTK3. I've disabled and reinanbled the callback when calling gtk_tree_view_column_cell_get_position() to fix this issue. Tested on GTK3.14 -> GTK3.21+ and GTK2 Change-Id: I7a70bf73df3123414c59b1b1aae2cd8af96db4be Signed-off-by: Ian Pun <ipun@redhat.com>
2016-07-29Bug 496880 - [GTK3] Misaligned text next to radio button in preferenceIan Pun2-8/+13
page gtk_widget_set_align() causes alignment issues when run on a label widget. Changed setting alignments to be done by gtk_label_set_align() instead. Tested on GTK2, GTK3.14, 3.16, 3.18, and 3.2 Change-Id: Ic59634c7239c41b200918b3a8c6f15cf8ae30f4b Signed-off-by: Ian Pun <ipun@redhat.com>
2016-07-29Bug 497551 - Remove the "Missing execution environment" override fromLars Vogel1-1/+0
org.eclipse.swt Change-Id: Iebb91704d2dec9b89d2893e12ca3cb99bf24766e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-07-28Bug 498829 - Load webkit2 so file if webkit 1.x is not availableAlexander Kurtakov2-0/+7
When libwebkitgtk-3.0.so.0 can't be dlopen, try to dlopen libwebkit2gtk to run in webkit2 mode. As the SWT_WEBKIT2 env variable is not set in this case try calling webkit_get_major_version which is Webkit2 function and due to dlsym failing it will always return 0. If result is not 0 libwebkit2gtk so file was loaded as fallback. Change-Id: I5a7f66d2b122a5e2368b20bd6ed76b04e654643c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-28Bug 497923 - [GTK] build.sh bugfixes and improvementsLev Ufimtsev1-12/+12
Removing shell syntax that may not work in older shells to increase portability of the script.
2016-07-28Bug 497923 - [GTK] build.sh bugfixes and improvementsY20160728-1000Alexander Kurtakov1-1/+1
Shell script can't assign variable values in conditional constructs so the double equals is redundant. Moreover it gives a syntax error on older ash/dash or whatever HP-UX builder is using. Change-Id: Ia1916b1ec16a4c1cafc54979336f39cc7065942e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-27Bug 430538 - [GTK3][webkit] Support Custom JavaScript execution inLev Ufimtsev3-17/+26
WebKit2 mode of SWT Browser Fixes to JNI bindings. Now 'execution' of Javascript works. However, currently return value is not supported on Webkit2. To be worked on in future commit. (exec() returns false although it does run JS) Snippet for testing: https://github.com/LeoUfimtsev/swt.snippets/blob/master/swt.crossplatform.snippets/generic/browser/Snip_Browser_Javascript_execute.java Change-Id: Icd4c100da4d7be445f4bcf12be2969d95b7ad8fb Signed-off-by: Lev Ufimtsev <lufimtse@redhat.com>
2016-07-26Bug 498533 - Binding for gtk_adjustment_* shouldn't be dynamic Alexander Kurtakov5-105/+0
Have been added since Gtk 3.14. For dynamic functions compiler warnings about deprecation are missing. Change-Id: I66a4cc6080c69a15df3775fd0a2bc906f533d93c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-26Bug 498528 - Clean build.sh from overrides for no longer builtAlexander Kurtakov1-72/+0
platforms. Namely solaris.x86, solaris.sparc and hpux.ia64_32 Change-Id: I25780f54e4393b39c1ed8de2b006126b1c2c55f6 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-26Bug 497923 - [GTK] build.sh bugfixes and improvementsLev Ufimtsev1-30/+180
Part 2, Multiple new improvements: This is a relatively large patch that adds additional parameter support. Features: * Build Gtk2 and Gtk3 can *both* be built via a single command: ./build.sh -gtk-all install This replaces the tedious process of having to: - In Eclipse, clean project, build Gtk2, - In Eclipse, clean Project, build Gtk3, - manually copy '*.so' files to binary repository. * Help parameter (-h, --help) that explains parameters * Gtk2/Gtk3 can be selected via: "-gtk2, -gtk3"flags * 'echo now print in color. Green for general msgs, red for error * Added error check for binary repository: If user specifies 'install' flag, which normally copies compiled *.so files to binary repo, but folder/binary repo does not exist, then user is warned and the script exits with error. * JAVA_HOME fix: build.sh often fails on fresh systems because JAVA_HOME is not set. JAVA_HOME is usually blank on most systems. The failure usually reads: swt.h:23:17: fatal error: jni.h: No such file or directory compilation terminated. This patch dynamically acquires JAVA_HOME based on the location of the 'java' executable. This works on Fedora 24 and on Ubuntu 16 (and probably on other systems). 1) Check out this patch 2) Clean your binary repository 3) Clean and rebuild your SWT project 4) Navigate to: cd ~/git/eclipse.platform.swt/bundles/org.eclipse.swt/bin/library (NOT the build.sh in .../Eclipse SWT PI/gtk/library/build.sh) 5) run: build.sh -gtk-all install 6) Build should succeed, print should output in color. 7) Navigate to your binary repository, ensure the following are built: git status ... libswt-atk-gtk-4702.so libswt-awt-gtk-4702.so libswt-cairo-gtk-4702.so libswt-glx-gtk-4702.so libswt-gnome-gtk-4702.so libswt-gtk-4702.so libswt-pi-gtk-4702.so libswt-pi3-gtk-4702.so libswt-webkit-gtk-4702.so execute: export JAVA_HOME="" #if not already blank. ./build.sh Before the patch the above should fail with missing 'include jni.h', after patch, everything should compile fine. * Note, I also tested with maven, works fine. I did the following: cd ~/git/eclipse.platform.swt.binaries/bundles/org.eclipse.swt.gtk.linux.x86_64 mvn clean verify -Pbuild-individual-bundles -Dnative=gtk.linux.x86_64 Change-Id: I1b934a7ab95a8e0d00bd8e685db86fbaa7465bdf Signed-off-by: Lev Ufimtsev <lufimtse@redhat.com>
2016-07-26Bug 372607 - Tree should expand/collapse on Arrow_Left/Arrow_RightI20160726-1400Alexander Kurtakov1-1/+7
Define keybinding via css to expand/collapse with arrows. Tested to work on GTK 3.20. Adjusted selector for previous version. Leo: Small adjustment: < Gtk3.20 : gtk-key-bindings >=Gtk3.20 : -gtk-key-bindings Tested: - Works on Gtk3.8, 3.10, ... 3.20, 3.22(beta) - CSS has no effect on <=Gtk3.6 (but 3.6 is 4 years old) Change-Id: Ifa0a0b226e0003d55c44e2e1a4093e09e275fe1e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Signed-off-by: Lev Ufimtsev <lufimtse@redhat.com>
2016-07-26v4704v4704Arun Thondapu1-1/+1
2016-07-26v4704Arun Thondapu3-4/+4
2016-07-26Bug 497068 - [HiDPI][Win32] Header of expandItems does not scaleNiraj Modi1-3/+2
correctly at high DPI Change-Id: Iecb998bb1032d5e40a7751ffed0285480102c618 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2016-07-25Bug 498465 - Remove version checks for Cairo 1.4Alexander Kurtakov1-2/+2
Gtk 2.18 (current min supported version) has a prereq on Cairo 1.6 so this check is useless. Change-Id: Ibeeecd7cff6a7fc79f2a1e6d542fb08c47300819 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-25Bug 498415 - Unify Program to go through gio path where possibleAlexander Kurtakov6-150/+6
SWT having min requirement of GTK 2.18 means GIO is generally available so methods that don't use functions added in later versions can go through it unconditionally. Found while debugging an issue with SWT trying to use gnome-vfs on Gtk 3.20. Program.[execute|getExtensions|launch] now go through gio unconditionally for both Gnome and GIO. Change-Id: If41df0ad869b7ea01c8dd26c69fd146f9c896499 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-24Bug 498403 - Remove unused GTK_IS_SOCKET bindingAlexander Kurtakov4-23/+0
Change-Id: I0564f1756ef9bf7bd505270968ab3ef85ad5e5be Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-24Bug 497962 - Use lambdas where possibleAlexander Kurtakov58-2816/+2179
Enable convert to lambdas and run initial conversion to not interfere with later commits. Slightly smaller and faster code is worth it at SWT level. Change-Id: Ia94b6c25beb09555626eaa455b9e9f43e329f7e6 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-21Bug 479242 - [GTK3] ExpandBar brokenIan Pun1-1/+7
setBounds() calculation was incorrect in GTK3 as it did not need yScroll as a modifier in the parameter. GTK2 works in the old method, so I am keeping it as GTK version conditional call. Change-Id: I52556fc9bf85eeec86b7ef70c61d47e282316ade Signed-off-by: Ian Pun <ipun@redhat.com>
2016-07-21Bug 498062 - [HiDPI] autoScale wrongly applies to Printer devices onY20160721-1000Niraj Modi1-11/+1
Windows Change-Id: I228bc51575927954b28053a903f8dc92e7e214b5 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2016-07-19Bug 495849 - [HiDPI][Win32][GTK] IllegalArgumentException belowNiraj Modi2-2/+2
MarketplaceViewer$4.run (thrown in TextLayout.setWidthInPixels) Change-Id: I95d122722b2dabafe7be1bd184eae28bbe38df0d Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2016-07-19v4703v4703I20160719-0800Arun Thondapu1-1/+1
2016-07-19v4703Arun Thondapu3-4/+4
2016-07-18Bug 443185 - view's toolbar does not cope well with small viewsEugen Neufeld1-0/+10
added checks whether the controls size is bigger then the available size and if so recalculate the size using the corresponding width/height as a hint Change-Id: Ibe36817a3834b936577d9be38072afa6f2fa7c4a Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
2016-07-18Bug 497558: Add minimal Readme.md to org.eclipse.swt for setting the classpathMarkus Keller1-9/+10
2016-07-15Bug 497956 - Parse /usr/share/mime/globs in java landAlexander Kurtakov6-198/+44
Parsing is done via glib apis which is slower (due to many context switches), there are function bindings used only for this code and the code is less readable. Speed of jni based 100 runs in milis: Longest:43 Shortest:0 Average:8 Speed of pure java based 100 runs in milis: Longest:15 Shortest:0 Average:1 Bindings for 4 no longer needed functions dropped too. Change-Id: Id3e65d68869cc394b173120840dd12d95aa96a1f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-15Bug 485120 - IllegalArgumentException in TextLayout.getStyleNiraj Modi1-6/+10
Change-Id: Ide4e4c182bc2e2fe74d3e9ea0274babfa3bb4dcc Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2016-07-15Bug 497923 - [GTK] build.sh - fix OUTPUT_DIR for install target to workLev Ufimtsev1-1/+1
If not set, OUTPUT_DIR (.../../..) is pointing to the location where 'org.eclipse.swt' project is stored. However binaries are in their own git repository in: ../../../../../eclipse.platform.swt.binaries/bundles/ As a result, if you run 'build.sh install', the install target will throw errors due to wrong directory. It looks like in the distant past binaries were kept there, but when they moved to their own repos, the build.sh wasn't updated. With this patch you can do the following after a checkout: cd ~/git/eclipse.platform.swt/bundles/org.eclipse.swt/bin/library ./build.sh clean ./build.sh install This will clean out old *.o *.so files, build new *.so files and correctly copy .so files to the binary folder. Note, for gtk3, you still have to set variable manually: export GTK_VERSION=3.0 before you run the script. Change-Id: Ia89c409c751a852932efe4ee4d99a99cd30c0602 Signed-off-by: Lev Ufimtsev <lufimtse@redhat.com>
2016-07-14Bug 497933 - Remove unreachable code from MozillaAlexander Kurtakov1-26/+2
Workaround for Gtk1.2 Mozilla is useless nowadays. It would be hard to even find one. Don't try to load swt-mozilla-gcc3 as such so file is no longer shipped. Change-Id: I1a7bbb068c43729cdc08afbf8986605ce10832d7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-14Bug 497807 - Use varargs in DropTarget#setTransferY20160714-1000Lars Vogel3-4/+7
Change-Id: I0f29c80b4b18502a072a94e8dee536707cabe039 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-07-14Bug 497558 - Add minimal Readme.md to org.eclipse.swt for setting theLars Vogel1-1/+9
classpath Adds the information that the SWT fragments are also needed. Change-Id: Idd3220eab40acdc35713f2ef8195ddb9c3739281 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-07-13Bug 497444 - [GTK3] Progress indicator not updating in the splash screenAlexander Kurtakov5-12/+23
of Eclipse Instead of sending expose events and flushing better to give GTK the ability to do its work by letting it run iteration in its own even loop. Change-Id: I6940e49d797864bc6e341725d4a6e1e6f2d06305 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-13Bug 497331 - [GTK3] Platform.UI JFace, some tests fail on gtk3Ian Pun2-2/+30
Fixed all JFace errors encountered on my Fedora 24. Previously Tree/Table was returning parent foreground color if foreground == null. Overloaded getContextColor() so that foreground color would be set to COLOR_LIST_FOREGROUND instead of COLOR_WIDGET_FOREGROUND when foreground == null. Change-Id: I0807a80a475ed942c3d72712a72e37d56724a45d Signed-off-by: Ian Pun <ipun@redhat.com>
2016-07-13Bug 433526: [Browser] browser.getText() is throwing exception after Internet ↵Rüdiger Herrmann1-1/+1
Explorer 11 install Asking IE11 to return the page source via getText() may cause an exception if the page is not (fully) loaded yet. The fix is to check if pVarResult is VT_NULL and return an empty string in this case. Change-Id: I80c793834fa6d86e5974423d6b9db909396aaa75 Signed-off-by: Rüdiger Herrmann <ruediger.herrmann@gmx.de>
2016-07-12v4702v4702I20160712-1000Arun Thondapu1-1/+1
2016-07-12v4702Arun Thondapu3-4/+4
2016-07-12Bug 497748 - SWT should increase bundle version in master (4.7) toArun Thondapu1-1/+1
3.106.0.qualifier Change-Id: Ie21e715979c5afc331449aeabe3dd0c10033fe4d Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
2016-07-12Bug 481195 - Update SWT to Java 8I20160712-0800Arun Thondapu1-2/+2
Update buildFragment.xml Change-Id: I59f6bbef9f6032a4327b5771395248f7bf9a8516 Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
2016-07-12Bug 481195 - Update SWT to Java 8Lars Vogel6-9/+9
Change-Id: Ic72803bc574c5a7ef9053eb1139b0b1f5af8a873 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-07-11Bug 497707: [GTK3] Replace deprecated gtk_window_get/set_opacity()Eric Williams7-3/+87
Replace the deprecated function gtk_window_set_opacity() with gtk_widget_set_opacity(). Tested on all versions of GTK3 and GTK2.24. No additional AllNonBrowser JUnit test cases fail on GTK3 or GTK2. Change-Id: I82de5596ab7e956339d104efd367cdaac927229a Signed-off-by: Eric Williams <ericwill@redhat.com>
2016-07-11Bug 497635: Revert fix for Bug 484463Eric Williams1-1/+1
This reverts a fix for Toolbars on GTK3 to allow the line under the Quick Access entry to be visible. As the line is now being removed from Platform UI this fix can be reverted. Testing in progress. Change-Id: I2d1ec4173ebd890dd43090cadfb01b6dfb4e71b5 Signed-off-by: Eric Williams <ericwill@redhat.com>
2016-07-11Bug 496939 - [win32] ctrl+backspace in preferences dialog crashedNiraj Modi2-4/+14
platform Change-Id: Iadab6b5eccd36b54922ee97c920dba10780a4ca0 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2016-07-08Bug 497558 - Add minimal Readme.md to org.eclipse.swt for setting theI20160708-1700Lars Vogel1-0/+23
classpath Change-Id: Ibaa9d30691448859890424ee3639b80b5568097f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-07-07Bug 497525 - Move from charsets string constants to StandardCharsetsAlexander Kurtakov5-132/+30
More readable code as there is no need to catch UnsupportedEncodingException and it's also faster as there is no need for the JVM to lookup the charset based on the string constant passed. Change-Id: I33140d381e42268d51160bfa6906df84533f82d4 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-07-06Bug 495909 - [GTK3.20+]Ian Pun2-21/+128
test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails Referring to bug Bug 461354, I used a topIndex variable to keep track of the top item. Check to see if there has been any scrolling changes done by the user, and if not, return the topIndex variable. We can keep track of scrolling changes by using a cachedAdjustment variable with a currentAdjustment variable grabbed with GTK functions. This optimization has also been adapted on the Table widget. Tested on GTK 2, 3.14, .16, .18, and .20. Change-Id: Ica1bda3c3d23d5cd27b8c4e29963c0f097d778d3 Signed-off-by: Ian Pun <ipun@redhat.com>
2016-07-05v4701v4701dArun Thondapu1-1/+1
2016-07-01v4701v4701cArun Thondapu1-1/+1
2016-07-01Bug 496986 - Remove unsupported platforms project from binariesArun Thondapu1-1/+1
repository Adjust total libraries count in buildSWT.xml after removal of unsupported platform projects Change-Id: I5d3d18764415a6045773ad5f3e726efe37a565f7 Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>

Back to the top