Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2018-09-18Bug 530841: [GTK2] Remove GTK 2.x supportAlexander Kurtakov1-7/+1
Remove code trying to load webkit1 gtk2 bindings and warning if it's missing. Change-Id: Ibb591da1ba2677f96014bc2444ac26b3737c6687 Signed-off-by: Alexander Kurtakov <>
2018-08-21Bug 530393 - EPL 2.0 update for SWT bundlesLars Vogel25-75/+150
Update all sources files except .exsd files, Java pref files and pom files Staged via: git grep --name-only 'Eclipse Public License 2.0' > input.txt Manually added \ before the spaces in the directories with spaces cat input.txt | xargs git add Regex used: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/\/legal\/epl-v10.html/\1\2https:\/\/\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: If93c95c1ce4c7ee8345dea43e7b9ae71f5fa4739 Signed-off-by: Lars Vogel <>
2018-04-30Bug 529009 - Embedded Browser does not forward '<' character to client codeTom Schindl1-0/+1
2018-04-23Bug 533677 - [win32] calling Browser#refresh does not callLars Vogel1-1/+0
ProgressListener#completed Change-Id: Ic600baac1a96c70105fec1e871e5a881191af945 Signed-off-by: Lars Vogel <>
2018-04-11Bug 488431 - Provide SWT/GTK3 port on WindowsRolf Theunissen1-0/+3
Graceful errors for features not implemented in SWT/GTK-Win32 Change-Id: Ib54d2dbba9f4aac89b2edb1ff135e0e28d39f7d8 Signed-off-by: Rolf Theunissen <>
2018-03-28Bug 531097 - [Win32] Remove support for Windows before VistaNikita Nemkin2-41/+31
Remove code paths specific to WinCE, Win9x, WinNT4, Win2k, WinXP. Remove uses of obsolete flag=no_wince JNI annotation. The following OS variables indicate dead code: * WIN32_VERSION is awlays >= 6.0 * COMCTL32_VERSION is always 6.10; * SHELL32_VERSION is always >= 6.0; * IsWinNT and IsUnicode are always true; * IsWin32s, IsWin95, IsWinCE, IsPPC, IsHPC, IsSP are always false. Change-Id: I4e700a89b22cd879e7c46f1493115a77e2ade1c9 Signed-off-by: Nikita Nemkin <>
2018-02-24Bug 531633 - Replace usage of System.getProperty("file.separator")Karsten Thoms1-1/+2
Change-Id: I609d4b7e6415a113e2afcf790cc72d9a7c6199c0 Signed-off-by: Karsten Thoms <>
2018-01-31Bug 530459 – Improve error message "Embedded browser not available"Leo Ufimtsev1-2/+24
Enhance the error message. Change-Id: I278fd09e0d6004de781dc8c0c22ffba25a6b357d Signed-off-by: Leo Ufimtsev <>
2018-01-08Bug 519334 – [Browser] should throw a meaningful error message if WebkitLeo Ufimtsev1-4/+4
is not available. Prints something nice like: Exception in thread "main" org.eclipse.swt.SWTError: No more handles because no underlying browser available. Linux:Webkitgtk(1 or 2), Mac:Webkit, Windows:Webkit or IE at org.eclipse.swt.SWT.error( at org.eclipse.swt.browser.Browser.<init>( at widget.browser.snip_browser_eventListeners.main( Change-Id: I5f2586b6b5b75930ae04351e10be3670006601b3 Signed-off-by: Leo Ufimtsev <>
2018-01-07Bug 529494 - Convert to StringBuilderAlexander Kurtakov2-9/+9
Change-Id: Ic959ed6d7ae7aa50da85837105570b2b69ae66d3 Signed-off-by: Alexander Kurtakov <>
2017-12-05Bug 527564 [Webkit2] Deadlock due to blocking javascript execution in aLeo Ufimtsev1-7/+13
synchronous callback from webkit2 Patchset 1: - Implementing nonBlocking javascript execution logic to prevent deadlocks. (In some cases we don't need the return values anyway). Patchset 2: - Implement timeout logic, to prevent infinite loops in javascript locking SWT UI and also to unblock deadlocks (and allow users to report the issue). Change-Id: I659fdde5bd06c7188efedfe55ef64d797826e5dd Signed-off-by: Leo Ufimtsev <>
2017-12-01Bug 510905 [Webkit2] BrowserFunction with return value back toLeo Ufimtsev1-1/+1
Javascript (PRIOR TO MERGING, SWT BINARY REPO NEEDS TO BE PATCHED) Webkit2 moved it's webprocess into a separate process. For javascript to call a function, it needs to do so via the separate process. To interact with the separate process, we need to implement a webextension, which is a separate '.so' file loaded at run time. The extension needs to reside in it's own folder otherwise webkit will try to load the other .so files as extensions. (See changes). Communication between the extension and the main process is done via a gdbus channel. Javascript/Java types are packaged into GVariants and transmitted via gdbus. Compilation of the webextension requires webkit2gtk package to be present on build servers. Tests: - All jUnits pass - SWT Snippet (307) that use BrowserFunction work. - Attached local snippet can be used to test sending various paramaters over gdbus and receiving them back prints to main webview. - Child eclipse works fine with the patch. - Afaik, no known error/warnings are produced. (If there are, let me know). This might break 32bit build of SWT though, not tested on 32 bit. Patch set log: -------------- Patchset 6: - Passing webview as string in javascript function. Patchset 8: - Implemented dynamic gdbus bindigs on SWT/Java side. Works. (fairly large patch) Patchset 9: - Implemented gdbus bindings on client side, such that it can reach server. (working) Patchset 10: - Added GVariant conversion functions on SWT side. Works. - Moved code out of to reside only in WebKitGTK Patchset 11: - Figured out how to provide return value as an object array. Added snippet to show how to provide a string return value. (working) Patchset 12: - Passed webview pointer, index and token to Java. - Fixed typo in type definition. > (Working) Patchset 13: - Now passing javascript arguments along through gdbus to java. > (Working) Patchset 14: (Week 46) - Implemented support for 'null'. (use byte as magic number). - Found that there is a bug in how I deal with return value in gdbus, gdbus returns an array (always). Need to return first item in array. Patchset 15: (Week 46) - Implemented proper return value of java to javascript. - Found that js calls with no paramaters call() fail, need to fix. Patchset 16: (Week 46) - Implemented support for empty arrays (including calls without args). - Code tidy. - Found that I need to implement input argument verification from JS call and from java code ran by user, otherwise gdbus can crash. Patchset 17: (Week 46) - Implement checking of user-input arguments, to ensure it won't break gdbus connection. Patchset 18: (Week 46) - Implemented checking of return value from userfunction, so bad return value doesn't break gdbus. - Code tidy/polish. - Need to implement lazy loading of gdbus, only init gdbus for the first function that we instantiate. - Also still getting warning when loading webkit library. Patchset 19: [Week 47] - Implemented lazy loading of gdbus, to only load when needed. - wrapped getPID() into lock, otherwise had strange debug/execution behaviour. Patchset 20: [Week 47] - Two BrowserInstances with Two BrowserFunctions seem to hang (snippet), (need to investigate) Patchset 21: [W47] - Removed redundant print statements. Cleaned up code. Patchset 22: [W47] - Moved Webkit extension initialization logic into a callback, so that it's guaranteed to be loaded at the most optimal time. (All jUnits pass). Patchset 23: [W47] - Removed redundant println. Patchset 24: [W47] - Implemented mechanism by which webextension is compiled and loaded from a folder. (This needs a patch to binary project's Patchset 25: [W47] - Code tidy. Patch complete (ish). Patchset 26: [W47] - forgot to add files to patchset 25. Patchset 27: [W47] - Verified that Browser widget will continue to work if webextension fails to load. - Added relevant warnings. Patchset 28: - Minor update on SWT_LIB_VERSIONS. Change-Id: Iccfc48bc78774ac4120aafd976186381f247c562 Signed-off-by: Leo Ufimtsev <>
2017-09-27Bug 525260 - Use foreach to iterate BrowserFuncionsAlexander Kurtakov1-4/+1
Slightly readable code. Change-Id: I93093d501f6a190ee49b2ecf034fa864166927bc Signed-off-by: Alexander Kurtakov <>
2017-09-27Bug 525255 - Enable indirect static usage warningsAlexander Kurtakov2-29/+29
Cover win32. Change-Id: Ifa0f68487fbcd57b84603c08ce5c388e74763706 Signed-off-by: Alexander Kurtakov <>
2017-09-25Bug 522718 - Remove mozilla leftoversAlexander Kurtakov1-15/+5
Change-Id: I91e21254f9bef6fa893cbbbed24d7dc3957745e2 Signed-off-by: Alexander Kurtakov <>
2017-08-16Bug 521024 - [api] Provide helpers to use lambda expressions for BrowserAlexander Kurtakov6-8/+131
listeners Add helper methods. Change-Id: I373cf73c439b0c68e3c8602bc3a99fcbe3a4338a Signed-off-by: Alexander Kurtakov <>
2017-07-10Bug 519177 – [All] update Browser.getText() javadoc to reflect platformLeo Ufimtsev1-1/+6
specific behavior of returned html (ex Windows) Change-Id: I6256b3ac8b7ce2a56c4125bd59aadce805fe1ed2 Signed-off-by: Leo Ufimtsev <>
2017-06-30Bug 518542 - Remove XULRunner related code from SWT source repositoryArun Thondapu1-1/+1
Fix minor typo in Javadoc. Change-Id: I3a51a248cbec0527835d9588f4891eb425278e8f Signed-off-by: Arun Thondapu <>
2017-06-22Bug 518542: Remove XULRunner related code from SWT source repositoryMarkus Keller2-3/+0
removed unused imports
2017-06-22Bug 518542: Remove XULRunner related code from SWT source repositoryI20170622-0950Lakshmi Shanmugam1-1/+1
Added missing $NON-NLS-1$ from previous commit Change-Id: I17ae0003e3dadc7978470b8aa67da776bb0ee8d6
2017-06-22Bug 518542: Remove XULRunner related code from SWT source repositoryLakshmi Shanmugam4-34/+23
Deprecated SWT.MOZILLA & Browser.getWebBrowser. SWT.MOZILLA style will be ignored in the code. Change-Id: Ib69683f5526e21390f138d1f39275e2428046f93
2017-03-29Bug 514408: Test_OpenWindowListener_evaluateInCallback() opens IE windowMarkus Keller1-5/+5
2017-02-07Bug 508217 Implement webkit2 support for browser function Leo Ufimtsev1-2/+19
(Part 1: JavaScript to call Java) This implements Browser.function() on webkit2. Current implementation allows javascript to reach java, but java doesn't provide a return vaulue in the callback. For detailed architecture changes, see: Webkit2JavaCallback() inside In short, in webkit1 an 'external' object was registered and callJava was a property of this object. In webkit2, 'external' object is no longer used and instead a callback/signal is registered/connected. With this patch, the following jUnits pass: test_BrowserFunction_callback test_BrowserFunction_callback_with_integer test_BrowserFunction_callback_with_boolean test_BrowserFunction_callback_with_String test_BrowserFunction_callback_with_multipleValues testBrowser4. The following does not: test_BrowserFunction_callback_with_javaReturningInt Patch set 4: - I noticed that after a page re-load, webkit2 custom functions did not work. This is because the page-reload mechanism has changed (Bg:510972) but in the ported webkit2 mechanism functions were not re-registered). - Added code to re-register custom functions after page reload. Patch set 7: - Removed 'protected' modifier. - Moved comments around. Change-Id: I94549ed306e0095c735d18389b55a36923c5ec08 Signed-off-by: Leo Ufimtsev <>
2016-12-13Revert "Bug 483642 - Retire internal SWTEventListener and SWTEventObject class"Alexander Kurtakov8-16/+16
This reverts commit 79f0e151d1e7b1a53c158263008354d8e2aadce6. There are cases when child eclipse can not be run with this patch. Reverting to be sure to not break things badly. Change-Id: Icd0b6c3f6f063ded2a57c19e2fe3ef2f222689e3
2016-12-13Bug 483642 - Retire internal SWTEventListener and SWTEventObject classFabian Pfaff8-16/+16
* removes SWTEventListener interface * uses EventListener instead * removes SWTEventObject class * uses EventObject instead Change-Id: I1e882a0b288fb3adf3243db93c319f22320e0f3e Signed-off-by: Lars Vogel <> Signed-off-by: Fabian Pfaff <>
2016-09-29Bug 502576 - Mark typed SWTEventListener @FunctionalInterface if theyAlexander Kurtakov5-10/+15
are functional interfaces Handle org.eclipse.swt.browser and org.eclipse.swt.custom packages. Change-Id: Icd149505e57133470785db7be83a4d52cce75e90 Signed-off-by: Alexander Kurtakov <>
2016-07-24Bug 497962 - Use lambdas where possibleAlexander Kurtakov1-647/+615
Enable convert to lambdas and run initial conversion to not interfere with later commits. Slightly smaller and faster code is worth it at SWT level. Change-Id: Ia94b6c25beb09555626eaa455b9e9f43e329f7e6 Signed-off-by: Alexander Kurtakov <>
2016-07-13Bug 433526: [Browser] browser.getText() is throwing exception after Internet ↵Rüdiger Herrmann1-1/+1
Explorer 11 install Asking IE11 to return the page source via getText() may cause an exception if the page is not (fully) loaded yet. The fix is to check if pVarResult is VT_NULL and return an empty string in this case. Change-Id: I80c793834fa6d86e5974423d6b9db909396aaa75 Signed-off-by: Rüdiger Herrmann <>
2016-06-27Bug 493666 - [win32][HiDPI] Images in Browser widget not scaledNiraj Modi2-2/+3
Change-Id: I144a8f82898e23cc205ad323d1ee4516cae5ee17 Signed-off-by: Niraj Modi <>
2016-05-25Bug 476043 - Fix crash related to ActiveX Filtering in IE11Sebastian Ratz1-1/+1
The IInternetSecurityManager::ProcessUrlAction API specification states that pContext can be NULL. This needs to be checked before trying to get the GUID. Change-Id: I4cb76929b0ff89f8616cc0b655fe56edcee11f4a Signed-off-by: Sebastian Ratz <>
2016-03-12Bug 479614 - [Graphics] HiDPI support for eclipse platformNiraj Modi2-1/+3
- Windows changes Change-Id: I9cd0004d57a2a3a2a956a71de91b10af560c08a7 Signed-off-by: Niraj Modi <>
2016-02-10Bug 487556 - Remove redundant type parematers Alexander Kurtakov1-4/+4
Useless now that SWT requires Java 1.7. Change-Id: I333df3b7f2d706a66ba4e959ec508a762cac0c1d Signed-off-by: Alexander Kurtakov <>
2016-02-10Bug 483640 - Add missing annotations to SWT after the move to Java 7Alexander Kurtakov4-4/+20
Add missing @Override annotation for interface methods. Change-Id: Ibce185467807acd2dc5e6b71fda643a3947f60eb Signed-off-by: Alexander Kurtakov <>
2016-01-07Bug 485367 - cleaned trailing spaces in swt (common)Andrey Loskutov19-233/+233
Change-Id: I06f169ff771ea37dbeb35ba11fb988a4b1665c5d Signed-off-by: Andrey Loskutov <>
2016-01-07Bug 485367 - cleaned trailing spaces in swt (win32)Andrey Loskutov2-50/+50
Change-Id: I47413fc0f50677957d3e3269dbaca97413b56d30 Signed-off-by: Andrey Loskutov <>
2015-11-23Bug 463924 - Hashtable -> HashMap, MapJacek Sieka3-27/+24
Convert all Hashtable usages to HashMap, Map Change-Id: Ia95db6ba3a82d6f4eaed6abef4c4381eb43d886c Signed-off-by: Jacek Sieka <>
2015-11-02Bug 462633: Enable save actions for annotationsMarkus Keller2-0/+76
Added missing @Override/@Deprecated in win32
2015-10-15Bug 465822 - [IE]BrowserFunctions doesn't work properly with SWT.NONENiraj Modi1-0/+10
Browser on Windows Change-Id: I04b6427fea18fa85e7bdfd8ff9d78cb7c242f6dc Signed-off-by: Niraj Modi <>
2015-10-08Bug 479313 - [Win32][Browser] NullPointerException in IE.executeNiraj Modi1-1/+6
( Change-Id: Icfdd3a56d10ed909fbbd5b68282fedf4cac30b89 Signed-off-by: Niraj Modi <>
2015-07-31Bug 458863 - [Common] Replace Vector with ArrayList and friendsJacek Sieka1-3/+4
Vector -> List, ArrayList Change-Id: I888585ff319d4591362e302a939107a9950ecfd0 Signed-off-by: Jacek Sieka <>
2015-05-13Bug 465757 - When browser is using XULRunner, the browser.evaluateLakshmi Shanmugam1-13/+14
function is always returning null. -Modified evaluate(script) to use evaluate(script, false) so that evaluate executes in the context of the current document. -Modified javadoc of evaluate(script,trusted) -fixed a typo on
2015-03-24Bug 462985 - Cleanup carbon leftoversAlexander Kurtakov1-24/+0
Browser and awt bridge have survived. Change-Id: I7fdaeca5b4d8f5869511fbd0137adb721321f7ab Signed-off-by: Alexander Kurtakov <>
2015-03-24Bug 455263 - Retire Eclipse SWT/wpfAlexander Kurtakov4-544/+0
Remove wpf browser/program and build support. Change-Id: I7790f5bb70665666671c6b8dc5880b46000a7a9a Signed-off-by: Alexander Kurtakov <>
2015-03-18Bug 429739 - Permission denied to access property '' Lakshmi Shanmugam2-7/+8
Refactoring. Retained existing behavior of evaluate.
2015-03-18Bug 429739 - Permission denied to access property ''Lakshmi Shanmugam2-1/+56
Move API to browser class
2015-02-26Bug 460943 - Do not suppress warningsAlexander Kurtakov1-5/+4
Remove @SuppressWarnings("rawtypes", "unchecked") and properly fix the warnings. Change-Id: I7d7ab2b47f53906c5dc1cc1646a1960bcdf97fcb Signed-off-by: Alexander Kurtakov <>
2015-02-05Bug 458863 - Replace Vector with ArrayList where appropriateJacek Sieka1-6/+4
Change-Id: If2051b9bc4f93f539e7ee62c5e85de0c6c229211 Signed-off-by: Jacek Sieka <>
2014-11-24Bug 342145 - Embedded IE browser shows webpages in Quirks(IE5)-ModeNiraj Modi1-2/+22
Change-Id: I7b901dca474bace8fe4d7352ee90a8f425be17e0 Signed-off-by: Niraj Modi <>
2014-09-22Bug 444725 - Remove carbon support from swtAlexander Kurtakov1-1/+0
Remaining parts in the code and build scripts. Change-Id: Idabe4c08e44998a668cb319efd53aeadc7d4263a Signed-off-by: Alexander Kurtakov <>
2014-09-22Bug 444715 - Remove photon support from swtAlexander Kurtakov2-491/+0
Remove implementation. Change-Id: Icddf692fd5455326e2b1d16721da2a7566c01890 Signed-off-by: Alexander Kurtakov <>

Back to the top