Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2020-01-25Bug 559458 - Add Cursors section to ControlExample Colors tabNikita Nemkin1-6/+60
Not making a separate tab because there are too many already and cursors don't need much space. Change-Id: Iab087a95a6f8f4b404b7f1c1f6b0c4f0bfca4a82 Signed-off-by: Nikita Nemkin <>
2020-01-25Bug 558501 - [Win32] Reduce usage of trycatch JNI flagNikita Nemkin4-33/+5
trycatch swallows all native exceptions, including invalid memory access, resulting in unpredictable memory corruption. Note: trycatch flag was added in Bug 329518 (8118a2195207) to cover some mysterious crashes in third-party code. Change-Id: I86371a81bef75b718a55e671b3c7d2c292b4ab91 Signed-off-by: Nikita Nemkin <>
2020-01-24Bug 559529 - Remove FontMetrics.gtk_newAlexander Kurtakov2-23/+7
Despite its name it has nothing gtk specific in it and in reality it acts like a constructor so better to not pollute the public namespace that way. Change-Id: I1d18e779546437033e6fa57b4d80f735d1675adc Signed-off-by: Alexander Kurtakov <>
2020-01-24v4932r13v4932r13Eclipse Releng Bot1-1/+1
2020-01-24v4932r13Eclipse Releng Bot2-3/+3
2020-01-24Bug 547195 - [Cocoa] Clean up .bridgesupport.extrasNikita Nemkin16-173/+193
* Remove all uses of swt_alloc, swt_param_name, swt_param_cast, swt_java_type64. * Remove redundant uses of swt_java_type. * Fix incorrect swt_java_type in CGContextSetLineDash. * Migrate from obsolete protocol names to modern equivalents. Change-Id: I0d4a410c06fd3bb1443f6e434190b9369a035e73 Signed-off-by: Nikita Nemkin <>
2020-01-24Bug 547194 - [Cocoa] Remove unused JNI functions and constantsNikita Nemkin73-4327/+161
Additionally, migrate a few manual JNI definitions to MacGenerator. Change-Id: I639adbe060cd4d1d072d3eacbf4b537c1e7439dc Signed-off-by: Nikita Nemkin <>
2020-01-24v4932r12v4932r12bEclipse Releng Bot1-1/+1
2020-01-24Bug 512629 - Move unstable fullscreen test to manual testsPaul Pazderski2-103/+157
Change-Id: I24cc721bcbe0813c23cdce874b7188ecc0ced0ca Signed-off-by: Paul Pazderski <>
2020-01-23Bug 512629 - [Win32] Setting shell to full-screen before open stops inPaul Pazderski2-3/+106
an intermediate-state Change-Id: I8237d39a295b0629e9705f0ec1d41b53b7ffe842 Signed-off-by: Paul Pazderski <>
2020-01-22Bug 559399 - [GTK] Remove unused functions, structures, constantsNikita Nemkin21-1948/+8
Change-Id: Iddd795f61c2d7d834719d70f72cab541a287c214 Signed-off-by: Nikita Nemkin <>
2020-01-22Bug 559376 - [Win32] Remove obsolete workarounds for IBM JVM bugsNikita Nemkin3-72/+3
IBM JVM 1.3.1 and IBM JVM 1.6 code generation bugs can't be reproduced with J9-based OpenJDK 8. Change-Id: I844ea30784feedc1ccfa5f904ecdea4860c6e702 Signed-off-by: Nikita Nemkin <>
2020-01-21Bug 559378 - [Win32] Remove traces of pre-WinXP codeNikita Nemkin2-35/+0
Remove workaround for COMCTL version 5 (Bug 98087) and some comments. Change-Id: Ic30d600d900de7775852aa652c22f26df2293981 Signed-off-by: Nikita Nemkin <>
2020-01-21Bug 546743 - [GTK] Remove Platform.lock (Part 2)Nikita Nemkin15-617/+409
Clean up after automated locking function removal: * Remove duplicate @category dbus comments in * Fix Java errors due to renamed native functions. * Fix C errors due to mismatched NO_* macro signtures (in os.h, cairo.h). Fix the last uses of Platform.lock in Display.sleep and Remove the Platform.lock field itself and the Lock implementation. Change-Id: Ie892cc90f50ae37697a2788e1ee60012e5b1304e Signed-off-by: Nikita Nemkin <>
2020-01-21Bug 546743 - [GTK] Remove Platform.lock (Part 1)Nikita Nemkin23-25036/+12498
GTK3 thread safety requirements are similar to Win32/Cocoa and agree with restrictions posed by public SWT API. Blanket lock on every platform function is unnecessary. Part 1. Automatically remove all locking wrapper functions by running this regex replacement in the IDE: Search: (?s)(\s*public static final native\s+)(\w+(?: /\*long\*/)?)\s+_(\w+)\s*([^;]+;)(?:(\s*/\*)\*?(.*?\*/)|(\s*//[^\r\n]*))?\s*public static(?: final)?\s+\2\s+\3[^{]+\{\s*(?://[^\r\n]*)?\s*lock\.lock\(\);\s*try \{\s*(?:return\s+)?_\3[^;]+;?\s*\}\s*finally \{\s*lock\.unlock\(\);\s*\}\s*\} Replace: $5$6$7$1$2 $3$4 1566 locking wrappers are removed. Build errors introduced in this patch (mostly due to native function renaming) are fixed in Part 2. Change-Id: I189d6b3858d9a8f5cc7dfa02f2dd3b0d0edfb93f Signed-off-by: Nikita Nemkin <>
2020-01-21Bug 559362 - [Cocoa] Small fixes to string constant usageNikita Nemkin6-25/+15
* Use wrapped object constants instead of raw long constants. * Use isEqual instead of isEqualTo. Change-Id: Ic81c561ca295b9ab5ad4e33ce956543eb6676280 Signed-off-by: Nikita Nemkin <>
2020-01-20Bug 551724 - [Win32] Most dead key combinations no longer workNikita Nemkin2-16/+9
On Windows 10 build 18362 and later, PeekMessage fails unexpectedly when looking for WM_DEADCHAR. The fix is to remove filter flags OS.PM_QS_INPUT and OS.PM_QS_POSTMESSAGE which are redundant anyway. This patch also fixes Bug 550059 and supersedes the fix for Bug 219750. Change-Id: I1b38c536d70720a973314baccbea10a247e1a6c0 Signed-off-by: Nikita Nemkin <>
2020-01-20Bug 310387 - copying new Image(Device device, String filename) canSravan Kumar Lakkimsetti1-1/+40
result in black background (was: Black background for icons in Annotations Preference Page) Change-Id: If6ee668b438adea349fb78bf08143fa737318f6f Signed-off-by: Sravan Kumar Lakkimsetti <>
2020-01-20Bug 558860 - GESTURE_BEGIN event not sent, event.magnification alwaysLakshmi Shanmugam9-64/+26
zero beginGestureWithEvent and endGestureWithEvent are not called since 10.11. Check the NSEvent.phase property to detect Gesture begin and Gesture end events. Change-Id: Id3ac3024b841ce6ced0fae354408ddcfc904ffe1
2020-01-20Bug 551319 - ToolItem.setDisabledImage() JUnit test failureLakshmi Shanmugam1-2/+0
Remove OS check as test passes on Windows and Cocoa now. Change-Id: Icd56941fcbaa866ab558309c9af429f4275cf50e
2020-01-17Bug 559298 - skipAPIAnalysis is enabled for some platform bundlesAndrey Loskutov1-1/+0
Change-Id: I804c215a529293d753512ebbc6327ef73e933575 Signed-off-by: Andrey Loskutov <>
2020-01-17Bug 543404 - [Win32][SWT_AWT] An illegal reflective access operationNikita Nemkin1-10/+2
Replace two inaccessible reflective calls with JNI. Previous fix (Bug 482318) appears to have missed them. Change-Id: Id3c2ea9c5842810e91d965d35453d754032d6b91 Signed-off-by: Nikita Nemkin <>
2020-01-16Bug 559230 - [Regression] Opening a file is extremely slowPaul Pazderski3-103/+52
Revert "Bug 343086 - [StyledText] Horizontal scroll bar vanishes when line gets shorter" This reverts commit 218f92e3b9fda0f48cc2d06401f180d5098121e3. Revert "Bug 553377 - StyledTextRenderer max width can be invalid" This reverts commit 795aeac59686647adf9dd0ea194583482609ac01. Change-Id: I67c865393678af4ff777e8b7724e24ed3dfa8703 Signed-off-by: Paul Pazderski <>
2020-01-15Bug 389398 - [Javadoc] SWT.END should mention GridLayout alignmentPaul Pazderski1-2/+5
Additional: SWT.BEGINNING and SWT.FILL are used also for horizontal alignment. Change-Id: If8bd6249b550e2c92c2d0afef8964fbc4e48192e Signed-off-by: Paul Pazderski <>
2020-01-14Bug 559057 - [JNI] Remove traces of 32-bit supportNikita Nemkin16-811/+609
Remove uses of 32-bit compatibility definitions like jintLong. Change-Id: Ibdff499435f8cb3de4ea7c3adba153bb7bbbabbe Signed-off-by: Nikita Nemkin <>
2020-01-14Remove webkit1 notes from gtk webkit port.Alexander Kurtakov1-23/+3
Change-Id: I6280021ad7a18205966fb8cc5f474686704da087 Signed-off-by: Alexander Kurtakov <>
2020-01-14Bug 553657 - [GTK] Checkbox hard to see on active partPaul Pazderski2-1/+90
Some themes use checkbox and toggle where the foreground (e.g. for the check mark) is equal or very similar to the themes background. In such cases we must not inherit the parents background. Change-Id: Idf18b3b52558f9bb1f4dfaf70e2d8fc5fb3251be Signed-off-by: Paul Pazderski <>
2020-01-14Bug 552822 - [Cocoa] Fix cursor for ICON_SEARCH/CANCEL in Text widgetNikita Nemkin4-4/+20
Wrong cursor is a side-effect of bug 358022 fix. The fix is obsolete since 10.14, put it behind the version check. Change-Id: I6bd0faa52e5c1f3449984f60b7cbe171e056f0ea Signed-off-by: Nikita Nemkin <>
2020-01-13Bug 552822 - [Win32] Fix cursor for ICON_SEARCH/CANCEL in Text widgetNikita Nemkin1-28/+65
Refactor ICON_SEARCH/CANCEL emulation, add proper cursor handling. Change-Id: I3202b8a1f3e03af7670470013feba1b15f11b207 Signed-off-by: Nikita Nemkin <>
2020-01-10Bug 343086 - [StyledText] Horizontal scroll bar vanishes when line getsPaul Pazderski2-1/+10
shorter StyledText did not reclaim free horizontal space on line split. Change-Id: I32840d30ecfa6f430a9b85e3e2a986b1ed50819a Signed-off-by: Paul Pazderski <>
2020-01-10Run SWT tests with Surefire 3.0.0-M4Alexander Kurtakov1-1/+1
Change-Id: Ie3a2a12c799d722371b7ff2db1d07a4265b54908 Signed-off-by: Alexander Kurtakov <>
2020-01-10Use System.lineSeparator()Alexander Kurtakov9-39/+39
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: I89bc3b8490f47498e161736a9ab5756fd88835a9 Signed-off-by: Alexander Kurtakov <>

Back to the top