Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-08-03v4936r14v4936r14I20200803-1800Eclipse Releng Bot1-1/+1
2020-08-03v4936r14Eclipse Releng Bot3-4/+4
2020-08-03Bug 564809 - [GTK4] Adapt to GdkEvent API changesPaul D'Pong30-302/+901
Multiple functions have been renamed and their signatures changed. Converted them accordingly and placed platform filter checks. Grouped the gdk event functions together in GDK.java for readability and so it will be easier to remove GTK3 function in the future. Functions changed: gdk_event_get_button -> gdk_button_event_get_button gdk_event_get_crossing_mode -> gdk_crossing_event_get_mode gdk_event_get_focus_in -> gdk_focus_event_get_in gdk_event_get_keycode -> gdk_key_event_get_keycode gdk_event_get_keyval -> gdk_key_event_get_keyval gdk_event_get_scroll_deltas -> gdk_scroll_event_get_deltas gdk_event_get_scroll_direction -> gdk_scroll_event_get_direction gdk_event_get_state -> gdk_event_get_modifier_state Added: gdk_event_ref gdk_event_unref gdk_key_event_get_layout to replace gdk_event_get_key_group gdk_keyval_name to replace getting the string directly from GtkKeyEvent Change-Id: I27de5cb6b6dbccd21d3e8d9d953763e0c1f5dbc6 Signed-off-by: Paul D'Pong <sdamrong@redhat.com>
2020-08-03Bug 565488 - [GTK4] GtkMenu, GtkMenuBar and GtkMenuItem removalPaul D'Pong9-137/+325
Removed: gtk_menu_bar_new gtk_menu_new gtk_menu_popdown gtk_menu_item_new gtk_menu_item_set_submenu gtk_menu_item_get_submenu gtk_menu_shell_insert gtk_menu_shell_set_take_focus gtk_menu_shell_deactivate gtk_menu_separator_menu_item_new gtk_radio_menu_item_new gtk_radio_menu_item_get_group gtk_check_menu_item_new gtk_check_menu_item_set_active gtk_check_menu_item_get_active Added: gtk_popover_popdown gtk_popover_menu_bar_new_from_model gtk_popover_menu_new_from_model g_menu_new (replaces all the varients, have to set the correct actions to get the desired style, need to test when everything compiles) g_menu_insert g_menu_item_set_submenu Change-Id: Iffc63dc269a5670df4313be07c5fc8c0b8a2cc22
2020-07-31v4936r13v4936r13fY20200801-1200I20200803-0210I20200801-1800I20200801-0010I20200731-2040I20200731-1800I20200731-0520Eclipse Releng Bot1-1/+1
2020-07-31Bug 564453 - Test failures in SWT on MacLakshmi Shanmugam2-5/+22
Added screenshot for the failing tree test. Increased count for Table.test_Virtual() Change-Id: I763b7abf514ca0f868e66e2541780d8975064085 Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
2020-07-30v4936r13v4936r13eI20200730-1800Eclipse Releng Bot1-1/+1
2020-07-30Use for-each loop in TaskBarLars Vogel1-4/+2
Change-Id: I0cbae0d644e4d04760d888dc31d7fc4ddc70b298 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-07-29v4936r13v4936r13dY20200729-1200I20200729-1800Eclipse Releng Bot1-1/+1
2020-07-29Bug 565525 - [macOS] Table: after dragging a selected line, Cmd+clickLakshmi Shanmugam1-21/+25
removes selection Clear selectedRowIndex = -1 when drag ends. Applied the fix from Table to Tree Change-Id: Ia2db075a03e15ad18fa8fa5f754ea6b05cb84c10
2020-07-29v4936r13v4936r13cY20200729-0630Eclipse Releng Bot1-1/+1
2020-07-28Bug 558937 - NPE in Smart Import Wizard pressing Directory... buttonThomas Singer1-0/+3
Change-Id: I1aa2d1480f8eda5f1c08cc9f49c349dca290ff63 Signed-off-by: Thomas Singer <ts-swt@syntevo.com>
2020-07-28v4936r13v4936r13bY20200728-0600I20200729-0120I20200728-1800I20200728-1120Eclipse Releng Bot1-1/+1
2020-07-28Bug 565089 - [Win32] Table.selectAll quickly reverts back to previous selectionAlexandr Miloslavskiy2-10/+69
The problem happens when clicking a selected item in unfocused Table and then doing something like Ctrl+A quickly to change Table's selection. The problem was caused by early `SetFocus()` which occurred before ListView was able to process the mouse event. This caused ListView to think that the click occurred in a focused control, which changed the way it's handled. When a selected item is clicked in focused ListView, it starts a 500ms timer (WM_TIMER with ID=42). The timer's purpose is to distinguish between double-click and click-to-edit. When timer hits, it begins inplace label editing (see `LVS_EDITLABELS`). For ListView without this style (like in SWT), it merely resets selection to the item. It seems that the problem that `SetFocus()` was solving is long gone. Afterall, this code is there since the very first SWT commit! I tried the following test: 1) Use SWT ControlExample, Table page 2) Click an item 3) Press keyboard arrow down, so that item gets input focus - it seems that Windows doesn't show focus until keyboard was used. 4) Click some other control 5) Click selected item in Table which is now not focused 6) Item shows input focus rectangle again. This means that the desired behavior, as I understand it from code comment, is working even without `SetFocus()`. Even if I'm missing something, and focus rectangle will indeed be lost sometimes, this is a very marginal feature compared to (1) the problem of resetting selection and (2) having one more hack in SWT. Also, it's closer to Windows behavior and there's no reason why SWT should have its own logic unless this gives some value to users. Change-Id: I626f2520eb5b5154b2b7b8d7825c228af1ef3945 Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
2020-07-28Bug 565525 - [macOS] Table: after dragging a selected line, Cmd+click ↵Thomas Singer1-16/+20
removes selection Change-Id: Idd7e21149ee49fdf90ec09975d44bace1876896e Signed-off-by: Thomas Singer <ts-swt@syntevo.com>
2020-07-27v4936r13v4936r13aI20200727-1800Eclipse Releng Bot1-1/+1
2020-07-27Bug 565426 - [Win32] Remove unused parameters from Widget.sendMouseEvent()Alexandr Miloslavskiy5-42/+42
The parameters are not used for many years. `msg` hasn't been used since first commit. `wParam` was last used before Bug 24393 (2002-10-09) Change-Id: I6336afb259a04dee77a5faf2f6a4190b80e8207c Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
2020-07-26v4936r13v4936r13Y20200727-0310I20200726-1800Eclipse Releng Bot1-1/+1
2020-07-26v4936r13Eclipse Releng Bot3-4/+4
2020-07-26Get rid of 1.5.0 JVM configs in build scripts.Alexander Kurtakov1-14/+7
This hasn't been useful for years. Change-Id: I2cb1d1bfbd3501999b60366534aa61593c03644e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-07-25v4936r12v4936r12Y20200725-1200Eclipse Releng Bot1-1/+1
2020-07-25v4936r12Eclipse Releng Bot3-4/+4
2020-07-25Remove unused parameters from SWT tools.Alexander Kurtakov6-14/+9
Change-Id: I078faef960a62fa985b26b4be4c32587a87d7f0e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-07-25Switch AST to JLS 11 in swt.tools.Alexander Kurtakov3-3/+3
Preliminary step for when SWT moves to Java 11. Change-Id: If79e61772a690c3aeb22ec310a8804a1c8887e0f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-07-25Bug 565435 - [GTK4] Reimplement GtkToolbar with GtkBox due to removalPaul D'Pong8-135/+399
Removed from GTK4: gtk_tool_button_new gtk_tool_button_set_icon_widget gtk_tool_button_set_label_widget gtk_tool_button_set_use_underline gtk_toggle_tool_button_get_active gtk_toggle_tool_button_new gtk_toggle_tool_button_set_active gtk_tool_item_get_proxy_menu_item gtk_tool_item_retrieve_proxy_menu_item gtk_tool_item_set_is_important gtk_tool_item_set_homogeneous gtk_tool_item_set_proxy_menu_item gtk_toolbar_insert gtk_toolbar_new gtk_toolbar_set_show_arrow gtk_toolbar_set_style gtk_toolbar_set_icon_size gtk_menu_tool_button_new gtk_separator_tool_item_new gtk_separator_tool_item_set_draw Added: gtk_button_set_child gtk_button_set_use_underline gtk_box_append gtk_box_prepend gtk_box_insert_child_after All of the tool versions of GtkWidgets (toggle tool button) has been replaced with the base GtkWidget. The toolbar has been replaced with a GtkBox. Work to be done after compilation passes is implementing the proxy/overflow menu + image/label handling for the ToolItems. Change-Id: Ic0ef5c786d10953f21790f5f34bd262f746d4fd7 Signed-off-by: Paul D'Pong <sdamrong@redhat.com>
2020-07-24v4936r11v4936r11I20200724-1800Eclipse Releng Bot1-1/+1
2020-07-24v4936r11Eclipse Releng Bot3-4/+4
2020-07-24Bug 565064 - [GTK4] Adapt to GdkWindow API changesPaul D'Pong18-576/+370
GdkWindow has been changed to GdkSurface and creating children directly is no longer possible but instead broken into toplevel & popups. Many functions have been removed altogether and still require replacements. I have added TODOs in place for now as the goal is to compile SWT in GTK4 then move on to making it work. Added: gdk_toplevel_focus to replace gdk_surface_focus/gdk_window_focus gdk_surface_new_toplevel to replace gdk_surface_new_child gdk_toplevel_present to replace gdk_surface_raise gdk_toplevel_get_state gdk_toplevel_lower gdk_popup_get_parent to replace the need to set/get use surface user_data gdk_popup_present gdk_popup_layout_new Removed: gdk_surface_get_frame_extent gdk_surface_get_children gdk_surface_get_root_origin gdk_surface_invalidate_region gdk_surface_move gdk_surface_move_resize gdk_surface_resize gdk_surface_restack gdk_surface_set_decorations gdk_surface_set_functions gdk_surface_show gdk_surface_show_unraised Renamed: GDK_SURFACE_STATE_ICONIFIED -> GDK_SURFACE_STATE_MINIMIZED Change-Id: I0ea9fb4b52a4f1e3a8171805e4620b20005f9b8e Signed-off-by: Paul D'Pong <sdamrong@redhat.com>
2020-07-24Bug 565310 - [GTK4] gtk_widget_ toplevel/surface function removalsPaul D'Pong16-45/+116
- gtk_widget_get_surface are now extracted from GtkNative - gtk_widget_get_toplevel are now either gtk_widget_get_native or gtk_widget_get_root. Change-Id: I04301271473f892f46d5ceeeeb6e6057de707c71 Signed-off-by: Paul D'Pong <sdamrong@redhat.com>
2020-07-24Bug 565185 - Add Text & StyledText backspace/delete testsPaul D'Pong2-0/+103
Same test in Text & StyledText to test that the backspace key event will trigger a delete. Change-Id: Idbc50c7a96e45609c63b119fe3f5431514fe37a2 Signed-off-by: Paul D'Pong <sdamrong@redhat.com>
2020-07-24v4936r10v4936r10fI20200724-0600Eclipse Releng Bot1-1/+1
2020-07-24Increment library count in buildSWT.xmlLakshmi Shanmugam1-1/+1
Signing the mac app adds _CodeSignature/CodeResources file, so count on Mac is 6 and total count is 35. Change-Id: I92742bb32c33caeefd7127d7e99302913b9c91a0
2020-07-24JDT lambda and method references applied on SWT custom widgetsLars Vogel9-15/+15
Change-Id: I04a40486e2deacc2b3a60db5debaac6c0e9ba279 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-07-24Bug 565208: Remove calls to Color.disposeLars Vogel1-1/+0
Change for Link in the GTK port. AFAICS the win and mac port already do not call dispose on the color. Change-Id: I2a19f60db6e1f256ea58042515afd88af4ae4ae9 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-07-23v4936r10v4936r10eI20200723-1800Eclipse Releng Bot1-1/+1
2020-07-23v4936r10v4936r10dEclipse Releng Bot1-1/+1
2020-07-23v4936r10v4936r10cEclipse Releng Bot1-1/+1
2020-07-23v4936r10v4936r10bEclipse Releng Bot1-1/+1
2020-07-23v4936r10v4936r10aI20200723-1030Eclipse Releng Bot1-1/+1
2020-07-23Bug 565434 - Error launching Chromium style browserLakshmi Shanmugam1-1/+1
finally 34 is the correct library count old library count - 23 Mac chromium libs (including Info.plist & PkgInfo)- 5 Windows chromium libs - 3 Linux x86_64 libs - 3 Change-Id: Ic58a20ed92f5a268a8d24563889caa04df92128b
2020-07-23v4936r10v4936r10I20200723-0620Eclipse Releng Bot1-1/+1
2020-07-23v4936r10Eclipse Releng Bot3-4/+4
2020-07-23Bug 565434 - Error launching Chromium style browserLakshmi Shanmugam1-1/+1
Commit Cargo.toml file Change-Id: I9ea6c81205763cfa1f7a34db8cb887a966243fa7
2020-07-23Bug 565434 - Error launching Chromium style browserLakshmi Shanmugam1-2/+4
Print library count after build. Update to 35. Change-Id: I439f5f17730c7b9087f96a82c2a5b1d92243cd6d
2020-07-23Bug 565434 - Error launching Chromium style browserLakshmi Shanmugam4-8/+8
Put version information back in Cargo.toml Reverting rest of the change - https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/166513 Change-Id: If464271803c6b0aa9d14a143cbc6642dab0b2a87
2020-07-22v4936r9v4936r9cY20200722-1200I20200722-1800I20200722-1140I20200722-0610Eclipse Releng Bot1-1/+1
2020-07-22Bug 565414 - [Mac] Chromium jar doesn't have the executableLakshmi Shanmugam1-1/+1
Change-Id: I68d6fd86353fbd812c40757c0a7c8f12e38736e8
2020-07-21v4936r9v4936r9bY20200722-0040I20200721-1800I20200721-1400I20200721-0950Eclipse Releng Bot1-1/+1
2020-07-21v4936r9v4936r9aY20200721-0610Y20200721-0450I20200721-0610I20200721-0130Eclipse Releng Bot1-1/+1
2020-07-20v4936r9v4936r9I20200720-1800Eclipse Releng Bot1-1/+1

Back to the top