Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2018-05-14Bug 534654: [GTK3] Free strings from native *to_string() functionsEric Williams1-0/+1
Add a g_free() call to free string from gdk_rgba_to_string(). Change-Id: Ie54850e2f8c1658f797bb6e3d4d3a78bb912f994 Signed-off-by: Eric Williams <>
2018-05-14Bug 534555 - [GTK] Browser stops responding and throws an error onLeo Ufimtsev1-8/+10
dispose (Browser crash) I found an subtle issue in javascript execution logic. The javascript execution logic is canceled if browser's *shell* is disposed. This is wrong, the javascript logic should check if the *browser* is disposed, not the browser's shell because you can have the situation where the shell is not disposed but the browser is. Also updating error message to clarify slow javascript execution for users. I can't reproduce the issue locally, so I can only assume this fixes the reported issue. But I tested jUnits and child Eclipse and didn't have issues. Change-Id: Icae4ec6c28dd17fb1e555f24fbd5b0b984702917 Signed-off-by: Leo Ufimtsev <>
2018-05-12v4880v4880eI20180514-0800I20180513-2000I20180513-0800I20180512-1500I20180512-0830Eclipse Platform RelEng Bot1-1/+1
2018-05-12Bug 534597 - Unanticipated comparator errors in I20180511-2000Sravan Kumar Lakkimsetti1-1/+2
Change-Id: I887c5a1913fd321e279bd221bd888ff04a5930dd Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-05-09v4880v4880dS4_8_0_M7I20180511-2000I20180509-2000Eclipse Platform RelEng Bot1-1/+1
2018-05-09Bug 534500 - Double Scaling with X11 backend for images drawn with gcSravan Kumar Lakkimsetti1-1/+5
Change-Id: I0b38c0d72f32831f7b579bc11e3aaff08b028025 Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-05-07v4880v4880cI20180509-0800I20180508-2000I20180508-0800I20180507-2205I20180507-2000Eclipse Platform RelEng Bot1-1/+1
2018-05-07Bug 528299 - Eclipse failed to load on PPC64LE platformSravan Kumar Lakkimsetti2-2/+2
Change-Id: I937e069adee673916d25f6bd1365bcedcda9522e Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-05-07v4880v4880bI20180507-0810Eclipse Platform RelEng Bot1-1/+1
2018-05-07Bug 521887 - [HiDPI][Win32] GC draw line with width 0 is not affected byI20180507-0800Niraj Modi3-5/+11
OS scaling Change-Id: I1efc0223aab63a25c4d83392d3723ec73bd66629 Signed-off-by: Niraj Modi <>
2018-05-07v4880v4880aEclipse Platform RelEng Bot1-1/+1
2018-05-07Bug 532443 - Creating a new Image using SWT.IMAGE_GRAY returns an ImageNiraj Modi5-13/+37
equal to the old Image - Also fixed the JavaDoc typo in and Change-Id: I2d40061a256e5feba717b765f7cbe9b3e359e508 Signed-off-by: Niraj Modi <>
2018-05-04v4880v4880I20180506-2000I20180506-0800I20180505-1500I20180504-2000Eclipse Platform RelEng Bot1-1/+1
2018-05-04v4880Eclipse Platform RelEng Bot3-4/+4
2018-05-04Bug 531373 - [Win32] Table custom header background/foreground does notConrad Groth1-1/+1
work when scrolling Change-Id: Ide386b5cae394e60b70a93b1916fc8759a7abbfa Signed-off-by: Conrad Groth <>
2018-05-04Bug 530932 - Enable native scaling on Linux GTKSravan Kumar Lakkimsetti15-19/+152
Change-Id: I98a9fcd461739f27f62f0179c4df4ea6ece6f370 Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-05-03v4879v4879aI20180503-2000Eclipse Platform RelEng Bot1-1/+1
2018-05-03Bug 515773 – [wayland] Text widget not able to grab focus withLeo Ufimtsev2-5/+121
SWT.ON_TOP shell (fixing crash of earlier patch). At the time of the original patch, gdkSeat grab only worked on hidden gdkWindows which were shown with handler, so Ian made gtkWindows invisible before grabbing focus. Having invisible windows leads them to be unrealized and an unrealized window is passed to wayland, which crashes due to a a segfault. In newer gtk3 (3.22) this is no longer the case, seat grabbing works on visible windows, so not hiding windows fixes the gnome crash and doesn't break things. Also I'm making the callback static instead of instance, because otherwise there is a memory leak every time you raise the shell. Tests: - Child eclipse works well, including javadoc and outline. No crashes. - Original bug snippet works well. Bug: Change-Id: Ief9e066bbd488413ffbbe752f2b2c9ce561f532f Signed-off-by: Leo Ufimtsev <>
2018-05-03Bug 534089 – [GTK3] Tabfolder setControl(..) breaks with a table thatLeo Ufimtsev2-5/+19
has composite controls. Temporarily make use of the deprecated gtk_widget_reparent(..) as alternative fix would require deep investigation and we need something functional for photon. Bug: Change-Id: I351518383ce77343ccd10e1f1a45750e5663d5c8 Signed-off-by: Leo Ufimtsev <>
2018-05-03Bug 480586 - [Win32][HiDPI] Tree expansion triangle issuesNikita Nemkin2-0/+10
Fix tree glyph DPI scaling for trees without image list. Change-Id: I6d052eb08d6d33fde1690ff7c0e2c6d8dd690b92 Co-authored-by: Conrad Groth <> Signed-off-by: Nikita Nemkin <>
2018-05-03v4879v4879I20180503-0740Eclipse Platform RelEng Bot1-1/+1
2018-05-03v4879Eclipse Platform RelEng Bot3-4/+4
2018-05-03Bug 184951 - [Win32] Tree/Table checkboxes render jagged at a high DPINikita Nemkin6-20/+57
DrawThemeBackground stretches the checkbox bitmap to fill the provided rectangle. To avoid stretching artifacts, limit the rectangle to actual checkbox bitmap size. This change also supersedes the fix for bug 489828. Change-Id: Ib227b874716b7858dc52596c5103ceb598e68cbb Signed-off-by: Nikita Nemkin <>
2018-05-03Bug 534029 - [Win32] Simplify Display.getPrimaryMonitor()Nikita Nemkin2-21/+3
Use the method suggested here: Change-Id: I4479c8b50b8a98c14f7f8ea177381ee25269ea74 Signed-off-by: Nikita Nemkin <>
2018-05-02v4878v4878bI20180502-2000Eclipse Platform RelEng Bot1-1/+1
2018-05-02Bug 534007: [GTK3] Support for detecting themes like in 4.7.3 (butEric Williams2-3/+46
without the memory leaks) Check for the presence of the GTK_THEME environment variable. When loading system colors from the GTK CSS theme, we can make use of this information to load the proper theme information and dark variants, if necessary. Tested with the Adwaita and Arc themes (and their dark variants) on GTK3.22, X11 and Wayland. No AllNonBrowser JUnit tests fail. Change-Id: If3697495a941ac4e26fb2d714d4b221da65325a1 Signed-off-by: Eric Williams <>
2018-05-02Bug 534204 - [GTK3] cramped vertical scale has no troughSimeon Andreev2-15/+27
The orignal fix for bug 534204 (change 121927) addressed only horizontal scales. I.e. despite the fix, if a vertical scale has little rendering space due to resizing or small width hint, it will not draw its trough. This change aims to fix also vertical scales. Change-Id: Ifc6a01ba185b854b832cf9d8c5014d0b035615db Signed-off-by: Simeon Andreev <>
2018-05-02Declare source folders for SonarQube analysisMickael Istria1-8/+9
Since the bundle is configured to not actually build content and doesn't declare source folders in, we need to explicitly add folders if we want SonarQube to analyze them. Change-Id: Ibb18c46a17bfd5e79cae2efdcd45ba4df61c19e6 Signed-off-by: Mickael Istria <>
2018-05-02Bug 533559 - [Win32] Move TASKBARBUTTONCREATED handlerNikita Nemkin2-12/+12
TASKBARBUTTONCREATED is sent to top level windows, process it in Shell.windowProc. Bug 305335 provides a test snippet. Change-Id: Ie4ba53cbee5964a216e19e1f84151960e1df9bfa Signed-off-by: Nikita Nemkin <>
2018-05-01v4878v4878aI20180502-0100I20180501-2000Eclipse Platform RelEng Bot1-1/+1
2018-05-01Bug 533995: [GTK3] Native memory leak in gc.setBackground/setForegroundEric Williams1-0/+3
Free all strings returned by gtk_css_provider_to_string() to fix a memory leak. Change-Id: I94e45c2457bfbcf6970038f61926830c7d480f76 Signed-off-by: Eric Williams <>
2018-04-30v4878v4878I20180430-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-30v4878Eclipse Platform RelEng Bot3-4/+4
2018-04-30Bug 500703: [GTK3.20+] Combo with SWT.READ_ONLY is garbled upon re-sizeEric Williams7-3/+187
In GTK3.20+ two things inside GTK3 changed. First, certain widgets have their clips unioned with the clips of their parent widget. This can cause overdrawing in widgets like Combo. Second, the internal widget hierarchy of Combo changed, and most of the resizing is done by a GtkBox instead of GtkComboBox itself. These two changes combined caused this bug. The overdrawing causes the Combo to draw over its neighbouring widgets (like a label). The resize issue means that resizing the widget doesn't cause it get smaller: the x coordinates of the allocation and clip just become negative and the whole widget shifts to the left. The fix is to adjust the clip and allocation of the Combo and its children from the parent Composite's draw handler. This ensures that the Combo is drawn with correct coordinates and that it actually shrinks when resized, instead of just shifting. Tested on GTK3.22, X11 and Wayland. Window -> Preferences -> General -> Keys behaves as expected, and no AllNonBrowser JUnit tests fail. Change-Id: Ic603acfda924b0ca36b4f0ba07048f6762c99270 Signed-off-by: Eric Williams <>
2018-04-30Bug 534174 - Test snippet fails to build on 32bit platformsAlexander Kurtakov1-2/+2
Change-Id: I87380a096dd5548e002d0e2620570d52482dfcf7 Signed-off-by: Alexander Kurtakov <>
2018-04-30Bug 529009 - Embedded Browser does not forward '<' character to client codeTom Schindl1-0/+1
2018-04-30Bug 534204 - [GTK3] Scale with GridLayout height hint has no lineSimeon Andreev2-0/+83
An SWT Scale for which a low height hint is specified via GridData does not show its line on GTK 3.22. It only shows its trough. This is also observed when the parent of the Scale has a GridLayout and has a small enough size (e.g. due to resizing). This change ensures the scale is never reduced to below 26px. Resizing of the scale is not impacted, since the GTK scale resides in an SWT fixed which can still be resized at will. When resized below 26px, parts of the scale start to become not visible. Change-Id: I5d0b18783b5f126ca2fee6918b885480cbcb977e Signed-off-by: Simeon Andreev <>
2018-04-27v4877v4877I20180430-0715I20180429-2000I20180428-2020I20180428-1500I20180427-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-27v4877Eclipse Platform RelEng Bot3-4/+4
2018-04-27Bug 534164 - Fix building the SWT bridge on 32bit intel Fedora systemsMat Booth1-1/+1
Change-Id: I99ddffbad24f5fd118a2dde791db117b14b95d34 Signed-off-by: Mat Booth <>
2018-04-27Bug 527729 - Apply Themefixes unless flag specified.Leo Ufimtsev7-21/+35
After further investigation, the style fixes seemed to be needed for Ubutu's dark theme to function properly. Solution: - (as before) Apply Functional fixes (like keyboard navigation) at all times. - Apply theme fixes for all themes, but permit them to be turned off if the following Java vm arg is specified: -Dorg.eclipse.swt.internal.gtk.noThemingFixes - (as before): Allow custom css to be loaded via: org.eclipse.swt.internal.gtk.cssFile. This should fix Ubuntu's dark theme issue but still allow clients to turn off special theme fixes. Please reply with +1/-1 if you are in favor or against this approach. This patch is fairly trivial, if you have an alternative suggestion, please feel free to share. Bug: Change-Id: Ib2e419ee29385a9261a3bef754ef92b168d161b4 Signed-off-by: Leo Ufimtsev <>
2018-04-27For each conversion in Kurtakov23-177/+116
Change-Id: I9b24de33ba07df5717bb32326392f24555d5c88d Signed-off-by: Alexander Kurtakov <>
2018-04-26v4876v4876I20180426-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-26v4876Eclipse Platform RelEng Bot3-4/+4
2018-04-26Bug 232501 - Snippet to compute browser sizeLucas Bullen1-0/+70
Change-Id: Ib12e18cbdb4a0b1773a74c8818d4f0ca3469266a Signed-off-by: Lucas Bullen <>
2018-04-26Bug 480639 - Provide monitor-specific DPI scaling / zoom levelNikita Nemkin10-190/+57
* Use flags=dynamic for GetDpiForMonitor * Set Monitor.zoom at Monitor creation time. Change-Id: I2756292bc673aa661b5cb0b97450a7677a730ae4 Signed-off-by: Nikita Nemkin <>
2018-04-26Bug 534080 - [StyledText] java.lang.IllegalArgumentException: Index outazerr1-6/+8
of bounds when setCaretLocation Change-Id: Ic1389869f060bd8023e9744387ecaa9667c6c548 Signed-off-by: azerr <>
2018-04-25v4875v4875aI20180426-0500I20180425-2000I20180425-1705Eclipse Platform RelEng Bot1-1/+1
2018-04-25Bug 533833 – [Webkit2] Should not use G_TYPE_CHECK_INSTANCE_TYPE(..)I20180425-1650Leo Ufimtsev2-23/+29
I adopted the code so that webkit2 no longer uses the macro. But I didn't take the time to remove it's use from webkit1 as I don't think it's worth the time. I left some notes warning not to use the macro. Upon removal of webkit1, it should be removed. Tests: - Fedora 27, Webkit2.18, jUnits & child eclipse. - Not tested on webkit1, but should work as there are no logic changes. Bug: Change-Id: I825825c02413a35592dcf3e21114ed774cf146f0 Signed-off-by: Leo Ufimtsev <>
2018-04-24v4875v4875I20180425-1455I20180425-0910I20180425-0725I20180425-0505I20180425-0250I20180424-2000Eclipse Platform RelEng Bot1-1/+1

Back to the top