Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-06-18v4946r9v4946r9aI20210620-1800I20210619-1800I20210618-1920I20210618-1800Eclipse Releng Bot1-1/+1
2021-06-18Bug 573633 - Fix GLib critical errors due to unref of a null pixbufSimeon Andreev2-2/+6
With the fix for bug 573633, TreeItem.setImage(null) resp. TableItem.setImage(null) results in the following GLib critical errors printed on standard error: g_object_unref: assertion 'G_IS_OBJECT (object)' failed This change adds a check, to ensure we are not calling g_object_unref() on a null pixbuf, in TreeItem.setImage() resp. TableItem.setImage(). Change-Id: I3c081861b063affea4324c0508bfa0310e89db2a Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/182159 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-17v4946r9v4946r9I20210617-1800Eclipse Releng Bot1-1/+1
2021-06-17v4946r9Eclipse Releng Bot3-4/+4
2021-06-17Bug 574007 - [win32] Better JDK searching in native library build scriptAlexandr Miloslavskiy1-12/+33
* Once again searches '%ProgramFiles%\Java\jdk*' * Correctly searches in '%ProgramFiles%\Java\jdk*' instead of '\Program Files\Java\jdk*' * Now auto-configures from '%ProgramFiles%\AdoptOpenJDK\jdk*' * Fixed incorrect "WARNING: x64 Java JDK not found" when JDK path contained spaces * Better supports multiple potential JDK paths Change-Id: Iba421f2eb517ca85fbc7e3589e8ac5fb72400398 Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/182102 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Niraj Modi <niraj.modi@in.ibm.com>
2021-06-17Bug 574007 - Drop outdated 32-bit support from native library build scriptAlexandr Miloslavskiy1-17/+4
Change-Id: If89657e5230d2f1c78595fb390eb0a4d9f9d579d Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/182101 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Niraj Modi <niraj.modi@in.ibm.com>
2021-06-17Bug 571033 - [GTK] Clean up ToolTips ImplementationPaul D'Pong12-101/+49
- Moved setToolTipText utility function from Shell to Widget, as there is no dependency on Shell required and the function is mainly used in more broad cases. This results in cleaner code as there is no need to get the Shell object. - Remove fixChildren overrides in Table, Tree, as the changes in the Shell or underlying GtkWindow does not affect the call to gtk_widget_set_tooltip_text. This seems like a legacy thing that SWT used to do when GtkWidget did not have native tooltips. Change-Id: I8b886cbc34e3c5b0e1bb18b30a3a1f4edbacde24 Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181797 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-17v4946r8v4946r8Eclipse Releng Bot1-1/+1
2021-06-17v4946r8Eclipse Releng Bot3-4/+4
2021-06-17Bug 121220 - Fixed: Patterns with alpha transparencyStefan Kowski9-78/+298
Alpha transparency will be applied to background and foreground patterns. Change-Id: Ia6076e64dfcb885ca9084c5a4160129c37bb1436 Signed-off-by: Stefan Kowski <stefan.kowski@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/176815 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Niraj Modi <niraj.modi@in.ibm.com>
2021-06-16v4946r7v4946r7aI20210616-1800Eclipse Releng Bot1-1/+1
2021-06-16Bug 574027 - [GTK] Clean up ProgressBar classPaul D'Pong2-67/+63
- Removed old GTK2 flags that were being casted and used in the GTK3/GTK4 case. The logic is the same, just removed the redundant flags that was used for GTK2 functions. - Removed extra spacing between function name & parameters to keep consistency. - Removed parameters of updateBar function as updateBar should only operate on the class fields (selection, maximum, minimum). Makes the code easier to read as well. Change-Id: I88539f05c58d10895d3c4d6f5fd794be9dd0c1b9 Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181467 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-15v4946r7v4946r7I20210615-1800Eclipse Releng Bot1-1/+1
2021-06-15v4946r7Eclipse Releng Bot3-4/+4
2021-06-15Bug 573701 - [GTK4] Shell children rendering/resizing off window -Paul D'Pong4-23/+32
GtkRange warnings - Remove GTK3 specific initial widget allocation code that caused GtkRange allocation warning - Added notify signals on default-height & default-width as a replacement to size-allocate signal (https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkwidgets-size-allocation-changes) Change-Id: I3fe3feb31a77cfe0917d9d0438a4f1f90e7d052f Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180885 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-15Bug 574112 - [GTK4] Fix incorrect widget destruction due to removal ofPaul D'Pong2-5/+13
GtkContainer - Override Control's destroyWidget to correctly remove widget from parent SWTFixed container - Removed unused function (which wraps a call to destroyWidge) destroyHandle in Scrollbar - Remove comment in Scrollbar's destroyWidget override which has been there since 2009 or later, clearly not required to be uncommented Change-Id: Iae93ded9d80e8f5be7716add490f1bd8f216f573 Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181737 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-15Bug 574030 - [GTK4] Port Program Snippet 32 - gtk_icon_theme_lookupPaul D'Pong6-42/+82
error - GTK4 version of gtk_icon_theme_lookup_by_gicon - Retrieve GFile & GdkTexture associated with the gicon in order to retrieve the GdkPixbuf object neede to create the ImageData object - Better spacing & added comments for readability Change-Id: I0d21d64f08e9aa8793f27971727e983813aacc67 Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181469 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-15Bug 574060 - [GTK] Removed GTK2 code in Slider widgetPaul D'Pong1-12/+0
Small patch to remove GTK2 bug specific code around slider buttons. GTK3 & GTK4 no longer have these slider buttons, therefore this bug does not exist. Passes all Test_org_eclipse_swt_widget_Slider tests. Change-Id: I02e64f02eee407824ebf3aa8e63b052ace345ae5 Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181542 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-15Bug 570533 - [GTK4] Make separate GTK3.java and GTK4.java nativePaul D'Pong17-419/+311
wrappers - Final move & cleanup - Moved gtk_render, and gtk_enumerate_printers functions under General Gtk category - Grouped GtkStyleContext functions - Added a bunch of comments to group classes of functions - Split GtkStyleContext, GtkTextView, GtkToggleButton, GtkTreeView functions to their respective GTK3/GTK4 files - Grouped GtkPlug/GtkSocket functions (looking to remove this, but when put into GTK3.java file, binding fails to be built even though they exist in GTK3 library) Change-Id: Ibfd22f4af1c1a3c0ca5a2e30a79fcb726a0ed22a Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181072 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-15v4946r6v4946r6Y20210615-0910Y20210615-0900Eclipse Releng Bot1-1/+1
2021-06-15v4946r6Eclipse Releng Bot3-4/+4
2021-06-15Bug 570533 - [GTK4] Make separate GTK3.java and GTK4.java nativePaul D'Pong19-289/+244
wrappers - Grouped up general GTK functions - Added comment headers for function groups for GtkFileFilter, GtkFontChooserDialog, GtkFontChooser Interface, GtkSearchEntry, GtkSeparator, GtkIMContext, GtkIMMulticontext, GtkListStore, GtkCssProvider - Move gtk_style_context_add_provider_for_screen, gtk_style_context_add_provider_for_display to their respective files - Move GtkMenu, GtkMenuButton, GtkLabel functions Change-Id: Iacc1c54b1c375c7ec9d05f4ab0ece3241e78ec6b Signed-off-by: Paul D'Pong <sdamrong@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181017 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-10v4946r5v4946r5Y20210614-0420Y20210611-0900I20210614-1800I20210613-1800I20210612-1800I20210611-2000I20210610-1850Eclipse Releng Bot1-1/+1
2021-06-10v4946r5Eclipse Releng Bot3-4/+4
2021-06-10Bug 574079 - [GTK3] Missing check for out-of-handles inAndrey Loskutov1-0/+1
Menu.createHandle() Change-Id: I6cb40b6fedb0b3af8990b5409887b5f377ecb6ee Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181750 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2021-06-10Bug 574007 part2 - [win32] Re-work the SWT Windows native build scriptNiraj Modi1-1/+4
to run even without W: drive - Added reference to SWT Windows native setup page wiki in case of missing or incomplete setup. Change-Id: I36662bebfa6fdc12be09eecd4ee0ee8799ca30a7 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181745 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-10Bug 573697 - [GTK3] MenuBar leaks native memorySimeon Andreev4-2/+251
This change ensures the GTK+ accelerator group allocated by Decorations is released upon destruction. In addition, the accelerator group is removed from menu items, upon Decorations.destroyAccelGroup() (and prior to recreating it during Decorations.fixAccelGroup()). This prevents a crash in GTK+ code, due to trying to use the now released handle. Manual snippets are also added to the set of GTK bug snippets, for future manual validation. Change-Id: Ic3befc6b627bc78393154a47ecc54b372e062d3a Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180940 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-09v4946r4v4946r4aI20210609-1800Eclipse Releng Bot1-1/+1
2021-06-09Bug 573573 - [GTK3] Tree.rendererRender() leaks native memorySimeon Andreev1-0/+1
This change adds a missing gtk_tree_path_free() in Tree.rendererRender(), to avoid a native memory leak. Change-Id: I6214b45045e490ec80ef1ae2367633bcf43a3d20 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180664 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-08v4946r4v4946r4Y20210608-2330I20210608-2130I20210608-1800I20210608-1300Eclipse Releng Bot1-1/+1
2021-06-08v4946r4Eclipse Releng Bot3-4/+4
2021-06-08v4946r3Eclipse Releng Bot1-1/+1
2021-06-08v4946r3Eclipse Releng Bot3-4/+4
2021-06-07Bug 573633 - [GTK3] Tree.setImage() leaks native memorySimeon Andreev3-0/+12
This change adds missing free calls to pixbuf objects created by TreeItem.setImage() and TableItem.setImage(), preventing native memory leaks. According to the documentation of gtk_tree_store_set() and gtk_list_store_set(), the call will reference the pixbuf in question. Its therefore safe to unref it after the call, allowing GTK+ to eventually free the memory on tree destruction. Change-Id: Id54bedb6bbe6bed5075605ae7bbb3b69c48b00a3 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180858 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-07Bug 573016 - [StyledText] lines are overdrawn on vertical indent changeGayan Perera1-1/+4
when vertical indent changes for a line where caret line below the changing line, the lines below must be redrawn to update with the changed indent. At the same time the caret must be updated to follow the changes. Change-Id: I8fe5403c834731a1d4a1f22125d5f109c9f6f5cc Signed-off-by: Gayan Perera <gayanper@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180382 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-06-07Bug 574007 - [win32] Re-work the SWT Windows native build script to runNiraj Modi1-1/+2
even without W: drive - Required for the new Azure based Windows10 build machine with Eclipse Foundation Change-Id: I7f144f4228f56962ee39b8e8a1817637c2b40656 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181433 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-04v4946r2v4946r2aI20210606-1800I20210605-1800I20210604-2250I20210604-1020Eclipse Releng Bot1-1/+1
2021-06-04Bug 573965 - Version bumps for 4.21 streamSravan Kumar Lakkimsetti3-3/+3
Change-Id: I9cb7b19a4e9b15899593c9e6dc701b176699ba36 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181447 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-04v4946r2v4946r2I20210604-0640I20210604-0350Eclipse Releng Bot1-1/+1
2021-06-04v4946r2Eclipse Releng Bot3-4/+4
2021-06-04v4946r1Eclipse Releng Bot4-7/+7
2021-06-04Bug 573960 - POM and product version change for 4.21 releaseSravan Kumar Lakkimsetti19-19/+19
Change-Id: Ida1021eaaed60f4345b25337831ca0a39faebe5a Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181373
2021-06-02v4944r26v4944r26kS4_20_0_RC2aS4_20_0_RC2R4_20I20210611-1600I20210610-1250I20210610-1220I20210610-0400I20210609-0520I20210609-0400I20210609-0220I20210603-0040I20210602-1800R4_20_maintenanceEclipse Releng Bot1-1/+1
2021-06-02Bug 573092 - Incorrect DLL Name Constant for SWT Browser style SWT.EDGENikita Nemkin2-24/+34
Allow loading JNI libraries without any platform or version suffix. The latter is abused by Edge browser back-end to extract (if necessary) and load WebView2Loader.dll. Change-Id: I458795a6d54f0ec89405cafc810a2ba5f7a9b4b7 Signed-off-by: Nikita Nemkin <nikita@nemkin.ru> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181275 Reviewed-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-by: Niraj Modi <niraj.modi@in.ibm.com> Tested-by: Niraj Modi <niraj.modi@in.ibm.com>
2021-05-31v4944r26v4944r26jI20210602-0600I20210601-1800I20210601-0600I20210531-1800Eclipse Releng Bot1-1/+1
2021-05-31Bug 573813 - non disposed widget error on first startNiraj Modi1-1/+6
- Handle special case for 'TaskBar.createShellLink()' where Image object doesn't own the handle Change-Id: Id066037b5d1fc6892055f679efd02baa71e9788a Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181184 Reviewed-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-05-26v4944r26v4944r26iS4_20_0_RC1I20210531-0600I20210530-1800I20210529-1800I20210529-0600I20210528-1800I20210526-2310I20210526-1800Eclipse Releng Bot1-1/+1
2021-05-26Bug 571787 - Fix failure in SWT-new-release jobLakshmi Shanmugam1-0/+19
In new_build target, chromium.properties files in binaries repo needs to be committed first to fix failure in push_remote_from_workspace. Change-Id: Ifda5e1a24afad05b687befcdb27ec57214679ae5 Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/181054 Tested-by: Lakshmi P Shanmugam <lshanmug@in.ibm.com> Reviewed-by: Lakshmi P Shanmugam <lshanmug@in.ibm.com>
2021-05-26Rename internal SpiesPlugin class to SpiesConstant to avoid confusing itLars Vogel2-3/+5
with an activator Bug 502839 changed it from activator to a a simple class. Lets rename it and change to interface to make its usage clear. Change-Id: Idb0ebf0acba4bafb3297b429e466aa074d794888 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180763 Reviewed-by: Marc-André Laperle <malaperle@gmail.com>
2021-05-26v4944r26v4944r26hI20210526-0600Eclipse Releng Bot1-1/+1

Back to the top