Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-09-12Bug 393269 - [GTK] Slider Selection events do not have detail field setEric Williams4-12/+30
Connect a custom Callback to ensure the proper detail field is set. Previously this wasn't working because the double parameter in the Callback's method signature was being read as a long, causing garbage input for other parameters. Tested on GTK3.24 and X11 using Snippet17. No adverse effects observed in the IDE, and no AllNonBrowser JUnit tests fail. Change-Id: I4e330cf52509011e873c197d01b0265dad861d28 Signed-off-by: Eric Williams <>
2019-09-11Bug 299550: [GTK] Make "Print Selection" workEric Williams5-7/+54
Implement selection printing on GTK. Note that the selection option is always available, even if no text is selected. In this case, a blank page will be printed. Tested on GTK3.24 with X11. Printing in the IDE works for all supported cases as expected. Change-Id: I540c0fe7ff5d5d5517ee1dc249c91bf9b83d4a1e Signed-off-by: Eric Williams <>
2019-09-11Bug 545953: Device#getDPI method can return incorrect valuesEric Williams2-7/+20
This adjusts commit f1cec2dde6ea77ca066ebe3a405f7ced98098903 to prevent Printer from having the wrong size. Change-Id: I9fe45e3d892acb027f64bbc668a7accc522fcf40
2019-09-11Bug 341117: ToolItem traversal does not fire deactivate event.Eric Williams3-1/+62
Send focus[In/Out] events in the parent ToolBar, in order to ensure traversal events get fired when traversing from a Control to an Item (like ToolItem). Otherwise Controls won't receive Deactivate events until the next Control has focus. Tested on GTK3.24 and X11, using the snippet attached. No AllNonBrowser JUnit tests fail. Change-Id: I899195aeef939f0b68fedb34a2f5a37d6e928409 Signed-off-by: Eric Williams <>
2019-09-11Bug 550965 - Remove swt tools activatorAlexander Kurtakov5-75/+5
Not used at all and actually used deprecated api so removing it gives us cleaner build. Change-Id: Ieb6c1fce78c267f51ade55014c4e6fb8936ec2b3 Signed-off-by: Alexander Kurtakov <>
2019-09-11Bug 545953: Device#getDPI method can return incorrect valuesEric Williams2-31/+7
Use gdk_screen_get_resolution() as width/height returned by GDK does not take EDID into account, and is therefore inaccurate. Furthermore, getScreenDPI() and getDPI() are the same so remove the duplicate method and simplify the code that was calling it. Tested on GTK3.24 on X11, no AllNonBrowser JUnit tests fail. Change-Id: I16b22d734b3b153af0f1161bb9df3996d58b7f19 Signed-off-by: Eric Williams <>
2019-09-11Bug 550606: [GTK] Right-click > Rename from Project Explorer non-functional ↵Eric Williams1-1/+2
when starting with only hidden projects Adjust the conditions for gdk_window_ensure_native() to ensure it only gets applied to the right cases. Change-Id: I3a57d8674d79bbdc123f11352ab7c7d6b0e807f5 Signed-off-by: Eric Williams <>
2019-09-10Bug 550734 - Improve colorPattern in DisplayPaul Pazderski1-7/+2
Change-Id: I0b420bf2e6b86c3627c52ca67bdad62978030501 Signed-off-by: Paul Pazderski <>
2019-09-10Bug 550734 - Cache Pattern.compile in DisplayLars Vogel1-8/+7
Change-Id: Icb998584d2c26b5c6d6909c2e2bcd5d75646fb6b Signed-off-by: Lars Vogel <>
2019-09-10Bug 550916 - Enable WebKitGTK back/forward gestureAlexander Kurtakov2-1/+6
Property enable-back-forward-navigation-gestures enables horizontal swipe gesture for back/forward which becomes a standard for webkitgtk usages on linux. SWT should enable it by default. Change-Id: I8a19a82f18bcfeb14701fc3758146433bad4f522 Signed-off-by: Alexander Kurtakov <>
2019-09-10Bug 550777 - Version bumps for 4.14 streamAlexander Kurtakov3-3/+3
Bump swt versoin. Change-Id: Ia56c40271f562ce19d7c030a1db1ba5651fd047c Signed-off-by: Alexander Kurtakov <>
2019-09-06Bug 550767 - POM and product version change for 4.14 releaseNiraj Modi18-18/+18
Change-Id: I5f4b86dce47eb22017d41072167fcd28e00e983a Signed-off-by: Niraj Modi <>
2019-09-04Bug 383750 - [Cocoa] Focus transfer copies values into text fieldsLakshmi Shanmugam1-4/+14
Don't call super in Text.becomeFirstResponder for SINGLE style Text widget. This causes multiple focus change events and results in unwanted chang to the text set in the text field. Change-Id: I7f3db189b2f6c8315950b970bcc89bf6c7d357d8
2019-08-28Bug 550499 - Do the Javadoc bash for 4.13Niraj Modi6-13/+9
Change-Id: I133912f5931b333598f69b0718ba95f9bb863a39 Signed-off-by: Niraj Modi <>
2019-08-26Bug 550423 - Crash at creation of Combo SWT.READ_ONLYNiraj Modi1-1/+13
Change-Id: I9f3dfb97313489b2327cec628df6ab84f4cd4495 Signed-off-by: Niraj Modi <>
2019-08-23Bug 546914: [GTK] Git Reflog - branch symbol on the upper right corner does ↵Eric Williams1-3/+15
not react Adding a control to a ToolItem via setControl() has a bug on GTK3 (all versions) where events sent to that control are no longer processed/fired. This is because SWT-GTK3 requires a few extra steps, namely fixing the Z-order (GdkWindow stacking order) after calling setControl(). Events in GTK3 travel via GdkWindow, so the wrong GdkWindow on top will block events from reaching the set control. This is visible in EGit and not SWT (Snippet58) because of the way ToolBar managers in JFace dynamically dispose/create ToolItems on the fly. The fix is call fixZOrder() in the parent ToolBar, everytime ToolItem.setControl() is called. Furthermore, the map signal needs to be connected on the ToolItem's topHandle(). Tested on GTK3.24, X11 and Wayland. Verified in a child Eclipse using EGit. No AllNonBrowser JUnit tests fail. Change-Id: I5bc5df8feda7482aa4180ee18d4d995c6942d463 Signed-off-by: Eric Williams <>
2019-08-23Bug 550375 - Remove unused API filterLakshmi Shanmugam1-8/+0
fixes unused filter warning since new API has been added in version 3.112 Change-Id: I5254bb4184a5eb7225e21f21a5e51b07d94b357d
2019-08-22Bug 550322 - Intermittent test failure in swtSravan Kumar Lakkimsetti1-2/+2
Change-Id: I38bc9fba84e99e76c25c21c4f50d1f01ee5c1617 Signed-off-by: Sravan Kumar Lakkimsetti <>
2019-08-19Bug 549872 - [OI2JIRO] Migration of Platform JIPP to new CIAlexander Kurtakov1-0/+35
infrastructure Add Dockerfile to build swt with natives on linux. Change-Id: I8e4630593ea58afcd9d9721378cfd3bd700a7915 Signed-off-by: Alexander Kurtakov <>
2019-08-19Bug 541427: [GTK3][X11] Tree with no items and the size of the header is blankEric Williams7-0/+86
A change in the GTK3.20 drawing model means that Trees without any items will have blank headers (not drawn). The fix is to ensure that a window-system native window is created for the Tree. Only X11 is affected by this bug, Trees on Wayland behave normally. Tested on GTK3.24 on X11 and Wayland, using the snippet attached and a child Eclipse. No AllNonBrowser JUnit tests fail. Change-Id: I5f8528b43a5ed41d652c663637673385d5eed945 Signed-off-by: Eric Williams <>
2019-08-16Bug 546248: [GTK3] Composite receives to much repaint eventsEric Williams3-0/+130
As of GTK3.16, GTK will send extra draw events to SwtFixed instances containing overlay scrollbars. This happens when the mouse leaves an SwtFixed instance that has overlay scrollbars attached to it. The fix is to check the dirty region in need of a redraw, and only sent an SWT.Paint event if the actual SwtFixed instance is in need of a redraw. Tested on GTK3.24 on X11 and Wayland. No AllNonBrowser JUnit tests fail. Change-Id: I958b4c16020a14f6f24e6e3d1ca67aba2ebec329 Signed-off-by: Eric Williams <>
2019-08-15Bug 549661 - [Win32][DND] FileTransfer can not drop on Portable DevicePaul Pazderski2-4/+34
First problem: dropping on Portable Device does not like the fake PIDLs which were used before. Second problem: dropping on Portable Device query for the data after the drag and drop operation is finished. Change-Id: Ic5f17e12c070759fb957d5010cd8cec5165fc8ff Signed-off-by: Paul Pazderski <>
2019-08-14Bug 549643 - [Win32][DND] dragSetData occurs after dragEndPaul Pazderski2-69/+81
For DropTarget this change fix the flaw that an implementation must release the IDataObject when drop occurs (like the target must do in DropLeave). For DragSource it create a new IDataObject for each drag&drop operation. That way a faulty or malicious drop target cannot query data (produce DND.DragSetData events) after drag&drop operation finished. Change-Id: I1679f5d3726bb318ec037bb1715fc4091129c730 Signed-off-by: Paul Pazderski <>
2019-08-14Bug 550017 - Disabling StyledText changes cursor position and selectionAndrey Loskutov2-1/+26
Change-Id: I55c35ee8dd1b3e7044690414f0d8301127594e4a Signed-off-by: Andrey Loskutov <> Also-by: Simeon Andreev <>
2019-08-13Bug 219750 - [styled text] Typing ~~ inserts é~~Pierre-Yves B.1-1/+14
If last WM_KEYDOWN corresponded to a dead key, ignore the subsequent VM_KEYDOWN message and let the events be sent by WM_CHAR only. Change-Id: I8d916d9fb00f090e0f569ede37e4e520856cc48a Signed-off-by: Pierre-Yves B. <>
2019-08-12Bug 549171 - [win32] Optimize bulk inserting/deleting items for TreeAlexandr Miloslavskiy1-14/+38
Prevent 'Tree#updateScrollBar' after every inserted/deleted item Change-Id: I5792ff958895c47c9eef86b54300fbbca23e3ef1 Signed-off-by: Alexandr Miloslavskiy <>
2019-08-12Bug 549171 - Document the fastest way of bulk inserting/deletingAlexandr Miloslavskiy6-160/+84
Change-Id: Icaeb86dee722efa5f249ffc516b128904a12bf21 Signed-off-by: Alexandr Miloslavskiy <>

Back to the top