Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-06-26Bug 548628: Wayland as Input method is accessible in X11Eric Williams7-106/+0
Remove input method menu all together as GTK no longer supports it. Use the desktop environment input selection instead. Change-Id: I8519e7eb7111060f2c56f1da335a9115c7fd8983 Signed-off-by: Eric Williams <>
2019-06-26Bug 546159 - NullPointerException when adding items to Mac OS nativeLakshmi Priya Shanmugam1-2/+14
toolbar with Java 11 On Mac 10.14, the class name returned was NSTitlebarContainerView instead of the expected NSToolbarView. This is because the position of NSToolbarView has changed: NSTitlebarContainerView > NSTitleBarView > NSToolbarView. Change-Id: I4df79cb655d384726e85ad70611b1064e4f4167a
2019-06-26Bug 548457 - [Win32] Replace direct vtable calls with interface wrappersNikita Nemkin29-320/+666
Also, move all GUID constants to COM. Change-Id: I57cc0e1cfdadcaac459323010aec4efbc726417b Signed-off-by: Nikita Nemkin <>
2019-06-26Removes unsed import from FileViewerLars Vogel2-2/+12
Also sets unused import to error in the project settings. Change-Id: Ia0b87f84d94e86c1241566efc5ca2bcacba9b8f3 Signed-off-by: Lars Vogel <>
2019-06-25Bug 205199 - [Win32] setImage(null) on Label overrides textPaul Pazderski2-14/+133
Label need to change some stylebits when changing from showing image to text and vica versa. This failed for some change orders e.g. when calling setText then setImage then remove image with setImage(null) nothing was rendered in the end. Includes a example to show result from different invocation orders of setText and setImage on a single label. Change-Id: I0c258c19ff131ab4a35d441ffec700ef5eeb7b49 Signed-off-by: Paul Pazderski <>
2019-06-25Using multi-catchLars Vogel3-34/+8
Change-Id: I3e6d10b933a4008797bd3d18efe7ce5cb98e16d9 Signed-off-by: Lars Vogel <>
2019-06-25Bug 548491 - [regression][mac] Cheese in java editorTill Brychcy7-19/+38
Change-Id: I32415326801837c10bc4fb6d7e18d832c20b3645
2019-06-24Bug 545846 - StyledText: wrong word selected on double-clickThomas Singer1-2/+11
Change-Id: Ie1ec7c848b937a9f577382f56aa00171f0c9f2a4 Signed-off-by: Thomas Singer <>
2019-06-24Bug 548577 - Upgrade severity of "Unused API problem filters" fromNiraj Modi1-1/+1
'Warning' to 'Error' for 'org.eclipse.swt' project Change-Id: I7e58a7d348e56fd852021d0542970acd03e856ac Signed-off-by: Niraj Modi <>
2019-06-24Bug 548190 - [API] Add color constants for disabled background andNiraj Modi1-0/+8
foreground colors - Fixing MANIFEST.MF file for API Tools warning. Change-Id: Ie6a958616d9664d5be15f0ac0626179a6fcdd9b7 Signed-off-by: Niraj Modi <>
2019-06-24Bug 474156 - Run API Tools builder in the Gerrit verification buildMickael Istria10-2/+19
Change-Id: I7e9f00f30fe69a610a59a16d697df43b74855723 Signed-off-by: Mickael Istria <>
2019-06-24Bug 548384 - [Win32] Simplify directory handling in TaskBarNikita Nemkin5-204/+25
Use Java IO instead of IFileOperation to create and clear the directory that stores JumpList icons. Change-Id: I784f4272ccfeafe845d66a794719e3f2d922a940 Signed-off-by: Nikita Nemkin <>
2019-06-21Bug 443089: Save Dialog doesn't handle files with multipart extensionsLakshmi Shanmugam6-49/+133
Reverted code changes made for Bug 347430. Don't use setAllowedFileType to set the filter extensions to the NSSavePanel as it doesn't support multi-part extensions such as tar.gz. Used delegate method panel:userEnteredFilename:confirmed: to handle the overwrite case when name field has filename without extension. Cocoa APIs in general don't support multi-part extensions. However, SWT FileDialog needs to support them. Hence, add the required extensions manually on save and selection change. Change-Id: I221f75476f1c1d263f64da239845c325b436bfca
2019-06-20Bug 548191: [GTK] Add color constant for disabled background andEric Williams2-1/+19
foreground colors Define COLOR_WIDGET_DISABLED_FOREGROUND and COLOR_TEXT_DISABLED_BACKGROUND on GTK. Added an entry to ControlExample's ColorTab. Tested on GTK3.24 and Fedora 30. Change-Id: Id2c3686225c0aa557f4e243b2634b6e3785d4fce Signed-off-by: Eric Williams <>
2019-06-20Bug 548286: [GTK] Clean up system color CSS parsingAlexandr Miloslavskiy4-426/+164
Remove GTK CSS parsing in favour of GtkStyleContext color extraction. Many thanks to Alexandr Miloslavskiy for his help with this effort! Change-Id: Id8dc44ec4116386c9b1bd2021c681c9a3923a35b Signed-off-by: Eric Williams <> Signed-off-by: Alexandr Miloslavskiy <>
2019-06-20Bug 538649 - [Win32] Accessibility: Toolbar buttons losing keyboard focusNikita Nemkin1-0/+3
SWT saves and restores the last highlighted toolbar item between focus changes (native behavior is to always highlight the first item). Fix the case when the saved item had been disabled. Change-Id: I5e142fed99ea014bb0532ebb99d02e44273d1f92 Signed-off-by: Nikita Nemkin <>
2019-06-19Bug 547227: [GTK3] Group widget causes memory leak and slowdownEric Williams4-3/+81
Do not call g_object_ref() before/after g_object_ref_sink(). GObject already adds a reference when calling g_object_ref_sink(). Tested using a child Eclipse, and the snippet provided. No AllNonBrowser JUnit tests fail. Test environment: Fedora 30, GTK3.24, Wayland. Change-Id: I3c6b0222e7342626439688883142cd646857a1ba Signed-off-by: Eric Williams <>
2019-06-19Bug 548327 - [Win32] Add color constants for disabled background andNiraj Modi1-1/+3
foreground colors Change-Id: I2e27455df945d7b24c14c8f6fa0ae905fc95f658 Signed-off-by: Niraj Modi <>
2019-06-19Bug 548320: [Mac] Add color constants for disabled background andLakshmi Shanmugam2-2/+11
foreground colors Initialize the new color constants. Update Snippet235. Change-Id: I898471760b16da6010d1aa124bb15d41641b57ad
2019-06-19Bug 548190: [API] Add color constants for disabled background andEric Williams5-3/+31
foreground colors Add COLOR_TEXT_DISABLED_BACKGROUND and COLOR_WIDGET_DISABLED_FOREGROUND fields in This facilitates work for bug 4745. Change-Id: I16716faa7dfdf7823cf020f1f006c05c400f5236 Signed-off-by: Eric Williams <>
2019-06-18Bug 548363 - Update JNI code with "contains" instead of "indexOf"Lars Vogel6-50/+50
Change-Id: Ifed0b4daac134d189b52cd1f2beab42e0e0079cd Signed-off-by: Lars Vogel <>
2019-06-18Bug 547986 - [GTK3] Table editor at first row not paintedSimeon Andreev3-20/+14
The fix for bug 535978 introduces a regression, namely first row editor table/tree editors are not drawn if the table/tree has a header. This is the case, since Composite.propagateDraw will lower the GTK+ window of children widgets, if their placement is "underneath" the table/tree header height. This is done to prevent widgets from being drawn on top of the table/tree header when the table/tree is scrolled down. The check whether the widget is placed "underneath" the header is done with the assumption that widgets in the table/tree client area have y values (of their GTK+ allocation) starting below the header (e.g. starting from 20+ pixels). However, those y values start with 0. As a result, widgets of the first row are always considered to be "underneath" the table/tree header and are so not painted. With this change, only widgets with negative y values are considered to be "underneath" the table/tree header. A negative y value (of the GTK+ allocation) results from scrolling down, since the widget (e.g. a table/tree editor) starts "before" the table/tree client area. As a result, the first row shows children widgets (such as editors) of tables/trees. When scrolling down, widgets become not visible as soon as part of them is covered by the table/tree header. This is not optimal (ideally they should be partially visible), but should be enough. The SWT mechanism to paint children (such as editors) in tables/trees does not use native GTK mechanism but builds on top. So drawing such children widgets partially is likely not possible or is very difficult. Change-Id: I06e125a874895c00c40d2ccfd147c9f6ed3bf210 Signed-off-by: Simeon Andreev <>
2019-06-18Bug 395296: [GTK] Incorrect ToolBar width on LinuxXi Yan7-0/+201
Set the "homogeneous" property to false by default for all ToolItems. This prevents a large ToolItem from dictating the size of all other ToolItems belonging to the same ToolBar. For some reason, this property is enabled by default in GTK3. Tested using a child Eclipse, the Git rebase interactive view, and the snippets attached to this Gerrit. No AllNonBrowser JUnit failures are observed. Environment: Fedora 30, GTK3.24. Change-Id: I437309217fb5e706bce04e82a63a227e1a2baef0 Signed-off-by: Eric Williams <>
2019-06-18Bug 548378: [Mac]Replace deprecated method used FileDialogLakshmi Shanmugam6-17/+50
Replace panel:shouldShowFilename: which has been deprecated in Mac 10.6. with NSOpenSavePanelDelegate.panel:shouldEnableURL: Change-Id: If2eba8a2b1bba959cda18a7ac56be5405d1ddfca
2019-06-18Bug 548277 - [Win32] Remove 32-bit code remnantsNikita Nemkin10-575/+32
Small structures passed by value use different convention between x86 and x64 ABI on Windows. We only need to conform to 64-bit ABI now. In particular, IAccessible required custom callback wrappers to convert by-value VARIANT structures to pointers. Under x64 ABI by-value VARIANTS actually are passed as pointers. Change-Id: I12efeddc3298f92367fd2739fb11f6fa572b31dd Signed-off-by: Nikita Nemkin <>
2019-06-18Bug 548277 - [Win32] Remove 32-bit code commentsNikita Nemkin277-14869/+9333
This change is completely automated. The script is attached to the issue. Change-Id: Iad1ce2378a76f0474800f3ef907b9d9fa657bfbe Signed-off-by: Nikita Nemkin <>
2019-06-18Use String.contains instead of indexOfLars Vogel8-21/+21
Change-Id: Ib5e9ae7e066f809a0223299b5708462fcf6b66f9 Signed-off-by: Lars Vogel <>
2019-06-18Bug 548364 - [win32] Compiler warning reported in swt.win32.win32.x86Niraj Modi1-2/+1
plugin Change-Id: Icf876bb7435930995224a80cc113921de7cbf767 Signed-off-by: Niraj Modi <>
2019-06-17Update "build natives for Win32" part of SWT ReadmePaul Pazderski1-6/+6
Change-Id: Ia20ac7e53f35b81fd5888d37566d696b5aa6ea0f Signed-off-by: Paul Pazderski <>
2019-06-17Bug 548332 - bundles/org.eclipse.swt/.settings/.api_filters changed byLars Vogel1-32/+0
the build I constantly see bundles/org.eclipse.swt/.settings/.api_filters changed by the build. To avoid this the change has been committed This should be validated by a core SWT developer before the merge. Change-Id: I3565c75ebe4fc04589f08559cbc0c4da061e927a Signed-off-by: Lars Vogel <>
2019-06-17StringBuilder instead of StringBufferLars Vogel4-5/+5
Change-Id: Ie88ea44706483cbe2d1004ca201c38c3213dc5cf Signed-off-by: Lars Vogel <>
2019-06-174.13 update for org.eclipse.swt.examples.browser.demosLars Vogel2-2/+2
Required for Change-Id: If91ee7f616543593529855e4b154704cf78d36e7 Signed-off-by: Lars Vogel <>

Back to the top