Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-06-21Bug 443089: Save Dialog doesn't handle files with multipart extensionsLakshmi Shanmugam6-49/+133
Reverted code changes made for Bug 347430. Don't use setAllowedFileType to set the filter extensions to the NSSavePanel as it doesn't support multi-part extensions such as tar.gz. Used delegate method panel:userEnteredFilename:confirmed: to handle the overwrite case when name field has filename without extension. Cocoa APIs in general don't support multi-part extensions. However, SWT FileDialog needs to support them. Hence, add the required extensions manually on save and selection change. Change-Id: I221f75476f1c1d263f64da239845c325b436bfca
2019-06-20Bug 548191: [GTK] Add color constant for disabled background andEric Williams2-1/+19
foreground colors Define COLOR_WIDGET_DISABLED_FOREGROUND and COLOR_TEXT_DISABLED_BACKGROUND on GTK. Added an entry to ControlExample's ColorTab. Tested on GTK3.24 and Fedora 30. Change-Id: Id2c3686225c0aa557f4e243b2634b6e3785d4fce Signed-off-by: Eric Williams <>
2019-06-20Bug 548286: [GTK] Clean up system color CSS parsingAlexandr Miloslavskiy4-426/+164
Remove GTK CSS parsing in favour of GtkStyleContext color extraction. Many thanks to Alexandr Miloslavskiy for his help with this effort! Change-Id: Id8dc44ec4116386c9b1bd2021c681c9a3923a35b Signed-off-by: Eric Williams <> Signed-off-by: Alexandr Miloslavskiy <>
2019-06-20Bug 538649 - [Win32] Accessibility: Toolbar buttons losing keyboard focusNikita Nemkin1-0/+3
SWT saves and restores the last highlighted toolbar item between focus changes (native behavior is to always highlight the first item). Fix the case when the saved item had been disabled. Change-Id: I5e142fed99ea014bb0532ebb99d02e44273d1f92 Signed-off-by: Nikita Nemkin <>
2019-06-19Bug 547227: [GTK3] Group widget causes memory leak and slowdownEric Williams4-3/+81
Do not call g_object_ref() before/after g_object_ref_sink(). GObject already adds a reference when calling g_object_ref_sink(). Tested using a child Eclipse, and the snippet provided. No AllNonBrowser JUnit tests fail. Test environment: Fedora 30, GTK3.24, Wayland. Change-Id: I3c6b0222e7342626439688883142cd646857a1ba Signed-off-by: Eric Williams <>
2019-06-19Bug 548327 - [Win32] Add color constants for disabled background andNiraj Modi1-1/+3
foreground colors Change-Id: I2e27455df945d7b24c14c8f6fa0ae905fc95f658 Signed-off-by: Niraj Modi <>
2019-06-19Bug 548320: [Mac] Add color constants for disabled background andLakshmi Shanmugam2-2/+11
foreground colors Initialize the new color constants. Update Snippet235. Change-Id: I898471760b16da6010d1aa124bb15d41641b57ad
2019-06-19Bug 548190: [API] Add color constants for disabled background andEric Williams5-3/+31
foreground colors Add COLOR_TEXT_DISABLED_BACKGROUND and COLOR_WIDGET_DISABLED_FOREGROUND fields in This facilitates work for bug 4745. Change-Id: I16716faa7dfdf7823cf020f1f006c05c400f5236 Signed-off-by: Eric Williams <>
2019-06-18Bug 548363 - Update JNI code with "contains" instead of "indexOf"Lars Vogel6-50/+50
Change-Id: Ifed0b4daac134d189b52cd1f2beab42e0e0079cd Signed-off-by: Lars Vogel <>
2019-06-18Bug 547986 - [GTK3] Table editor at first row not paintedSimeon Andreev3-20/+14
The fix for bug 535978 introduces a regression, namely first row editor table/tree editors are not drawn if the table/tree has a header. This is the case, since Composite.propagateDraw will lower the GTK+ window of children widgets, if their placement is "underneath" the table/tree header height. This is done to prevent widgets from being drawn on top of the table/tree header when the table/tree is scrolled down. The check whether the widget is placed "underneath" the header is done with the assumption that widgets in the table/tree client area have y values (of their GTK+ allocation) starting below the header (e.g. starting from 20+ pixels). However, those y values start with 0. As a result, widgets of the first row are always considered to be "underneath" the table/tree header and are so not painted. With this change, only widgets with negative y values are considered to be "underneath" the table/tree header. A negative y value (of the GTK+ allocation) results from scrolling down, since the widget (e.g. a table/tree editor) starts "before" the table/tree client area. As a result, the first row shows children widgets (such as editors) of tables/trees. When scrolling down, widgets become not visible as soon as part of them is covered by the table/tree header. This is not optimal (ideally they should be partially visible), but should be enough. The SWT mechanism to paint children (such as editors) in tables/trees does not use native GTK mechanism but builds on top. So drawing such children widgets partially is likely not possible or is very difficult. Change-Id: I06e125a874895c00c40d2ccfd147c9f6ed3bf210 Signed-off-by: Simeon Andreev <>
2019-06-18Bug 395296: [GTK] Incorrect ToolBar width on LinuxXi Yan7-0/+201
Set the "homogeneous" property to false by default for all ToolItems. This prevents a large ToolItem from dictating the size of all other ToolItems belonging to the same ToolBar. For some reason, this property is enabled by default in GTK3. Tested using a child Eclipse, the Git rebase interactive view, and the snippets attached to this Gerrit. No AllNonBrowser JUnit failures are observed. Environment: Fedora 30, GTK3.24. Change-Id: I437309217fb5e706bce04e82a63a227e1a2baef0 Signed-off-by: Eric Williams <>
2019-06-18Bug 548378: [Mac]Replace deprecated method used FileDialogLakshmi Shanmugam6-17/+50
Replace panel:shouldShowFilename: which has been deprecated in Mac 10.6. with NSOpenSavePanelDelegate.panel:shouldEnableURL: Change-Id: If2eba8a2b1bba959cda18a7ac56be5405d1ddfca
2019-06-18Bug 548277 - [Win32] Remove 32-bit code remnantsNikita Nemkin10-575/+32
Small structures passed by value use different convention between x86 and x64 ABI on Windows. We only need to conform to 64-bit ABI now. In particular, IAccessible required custom callback wrappers to convert by-value VARIANT structures to pointers. Under x64 ABI by-value VARIANTS actually are passed as pointers. Change-Id: I12efeddc3298f92367fd2739fb11f6fa572b31dd Signed-off-by: Nikita Nemkin <>
2019-06-18Bug 548277 - [Win32] Remove 32-bit code commentsNikita Nemkin277-14869/+9333
This change is completely automated. The script is attached to the issue. Change-Id: Iad1ce2378a76f0474800f3ef907b9d9fa657bfbe Signed-off-by: Nikita Nemkin <>
2019-06-18Use String.contains instead of indexOfLars Vogel8-21/+21
Change-Id: Ib5e9ae7e066f809a0223299b5708462fcf6b66f9 Signed-off-by: Lars Vogel <>
2019-06-18Bug 548364 - [win32] Compiler warning reported in swt.win32.win32.x86Niraj Modi1-2/+1
plugin Change-Id: Icf876bb7435930995224a80cc113921de7cbf767 Signed-off-by: Niraj Modi <>
2019-06-17Update "build natives for Win32" part of SWT ReadmePaul Pazderski1-6/+6
Change-Id: Ia20ac7e53f35b81fd5888d37566d696b5aa6ea0f Signed-off-by: Paul Pazderski <>
2019-06-17Bug 548332 - bundles/org.eclipse.swt/.settings/.api_filters changed byLars Vogel1-32/+0
the build I constantly see bundles/org.eclipse.swt/.settings/.api_filters changed by the build. To avoid this the change has been committed This should be validated by a core SWT developer before the merge. Change-Id: I3565c75ebe4fc04589f08559cbc0c4da061e927a Signed-off-by: Lars Vogel <>
2019-06-17StringBuilder instead of StringBufferLars Vogel4-5/+5
Change-Id: Ie88ea44706483cbe2d1004ca201c38c3213dc5cf Signed-off-by: Lars Vogel <>
2019-06-174.13 update for org.eclipse.swt.examples.browser.demosLars Vogel2-2/+2
Required for Change-Id: If91ee7f616543593529855e4b154704cf78d36e7 Signed-off-by: Lars Vogel <>
2019-06-14Bug 547304 - [cleanup] Fix wrong space/tab indentationPaul Pazderski354-6441/+6441
This change fixes space or mixed tab/space indentations in all Java files. This also includes two or three space indentations and even fix most stray single spaces in indentations. The change includes only whitespace formatting and no code changes. Change-Id: Ib7b260691acee06845cc580dd8cb859de0da8bf1
2019-06-144.13 version updates ofPaul Pazderski6-6/+6
org.eclipse.swt.examples org.eclipse.swt.examples.launcher org.eclipse.swt.examples.ole.win32 Required for Change-Id: I0a7483d7cee3afe10e719e51e7568c9292f55094
2019-06-14Bug 548290 - Remove swt tools check 32/64 functionalityAlexander Kurtakov5-447/+2
SWT is 64bit only now so this just clutters the UI. Bump minor to reflect removal of this feature. Change-Id: I57bbbd1bfdc673e6e4c91787d8d7d137ad0f558c Signed-off-by: Alexander Kurtakov <>
2019-06-14Stop using deprecated number constructors.Alexander Kurtakov5-25/+25
Change-Id: I2e5be7b507b5e0363c4be900bba6b1d716c0b170 Signed-off-by: Alexander Kurtakov <>
2019-06-14Bug 547375: [GTK] Display.getBounds() returns wrong values for mostEric Williams2-16/+46
multi monitor setups Re-work the Display.getBounds() functionality to account for different monitor layouts, resolutions, and more. Tested on GTK3.24 with Wayland and various screen layouts. No AllNonBrowser JUnit tests fail. Change-Id: I7b7c8493e26d386031b67a889588d3ea88e95cf3 Signed-off-by: Eric Williams <>
2019-06-14Bug 547475 - [Win32] Remove redundant COM interface vtablesNikita Nemkin5-269/+20
In case of COM interface inheritance, derived interface vtable (COMObject instance) can be reused as a base interface vtable. This reuse doesn't affect object behavior in any way. Affected interfaces and their bases: * IAccessible2 : IAccessible * IAccessibleHyperlink : IAccessibleAction * IAccessibleHypertext : IAccessibleText * IEnumFORMATETC : IUnknown * IDIOleClientSite : IUnknown * IPropertyNotifySink : IUnknown Change-Id: If6b3bcdbe1515d75d561e5e7dca9d8cb6f8a93ba Signed-off-by: Nikita Nemkin <>
2019-06-14Bug 547192 - [Cocoa] Replace deprecated Carbon functions (Part 1)Nikita Nemkin16-21/+227
Deprecated function | Modern equivalent ------------------------------------------------------------------- Gestalt | NSProcessInfo.operatingSystemVersion GetDblTime | NSEvent.doubleClickInterval GetCurrentEventButtonState | NSEvent.pressedMouseButtons ATSFontActivateFromFileReference | CTFontManagerRegisterFontsForURL Change-Id: I7ba3e3da6c73117bc7800d022b8eba9fb3cc907a Signed-off-by: Nikita Nemkin <>
2019-06-14Bug 548198 - Remove BREE from non-Java bundles in platformLars Vogel1-1/+0
Change-Id: I460a185d52d39ff165b27863e9ce9768825a6c28 Signed-off-by: Lars Vogel <>
2019-06-134.13 version update of Vogel2-2/+2
Required for Change-Id: I3ea9cd47344897e61d1331b223fe5c8f5ad1dfaa Signed-off-by: Lars Vogel <>
2019-06-134.13 version update for Vogel2-2/+2
Required for Bug 548198 Change-Id: I8de80237439e7924f8bf74860bd7c2f319e719e4 Signed-off-by: Lars Vogel <>
2019-06-12Bug 545226 - [GTK3] GC transforms don't affect GC.getClipping()Simeon Andreev2-1/+177
Changes done to fix bug 531667 and follow-up problems introduce a regression. Namely, the result of GC.getClipping() is incorrect. Drawing is correct, but the bounds returned by GC.getClipping() are not affected by transformations set by the user on the GC object. This is not consistent with previous behaviour and with behaviour on other platforms (e.g. Windows 10). This change re-adds the necessary transformations, in order to have a consistent GC.getClipping() result. A snippet is added that showcases the problem. Change-Id: I33b06bb8338215f52cb02d248564b792a750067e Signed-off-by: Simeon Andreev <>
2019-06-12Bug 293230 - [Win32] Support SWT.ICON_SEARCH/CANCEL Text stylesNikita Nemkin10-22/+226
This reverts commit a551d9cf6c769c4e64f0c41f5cba6c7e8ef9d193. Change-Id: I92edf6a5dfd46b09547b2f97eaf5102c2663cd9c
2019-06-12Revert "Bug 293230 - [Win32] Support SWT.ICON_SEARCH/CANCEL Text styles"Niraj Modi10-226/+22
- Reverting the change to fix the author. This reverts commit bf374552cac5b50f6b86727909611fb3d0aafce9. Change-Id: Ie132e0fe1356d676ea8c7c46bd1cdbaf44292811

Back to the top