Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2018-12-12Bug 541381: [GTK4] Replace gtk_container_get_border_width()Eric Williams1-2/+2
Fix up certain margin calls to prevent stack overflow. Change-Id: I6ba117b27961127ee8a283a7da0cafd587640e18 Signed-off-by: Eric Williams <>
2018-12-12Bug 541381 - [GTK4] Replace gtk_container_get_border_width()Xi Yan11-21/+330
Replaced with gtk_widget_get_margin_*. Change-Id: I38a78ea6eb8cc5c8724d07fd8462fd8d8b3b0e88 Signed-off-by: Xi Yan <>
2018-12-12Bug 540841: [GTK4] Rename GdkWindow to GdkSurfaceEric Williams2-4/+4
Fix typo that prevents GTK4 bindings compilation. Change-Id: Ie754dea389350563dfef186dfd9051e0adee4b68 Signed-off-by: Eric Williams <>
2018-12-12Bug 542712 - 32-bit compile checks still run for Gerrit jobsAlexander Kurtakov1-8/+0
Stop calling the 32 bit compiles in check_compilation_all_platforms. As the target is used only for gerrit builds it would not affect people building on 32 bit. Although they may encounter missing 64to32 pointer comments in the code . Change-Id: I8d9e62ce68725bcdf3b541672ebe11a2e1037d5e Signed-off-by: Alexander Kurtakov <>
2018-12-12Run tests with surefire 2.20.1.Alexander Kurtakov1-1/+1
Change-Id: I90ea31ce5e396ecc7c7ebae79f781b3811054f06 Signed-off-by: Alexander Kurtakov <>
2018-12-11Bug 540841: [GTK4] Rename GdkWindow to GdkSurfaceEric Williams28-344/+956
Rename GdkWindow to GdkSurface, part 2 (4.11). Change-Id: I7bcb17d4c88b9f22cf75fc2faa4f0de7a6129386 Signed-off-by: Eric Williams <>
2018-12-11Bug 541862: [GTK3] Increase minimum GTK3 version to 3.10Eric Williams21-271/+38
Remove old 3.8 and below code. Change-Id: Ib3cb77939a7146396c36e982a93e135b18318855 Signed-off-by: Eric Williams <>
2018-12-11Bug 539761 - [GTK3.24] Replace deprecated g_type_class_add_private()Xi Yan1-18/+20
Replace g_type_class_add_private with G_ADD_PRIVATE. Replace G_TYPE_INSTANCE_GET_PRIVATE with *_get_instance_private Change-Id: Iac418463335d28d21750f0a97074dc90d872c3d6 Signed-off-by: Xi Yan <>
2018-12-11Bug 532074 - [Wayland] Arrow menu from fast view pops up in wrongXi Yan1-2/+20
location setLocation method is limited on Wayland since we cannot use gdk_popup_at_rect if GdkWindow of the shell is not mapped. When the Problems View is a fast view on Eclipse start, the drop down menu takes PartRenderingEngine's limbo shell (see PartRenderingEngine#safeCreateGui) as the parent shell which is off the screen. The limbo shell's GdkWindow cannot be used on Wayland to popup the menu at a relative location. In this case, we open the menu at the pointer to avoid it being positioned in the wrong location. Change-Id: Ifa120a0e68e0d012b09c1f4806dc959bb447b8f2 Signed-off-by: Xi Yan <>
2018-12-11Revert "Revert "Bug 541854 - [Wayland] Ctrl+1 popup issues""Xi Yan2-73/+57
This reverts commit c88920365b95e77e6369a9a1626007d4d24fe97f. Change-Id: I0e831ecec4754a7edfeb1c4957f88418b5463454
2018-12-11Bug 541378: [GTK4] Implement GtkWindow "close-request" signalEric Williams5-12/+39
Use close-request on GTK4 to release/dispose of Widgets when the user clicks the "X" button of a Shell. Change-Id: Ic8dc4b2f53b63d7faf7069accdcb6703e93fcdc8 Signed-off-by: Eric Williams <>
2018-12-11Bug 542475 - [GTK3] DateTime date decreases when focusing outXi Yan2-7/+63
Same issue as bug 538648 with the SWT.MEDIUM style on US locale. Modified previous patch to account for all cases where Month as string is the first field in DateTime spinner. When using SWT.SHORT | SWT.DATE on US locale, increment arrow increases date by 2 and decrement arrow doesn't work. This is because new_value from calendar have month between 0-11 while the adj_value have month betwene 1-12. Fix is to shift adj_value by 1 offset so that we get the correct arrow direction. This doesn't happen if DATE is the first value (i.e. using Canada locale) Change-Id: I52c5ef02e936a89d66566032aff437d165ceb289 Signed-off-by: Xi Yan <>
2018-12-11Bump versions for 4.11 stream.Alexander Kurtakov5-6/+6
Change-Id: I36ed391a09e9e09fe55aaa7acd1df6d701a2397f Signed-off-by: Alexander Kurtakov <>
2018-12-11Bug 541819 - Configure SWT build scripts for 4.11Sravan Kumar Lakkimsetti1-3/+3
Change-Id: I2b30a35dc48c1291fa8190149dadfef35a339be6 Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-12-11Bug 541819 - Configure SWT build scripts for 4.11Sravan Kumar Lakkimsetti2-3/+3
Change-Id: I2284d3a9c38bee4596bba23a0278746efbd0d6dc Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-12-08Bug 541819 - Configure SWT build scripts for 4.11Sravan Kumar Lakkimsetti1-4/+4
Change-Id: I9b1daf09b1b175e7866e80558e709d50124e0a04 Signed-off-by: Sravan Kumar Lakkimsetti <>
2018-12-07Bug 541822 - POM and product version change for 4.11 releaseAlexander Kurtakov18-19/+18
Change-Id: I8454243e87078b718102ce58702c08fe8f9f163c Signed-off-by: Alexander Kurtakov <>
2018-12-06Revert "Bug 541854 - [Wayland] Ctrl+1 popup issues"Xi Yan2-57/+73
This reverts commit 3615a6bf1b910747186515b2526504f91dbe4dae. Change-Id: I16fc9137a5380e7e3f7851fe5710b8a22cc68ee8
2018-12-06Bug 541854 - [Wayland] Ctrl+1 popup issuesXi Yan2-73/+57
Attempting to address all popup related issue (see bug 542104). 1) Patch to bug 515773 ungrabbed focus when shell is hidden in setVisible(false) and used showing/hiding hack to avoid being stuck with no focus, which introduced some of the related issues. Rewrote logic to ungrab focus after shell is disposed. - Removed showing/hiding hack that uses callback to show shell in bringToTop(). - Addressed different cases for single popup and popups attached to a parent popup. - Added additional guard to ungrab the grabbed focus.. 2) Patch to bug 540166 uses callback connected to gtk destroy signal which causes crash in Flatpak due to invalid child handle passed to the callback. Workaround is to move the logic to SWT level by keeping track of the child popup shell of a parent popup shell, and dispose the child popup whenever the parent popup shell is disposed. Known limitation: - For the auto-completion, if you switch focus to the details page using Tab, clicking on an item on the list page will close the auto-completion popup instead of highlighting the list item. This is because we ungrab the focus whenever user clicks outside the focused popup window (in this case its the details page) to avoid being stuck without focus. This means we can only switch between list item using the mouse when the details page is not in focus (i.e. hit Esc first to bring focus back to the list item before clicking list item). - However, we should not fix this with the show/hide hack because with the show/hide hack, hitting Esc does not work when focus is switched to the details page using Tab. See bug 542104 comment #2 for test cases. Change-Id: I4ba90afdf9664e6858aa3c28cf51825f85171a76 Signed-off-by: Xi Yan <>
2018-12-04Bug 542101: [GTK3] Increase minimum GTK3 version to 3.8.0Eric Williams1-1/+1
Bump minimum version to 3.8.0 to avoid JVM symbol lookup errors for an a11y macro which was not public before 3.8.0. Change-Id: Ia9cbca30070907ab9904fdf75c195fa76ff29488 Signed-off-by: Eric Williams <>
2018-12-03Bug 540801: [GTK4] Build SWT on GTK4Eric Williams1-5/+5
Make GTK3 default for now until GTK4 is stable. Change-Id: I4449fcf496d599dd9cd4f76696e8ca364b4b3cd9 Signed-off-by: Eric Williams <>
2018-12-03Bug 541631 - Do the Javadoc bash for 4.10Niraj Modi19-55/+68
Change-Id: I5d5db7dfba13e9c79193c705b3936a3631682e33 Signed-off-by: Niraj Modi <>
2018-11-30Bug 541720 - [Gtk3] Regression: TableColumn.pack() clears header in 4.9Xi Yan2-1/+87
Previous patch ( )fixes table appearing as thin line by always showing the table before getting the preferred size, and hiding it afterwards. This caused a regression that when the second time pack() is called, it always hides the header. This patch fixes this by only hiding the header when it is not suppose to be visible. Change-Id: I7cbe06cb36a7ae7b18a52010361f5c575d88ff0b Signed-off-by: Xi Yan <>
2018-11-26Bug 518080 - Use GtkSearchEntry instead of gtkEntry + iconXi Yan1-0/+11
Add padding for GtkSearchEntry Change-Id: Ic27f154bd505ac49df2451ffa67b94f513f868e6 Signed-off-by: Xi Yan <>
2018-11-26Bug 541185 - [Wayland] Help popup close after a clickXi Yan1-0/+1
Reset ignorFocusOutAfterGrab flag, missed by previous patch. Change-Id: I67a206ce08716bc859f1976ddd0ff4bfe269f5e5 Signed-off-by: Xi Yan <>
2018-11-26Bug 541185 - [Wayland] Help popup close after a clickXi Yan2-11/+26
1) Wayland sends an extra focus out event when clicking into the popup after grabbing keyboard focus, which causes popup to be closed. Workaround is to ignore this extra focus out event to fix the issue with javadoc close after a click. 2) Current workaround that hides shell before grabbing focus is not necessary for normal popups without a child. Deal with the case a popup has a popup child separately in bringToTop(). This patch fixes the issue with clicking into Javadoc links, and highlighting text in Javadoc popups. However, there is still some remaining issues (perhaps unrelated) with auto-completion: use Tab to switch focus to the completion details page, clicking works but highlighting the text closes the popup. (but this issue doesn't happen if we use mouse to switch focus to completion details page) Change-Id: Ic095b64c2eaafdeeca65b6e61937c7d31256c97f Signed-off-by: Xi Yan <>
2018-11-24Bug 540841: [GTK4] Rename GdkWindow to GdkSurfaceAlexander Kurtakov1-1/+0
Fix compile warning. Change-Id: I4602a98d98c31437791eb7aace8d77548a3a26c7 Signed-off-by: Alexander Kurtakov <>
2018-11-23Bug 541107: [GTK4] Port native SwtFixed code to GTK4Eric Williams2-2/+11
Disable swt_fatal_warnings on GTK4 as it relies on gtk_parse_args() which does not exist on GTK4. Change-Id: I0f3027ea60221242f7b2d5c97e666f48de8952d2 Signed-off-by: Eric Williams <>
2018-11-23Bug 541107: [GTK4] Port native SwtFixed code to GTK4Eric Williams8-0/+568
Contribute SwtFixed native test snippet for GTK4. Change-Id: If3bc3d4f8a863521e4c313ad7cb4946e821d0326 Signed-off-by: Eric Williams <>
2018-11-23Bug 518080 - Use GtkSearchEntry instead of gtkEntry + iconXi Yan5-21/+80
Use GtkSearchEntry, removed code to handle "clear" icon press events, workaround default look to support search entry without icons. Change-Id: Id29044f5b1f362841048cb4ada2c4c4854f26953 Signed-off-by: Xi Yan <>

Back to the top