Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-04-25Bug 533833 – [Webkit2] Should not use G_TYPE_CHECK_INSTANCE_TYPE(..)I20180425-1650Leo Ufimtsev2-23/+29
I adopted the code so that webkit2 no longer uses the macro. But I didn't take the time to remove it's use from webkit1 as I don't think it's worth the time. I left some notes warning not to use the macro. Upon removal of webkit1, it should be removed. Tests: - Fedora 27, Webkit2.18, jUnits & child eclipse. - Not tested on webkit1, but should work as there are no logic changes. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533833 Change-Id: I825825c02413a35592dcf3e21114ed774cf146f0 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-24v4875v4875I20180425-1455I20180425-0910I20180425-0725I20180425-0505I20180425-0250I20180424-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-24v4875Eclipse Platform RelEng Bot3-4/+4
2018-04-24Bug 480639: Provide monitor-specific DPI scaling / zoom levelLakshmi Shanmugam1-0/+11
Added JUnit test for Monitor.getZoom() API Change-Id: I67430320238f6ba6ea0a16001a260537e4385f34
2018-04-24Bug 480639: [HiDPI][API] Provide monitor-specific DPI scaling / zoomLakshmi Shanmugam5-1/+87
level GTK Monitor.getZoom() implementation Change-Id: If95004e85a2cfdc53223f03675a501556e0038f8
2018-04-23v4874v4874eI20180423-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-23Bug 533677 - [win32] calling Browser#refresh does not callLars Vogel1-0/+21
ProgressListener#completed Adds test to ensure a completed listener is called Change-Id: Ice4e6cbfa7ce2cc57a58739430581df56bd0ccb2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-23v4874v4874dI20180423-0655Eclipse Platform RelEng Bot1-1/+1
2018-04-23Bug 533818 - Improve the Oomph setups for the platform projectsI20180423-0640Ed Merks1-1/+14
When all target platforms are resolved, projects from the eclipse.platform.swt.binaries repo are imported but they have errors. Change the source locator to exclude all platform-specific projects and then include only the one project for the current specific platform. Change-Id: Ic1d6e1fa08fff77846dfb9027ffb74c7f90ed11a Signed-off-by: Ed Merks <ed.merks@gmail.com>
2018-04-23Bug 533677 - [win32] calling Browser#refresh does not callLars Vogel1-1/+0
ProgressListener#completed Change-Id: Ic600baac1a96c70105fec1e871e5a881191af945 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-21v4874v4874cI20180422-2000I20180421-1500Eclipse Platform RelEng Bot1-1/+1
2018-04-21Bug 533818 - Improve the Oomph setups for the platform projectsEd Merks1-63/+39
Ensure that the commit message includes a change ID. Improve the dynamic working sets. Simplify the targlets based on moving dependencies up to Platform.setup. Change-Id: I992d11fa21b545f1b735954d288d72cced3754b3 Signed-off-by: Ed Merks <ed.merks@gmail.com>
2018-04-20v4874v4874bI20180420-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-20Bug 533799 - shrinking trees/tables can cause errors on standard errorSimeon Andreev4-24/+143
Resizing a GTK tree view so that the column header and the horizontal scrollbar overlap causes pixman bug error messages on standard error. Using standard GTK3 API, it doesn't seem possible to resize the table the tree view in such a way. SWT on the other hand allows this. This change ensures that the SWT fixed which contains the tree or table is resized as requested by resize operation, while the tree or table retains some minimum height to avoid the error. In result, parts of the horizontal scrollbar are no longer visible, when the tree or table is shrinked below about 40px, the column headers and the horizontal scrollbar are visible. Change-Id: I3b39596a0f4eba3e1bbb259ab30d9d8744bb62c1 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-04-20Bug 533815 - starting Eclipse prints GTK warnings on standard errorSimeon Andreev2-2/+9
On Eclipse start with GTK 3.22, 4 GTK warnings of 2 different types are printed on the standard error. First, StatusLine layout will resize its progress bar to have 0 width. This width is then set to 1 by Control.setBounds. Once this width is propagated to the GTK progress bar widget, warnings are emitted on the standard error since there isn't enough drawing width for the progress bar. Second, a shell resize causes GTK to warn of resize without knowing preferred natural size. This change ensures that the width which is propagated to the progress bar is at least 2, to avoid the negative content width warnings. Additionally, it asks the shell wrapping box about its natural size, avoiding the other warnings. Change-Id: Ia87c7786c78d20d0ed33dfe4b635c55f75653c5e Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-04-20Bug 533722: [Mac]Custom cursor without transparency not shownLakshmi Shanmugam1-4/+7
If ImageData doesn't have alpha, set alpha to false in nsImageRep.initWithBitmapDataPlanes. Change-Id: If2b932e04940869ec0ffbb3de690568d4c287b08
2018-04-19v4874v4874aI20180419-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-19Bug 525946 [Webkit2] Port download functionality (rewrite some logic)Leo Ufimtsev4-129/+199
G_TYPE_CHECK_INSTANCE_TYPE is not a reliable method to check if type is webview or webcontext at run time. On my & Roland's system it works, but on Andrey's system it miss-fires. This is a macro and by the looks is not reliable method because we use it with dynamically loaded libraries and via JNI. Solution: Rewrite the callback logic to determine types of callback based on user_data instead of relying on type checking macro. Also, created task to remove usage of the macro to prevent simmila issues: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533833 Tests: - Environment: Webkit2 2.18, Gtk3.22, Fedora 27, wayland on host, x11 eclipse backend. - JUnit AllBrowserTests - ChildEclipse. - Bug Snippet attached to this patch. - Also tested with webkit1. - Andrey reports that this patch fixes his crash issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533545#c34 Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5259462 Change-Id: I485a54804285dbf114961422799ea34796413404 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-17v4874v4874I20180418-2000I20180417-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-17v4874Eclipse Platform RelEng Bot3-4/+4
2018-04-17Bug 533660 - Use method reference forLars Vogel1-22/+21
Test_org_eclipse_swt_browser_Browser#waitForPassCondition calls Change-Id: Ib4b4f6b8d94781378dfe7a0172d17977c369321f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-17Bug 533557 - [Win32] Remove workaround for Adobe Reader 7.0Nikita Nemkin1-23/+0
Adobe Reader 7.0 (released in 2005) isn't available anymore. The bug is not reproducible with Reader 11.0 and later. Original bug 56184. Change-Id: I9c5c6ecc9ca59ea307f7d78bb700d95f058b88ed Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
2018-04-17Bug 533556 - [Win32] Fix compiler warning in native codeNikita Nemkin2-2/+2
os_structs.c(4456): warning C4133: '=': incompatible types - from 'HBRUSH' to 'HPEN' Signed-off-by: Nikita Nemkin <nikita@nemkin.ru> Change-Id: I644248039facc38e42a8dbf387b5aeabb231ec70
2018-04-16v4873v4873I20180416-2000Eclipse Platform RelEng Bot1-1/+1
2018-04-16v4873Eclipse Platform RelEng Bot3-4/+4
2018-04-16Bug 533562 - [Win32] Clean up native headersNikita Nemkin2-175/+3
* Remove unnecessary includes. * Do not duplicate declarations available in the SDK. * Use wsprintf from user32 to save a few KB in SWT DLL. Change-Id: Ib2e9424547e56c09c60b05e494b85f75b12f99c1 Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
2018-04-16Bug 529431: [GTK3.10+] Snippet294 fails to draw RegionEric Williams10-4/+97
Fix input handling for GTK3.10+ setRegion behaviour. This does a manual check to see if the incoming event coordinates are within the set region: if they are, ignore them. This prevents events like SWT.Selection, SWT.Mouse[Up/Down], etc. from triggering when they are spawned from within the set region. There are two main limitations though: 1) we cannot stop native GTK events as we are doing the region drawing on the SWT level. This means things like mouse enter/leave, button pre-light, etc. will still be visible. We block the selection/click events at the SWT level, but unfortunately there is no reliable way to block these on the GTK level. 2) we also can't block all selection events, as some widgets are selectable using the keyboard (which has no coordinates). This means we could potentially block out selection events that *should* be sent. Tested on GTK3.22, no AllNonBrowser JUnit test failures. Change-Id: Ifd8377feb7d71a366edcdf6083d2bc94ab779886 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-16Bug 533533 - [GTK3] Provide a way to disable fix for Control.print()Simeon Andreev3-14/+37
Bug 531667 reports a defect in Canvas.pring(GC). The fix provided for 531667 exposes a number of problems which were initially fixed for Bug 421127 (while breaking Canvas.pring(GC)). These problems were originally caused by breaking API change between GTK 3.09 and GTK 3.10. The known problems were fixed also in the context of Bug 531667. Since the GTK API change has massive implications for SWT, there may be further undiscovered defects. This change provides a switch for the fixes done for Bug 531667, as a last resort in case of severe defects that cannot be fixed (e.g. due to a platform which cannot be changed). The fixes can be deactivated by specifying -Dorg.eclipse.swt.internal.gtk.cairoContextReuse=false in the command line arguments of Eclipse (e.g. via eclipse.ini). Change-Id: I7722a1bb4afb4bf54ba2a6a1613c51de867ee0d9 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-04-16Bug 306530: ImageLoader Javadoc should warn about performance impactEric Williams1-1/+7
Update Javadoc to warn about performance issues in ImageLoader. Change-Id: Ic00f21723ce69e587100eae448efb35afd1031d6 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-16Bug 533496: Add mechansim to find 32 bit java in GTK build.shLakshmi Shanmugam1-1/+1
changed $(JAVA_HOME) to ${JAVA_HOME} Change-Id: I4bc6fd655ea89092f01f059d308ca969a1aca28f
2018-04-16v4872v4872I20180416-0305Eclipse Platform RelEng Bot1-1/+1
2018-04-16v4872Eclipse Platform RelEng Bot3-4/+4
2018-04-15Bug 318942 - [OLE] new OleAutomation(progId) fails because of missing flagI20180415-2000Nikita Nemkin1-2/+1
If an in-process COM server is not available, try to create a local server. (CoCreateInstance will check InprocServer32, LocalService in that order). This change allows OleAutomation to interact with MS Office applications, Internet Explorer etc. Change-Id: Iae1d8ccfc74a2d993407144b8077b4c7be6556d1 Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
2018-04-14Bug 533558 - [Win32] Remove redundant display checks in Tray, TaskBarI20180414-1500Nikita Nemkin2-10/+0
Tray and TaskBar are created by Display. They are guaranteed to receive a non-null, thread-valid display reference. Change-Id: I429511c15fefdfd0d4106b9d1b87a625ab45c626 Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
2018-04-14Bug 335054 - [Win32] Hand cursor over link widget gets stuckNikita Nemkin1-2/+12
SysLink window procedure doesn't set cursor over non-link areas because those areas are transparent for mouse events (using WM_HITTEST). Link widget overrides WM_HITTEST in order to receive mouse events, which means it's responsible for setting cursor over previously mouse-transparent areas. Change-Id: I9d8f58ea969b8abb407f4b1558cd8f6f062358b8 Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
2018-04-14Suppress deprecation warning.Alexander Kurtakov1-1/+2
In test of deprecated method. Change-Id: I07be2e39a69b3e926cf496f7955104d30880bc38 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-04-13Bug 533124 - Allow multi line text in CTabFolder.I20180413-2000ncazottes4-2/+71
CTabFolderRenderer with flag that take into account carriage return for multi line. Addition of Snippet371. Addition of Javadoc on CTabItem.setText. Addition of same cross platform behavior relating to the drop-down menu for additional tabs. Change-Id: Ib45891dcc90727830262887745c8ec1ad9be451d Signed-off-by: ncazottes <nicolas@cazottes.net>
2018-04-13Bug 529126: [Wayland][GTK3] Tree does not notify SWT.MouseDown listenersEric Williams1-2/+30
Flush the DragDetection queue so that MouseDown events are still sent if MouseUp isn't hooked. This patch adapts some of the DnD caching logic implemented by bug 510446. Tested on Wayland with GTK3.22. The bug reproducer snippet works as expected and the IDE functions normally. No AllNonBrowser JUnit test failures occur. Change-Id: Ida37543ae748a2a0d91eee192ae3bce34b2cbb0d Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-13[Win32] Remove dead code from Display.windowProcNikita Nemkin2-37/+6
Some code added in bug 124965 (Table scrolling optimization) is dead. In particular, Display.columnCount variable is never set. Scrolling optimization itself is not affected. Change-Id: I3b2cc89d5698625818e71134d9d036c4d9baba0d Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
2018-04-13Bug 533496 – Add mechanism to find 32 bit java in GTK build.shLeo Ufimtsev1-2/+14
Dynamically find JAVA_HOME for 32bit java on a system that also has 64bit java installed. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=53349632 Change-Id: I84cd5b44078f22da3226971122dfcb38ac060895 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-13Bug 533252 - Iterate over entrySet inLars Vogel1-21/+23
org.eclipse.swt.examples.controlexample.ColorTab Change-Id: Iffd49a876ba34081eaf69c1f906c90fae363a4e8 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-04-12v4871v4871aI20180412-2000genie.releng1-1/+1
2018-04-12Bug 527729 Only load Adwaita theme fixes if system theme is Adwaita.Leo Ufimtsev6-67/+112
Currently we apply Adwaita-specific fixes (e.g excessive padding) to all themes. This breaks some non-adwaita themes (e.g Phenix). The fix is to check which system them is used and only load Adwaita fixes for Adwaita theme. One thing to note is that we also load some CSS for functional fixes such as keyboard shortcut bindings. These should still be loaded for all themes. I tested on my Fedora 27, Gtk3.22. - Adwaita/Adwaita-dark look as before. - Ambiance looks ok. Toolbars are a little tall, but ok. - Clear-Phenix looks ok. Toolbars are a little tall, but ok. Tool buttons now seem to have proper size and entry looks ok. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=527729322 Change-Id: I6b932b86d4cdc20003cc8c2fcfbc7f9e67e84fe1 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-04-11v4871v4871I20180411-2000genie.releng1-1/+1
2018-04-11v4871genie.releng3-4/+4
2018-04-11Bug 529431: [GTK3.10+] Snippet294 fails to draw RegionEric Williams2-21/+140
This patch fixes drawing issues when setRegion is called on widgets that are children of Scrollable (like List, for example). The fix is to check if there are incoming draw events for paintHandle() in Control. If this is the case, and setRegion has been defined, we call gtk_draw(). This ensures that the clipping is applied to the right handle and that the region is drawn. Tested on GTK3.22. Compared behaviour with GTK3.8: most widgets work with the exception of Table/Tree and a few others. No AllNonBrowser JUnit tests fail. Functionality for Shell.setRegion() remains functional. Change-Id: Ife9a1688e58eef3c98cc6f74ff7d1bac1eac9986 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-04-11Bug 531667 - don't use data.clippingTransform for GTK >= 3.14Andrey Loskutov1-23/+8
The extra clipping transformations stored in data.clippingTransform are not needed after commit d7ce5978d32a9dd4bf77dfa77e4b1c696992af4a. Moreover, this extra conversions (to and from CTM space) decrease painting performance and in some cases even cause endless GTK re-paints (see bug 531667 comment 80). Change-Id: I95697d6b9e57ad5987104c8d4a73c41e132028b3 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-04-11Bug 488431 - Provide SWT/GTK3 port on WindowsRolf Theunissen6-3/+15
Graceful errors for features not implemented in SWT/GTK-Win32 Change-Id: Ib54d2dbba9f4aac89b2edb1ff135e0e28d39f7d8 Signed-off-by: Rolf Theunissen <rolf.theunissen@altran.com>
2018-04-11v4870v4870I20180411-0735I20180411-0530genie.releng1-1/+1
2018-04-11v4870genie.releng3-4/+4

Back to the top