diff options
| author | Andrey Loskutov | 2019-02-08 15:51:56 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2019-02-08 19:04:47 +0000 |
| commit | c91eb63de3123b7f5e8352bf61c5fbbd6cbb2df4 (patch) | |
| tree | 0e1800040765d9d63a053567f3fb7a969b2d959e /tests | |
| parent | 0be4b8fcc50e0d652b8f565cdf98e43e5de34cc3 (diff) | |
| download | eclipse.platform.swt-c91eb63de3123b7f5e8352bf61c5fbbd6cbb2df4.tar.gz eclipse.platform.swt-c91eb63de3123b7f5e8352bf61c5fbbd6cbb2df4.tar.xz eclipse.platform.swt-c91eb63de3123b7f5e8352bf61c5fbbd6cbb2df4.zip | |
Bug 544282 - [GTK3] apply the optimization for Tree.setItemCount(0) too
Also added some more tests.
Change-Id: Ic14ff6e0f7f694c8a1756e34a7b17986301213d4
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Diffstat (limited to 'tests')
2 files changed, 56 insertions, 1 deletions
diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Table.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Table.java index 0f1f89e418..9a6c4c4396 100644 --- a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Table.java +++ b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Table.java @@ -1376,6 +1376,53 @@ public void test_setHeaderVisibleZ() { } @Test +public void test_setItemCountI() { + table.removeAll(); + assertEquals(0, table.getItemCount()); + for (int i=0; i<8; i++) { + new TableItem(table, SWT.NULL); + assertEquals(i+1, table.getItemCount()); + } + assertEquals(8, table.getItemCount()); + assertEquals(4, table.indexOf(table.getItems()[4])); + table.getItem(1).dispose(); + assertEquals(7, table.getItemCount()); + new TableItem (table, SWT.NULL, 0); + assertEquals(1, table.indexOf(table.getItems()[1])); + assertEquals(8, table.getItemCount()); + table.setItemCount(0); + assertEquals(0, table.getItemCount()); + table.setItemCount(0); + assertEquals(0, table.getItemCount()); + table.setItemCount(-1); + assertEquals(0, table.getItemCount()); + table.setItemCount(10); + assertEquals(10, table.getItemCount()); + table.getItem(1).dispose(); + assertEquals(9, table.getItemCount()); + assertEquals(4, table.indexOf(table.getItems()[4])); + table.setItemCount(3); + assertEquals(3, table.getItemCount()); + try { + table.getItem(4); + fail("No exception thrown for illegal index argument"); + } + catch (IllegalArgumentException e) { + } + table.setItemCount(40); + assertEquals(40, table.getItemCount()); + table.getItem(39); + table.setItemCount(0); + assertEquals(0, table.getItemCount()); + try { + table.getItem(39); + fail("No exception thrown for illegal index argument"); + } + catch (IllegalArgumentException e) { + } +} + +@Test public void test_setLinesVisibleZ() { assertFalse(table.getLinesVisible()); table.setLinesVisible(true); diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java index 0f9f38601a..dd98ae5a7e 100644 --- a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java +++ b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java @@ -411,7 +411,7 @@ public void test_setItemCountI() { new TreeItem (tree, SWT.NULL, 0); assertEquals(1, tree.indexOf(tree.getItems()[1])); assertEquals(8, tree.getItemCount()); - tree.removeAll(); + tree.setItemCount(0); assertEquals(0, tree.getItemCount()); tree.setItemCount(0); assertEquals(0, tree.getItemCount()); @@ -433,6 +433,14 @@ public void test_setItemCountI() { tree.setItemCount(40); assertEquals(40, tree.getItemCount()); tree.getItem(39); + tree.setItemCount(0); + assertEquals(0, tree.getItemCount()); + try { + tree.getItem(39); + fail("No exception thrown for illegal index argument"); + } + catch (IllegalArgumentException e) { + } } @Test |