diff options
| author | Alex Blewitt | 2015-06-19 09:18:40 +0000 |
|---|---|---|
| committer | Alexander Kurtakov | 2015-07-07 08:57:27 +0000 |
| commit | 4976c78e1f8140ee2ccd13db6f6d574e844114ee (patch) | |
| tree | d658c0ffa9375a6c72f433716193d8c72fd7f52f /examples | |
| parent | 9c11c60b1c468edeb1c6ccb338da886f4e4c9b77 (diff) | |
| download | eclipse.platform.swt-4976c78e1f8140ee2ccd13db6f6d574e844114ee.tar.gz eclipse.platform.swt-4976c78e1f8140ee2ccd13db6f6d574e844114ee.tar.xz eclipse.platform.swt-4976c78e1f8140ee2ccd13db6f6d574e844114ee.zip | |
Bug 470568 - Replace `new Boolean` with `Boolean.valueOf`
Using `new Boolean()` results in the creation of a new object on the
heap, when the flyweight `Boolean.TRUE` and `Boolean.FALSE` are available.
Java 1.4 added a `Boolean.valueOf()` which can be used in place of
`new Boolean()` but which will use the existing flyweight values instead.
Globally change `new Boolean(...)` to `Boolean.valueOf(...)` and replace
constant valued expressions with their flyweight counterparts.
Bug: 470568
Change-Id: I0a9abceef0032f92581f381c36d9971457c3fdee
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Diffstat (limited to 'examples')
| -rw-r--r-- | examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java b/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java index 452fd1f310..a80c7a801e 100644 --- a/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java +++ b/examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java @@ -1227,7 +1227,7 @@ abstract class Tab { } else if (typeName.equals("char")) { parameter = new Object[] {value.length() == 1 ? new Character(value.charAt(0)) : new Character('\0')}; } else if (typeName.equals("boolean")) { - parameter = new Object[] {new Boolean(value)}; + parameter = new Object[] {Boolean.valueOf(value)}; } else if (typeName.equals("java.lang.String")) { parameter = new Object[] {value}; } else if (typeName.equals("org.eclipse.swt.graphics.Point")) { |