Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXi Yan2018-12-17 14:55:13 +0000
committerXi Yan2018-12-17 15:51:29 +0000
commita4aa6e1b4c5088cb1886c686b9498f5cbf4eb38f (patch)
treeaa8fdf99e2e2a1e31d470bf9c0aca8e1422990ec /bundles
parent0014398aff9405873cf34df013344ed73002c5bb (diff)
downloadeclipse.platform.swt-a4aa6e1b4c5088cb1886c686b9498f5cbf4eb38f.tar.gz
eclipse.platform.swt-a4aa6e1b4c5088cb1886c686b9498f5cbf4eb38f.tar.xz
eclipse.platform.swt-a4aa6e1b4c5088cb1886c686b9498f5cbf4eb38f.zip
Bug 541635 - [Wayland] Random behaviour when moving editor tabs
Remove public non-API field. There is no need to set mouseDown flag in DragEnd as when source.dragEnd is called, we set the mouseDown flag when we send the MouseUp signal. Change-Id: Ifa828bebc759ffafc656b7b414ae090b308533f6 Signed-off-by: Xi Yan <xixiyan@redhat.com>
Diffstat (limited to 'bundles')
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/DragSource.java1
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java2
2 files changed, 1 insertions, 2 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/DragSource.java b/bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/DragSource.java
index 8743479d51..7f6eefe262 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/DragSource.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/DragSource.java
@@ -229,7 +229,6 @@ static long /*int*/ DragDataDelete(long /*int*/ widget, long /*int*/ context){
}
static long /*int*/ DragEnd(long /*int*/ widget, long /*int*/ context){
- Control.mouseDown = false;
DragSource source = FindDragSource(widget);
if (source == null) return 0;
source.dragEnd(widget, context);
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
index b8d0633273..13cb4b0a12 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
@@ -118,7 +118,7 @@ public abstract class Control extends Widget implements Drawable {
* Bug 541635, 515396: GTK Wayland only flag to keep track whether mouse
* is currently pressed or released for DND.
*/
- public static boolean mouseDown;
+ static boolean mouseDown;
boolean dragBegun;
Control () {

Back to the top