diff options
author | Ian Pun | 2016-06-08 18:38:59 +0000 |
---|---|---|
committer | Eric Williams | 2016-06-09 19:39:42 +0000 |
commit | 1a1a924745ea4a5f14a145908a30d9c1645e1b4d (patch) | |
tree | 96fd8b06346f6fc204b912921f7a5fcc0aabfb4f /bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java | |
parent | 24eb256965b906c57372583b0d64b697869f3558 (diff) | |
download | eclipse.platform.swt-1a1a924745ea4a5f14a145908a30d9c1645e1b4d.tar.gz eclipse.platform.swt-1a1a924745ea4a5f14a145908a30d9c1645e1b4d.tar.xz eclipse.platform.swt-1a1a924745ea4a5f14a145908a30d9c1645e1b4d.zip |
Bug 495413 - [GTK3] Replace deprecated gtk_adjustment_value_changed
gtk_adjustment_value_changed() is now only called when GTK version is
less than 3.18 and has also been set as a dynamic function.
Patch has been tested on both GTK3 and GTK2
Change-Id: Ib8c6e3d78f9a11154c62e2c8982a2957ee6fc548
Signed-off-by: Ian Pun <ipun@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java')
-rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java index 0e2915525e..82ac4ae321 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java +++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java @@ -866,7 +866,13 @@ public void setValues (int selection, int minimum, int maximum, int thumb, int i OS.g_signal_handlers_block_matched (adjustmentHandle, OS.G_SIGNAL_MATCH_DATA, 0, 0, 0, 0, VALUE_CHANGED); OS.gtk_adjustment_configure(adjustmentHandle, adjustment.value, adjustment.lower, adjustment.upper, adjustment.step_increment, adjustment.page_increment, adjustment.page_size); - OS.gtk_adjustment_value_changed (adjustmentHandle); + /* + * gtk_adujustment_value_changed is deprecated on GTK3.18+. + * GTK+ will emit "value-changed" itself whenever the value changes. + * See bug 495413. + */ + if (OS.GTK_VERSION < OS.VERSION(3, 18, 0)) + OS.gtk_adjustment_value_changed (adjustmentHandle); OS.g_signal_handlers_unblock_matched (adjustmentHandle, OS.G_SIGNAL_MATCH_DATA, 0, 0, 0, 0, VALUE_CHANGED); } |