Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikita Nemkin2020-01-10 16:38:45 +0000
committerNikita Nemkin2020-01-21 17:03:55 +0000
commit53734d178c305fb4425be0872a6c6bb7c2d059a5 (patch)
tree06a2ef15d25a956b197e32b6e3d2939dd829e34a
parent3651c3ce0be1a6e0b97979eb5f331174aea81d9a (diff)
downloadeclipse.platform.swt-53734d178c305fb4425be0872a6c6bb7c2d059a5.tar.gz
eclipse.platform.swt-53734d178c305fb4425be0872a6c6bb7c2d059a5.tar.xz
eclipse.platform.swt-53734d178c305fb4425be0872a6c6bb7c2d059a5.zip
Bug 559378 - [Win32] Remove traces of pre-WinXP code
Remove workaround for COMCTL version 5 (Bug 98087) and some comments. Change-Id: Ic30d600d900de7775852aa652c22f26df2293981 Signed-off-by: Nikita Nemkin <nikita@nemkin.ru>
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java14
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Combo.java21
2 files changed, 0 insertions, 35 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java
index 2a9768a60b..7a75b4f67d 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java
@@ -904,13 +904,6 @@ public void setImage (Image image) {
if (image != null && image.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
if ((style & SWT.ARROW) != 0) return;
this.image = image;
- /* This code is intentionally commented */
-// if (OS.COMCTL32_MAJOR < 6) {
-// if (image == null || text.length () != 0) {
-// _setText (text);
-// return;
-// }
-// }
_setImage (image);
}
@@ -1050,13 +1043,6 @@ public void setText (String string) {
if (string == null) error (SWT.ERROR_NULL_ARGUMENT);
if ((style & SWT.ARROW) != 0) return;
text = string;
- /* This code is intentionally commented */
-// if (OS.COMCTL32_MAJOR < 6) {
-// if (text.length () == 0 && image != null) {
-// _setImage (image);
-// return;
-// }
-// }
_setText (string);
}
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Combo.java b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Combo.java
index 53088b0e57..8b44bc9877 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Combo.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Combo.java
@@ -2855,18 +2855,6 @@ LRESULT WM_GETDLGCODE (long wParam, long lParam) {
@Override
LRESULT WM_KILLFOCUS (long wParam, long lParam) {
/*
- * Bug in Windows. When a combo box that is read only
- * is disposed in CBN_KILLFOCUS, Windows segment faults.
- * The fix is to send focus from WM_KILLFOCUS instead
- * of CBN_KILLFOCUS.
- *
- * NOTE: In version 6 of COMCTL32.DLL, the bug is fixed.
- */
- if ((style & SWT.READ_ONLY) != 0) {
- return super.WM_KILLFOCUS (wParam, lParam);
- }
-
- /*
* Return NULL - Focus notification is
* done in WM_COMMAND by CBN_KILLFOCUS.
*/
@@ -3239,15 +3227,6 @@ LRESULT wmCommandChild (long wParam, long lParam) {
updateDropDownHeight ();
break;
case OS.CBN_KILLFOCUS:
- /*
- * Bug in Windows. When a combo box that is read only
- * is disposed in CBN_KILLFOCUS, Windows segment faults.
- * The fix is to send focus from WM_KILLFOCUS instead
- * of CBN_KILLFOCUS.
- *
- * NOTE: In version 6 of COMCTL32.DLL, the bug is fixed.
- */
- if ((style & SWT.READ_ONLY) != 0) break;
sendFocusEvent (SWT.FocusOut);
if (isDisposed ()) return LRESULT.ZERO;
break;

Back to the top