Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2021-05-19 08:07:02 +0000
committerLars Vogel2021-05-26 13:13:07 +0000
commit1157ecbaf09777a829de57f5b641fec09fe87434 (patch)
tree4bd4ea8d735db9c25b43e0f8f8bc916f64a572f2
parent13d783ccfcd719115acd749238a0c0269a41d50d (diff)
downloadeclipse.platform.swt-1157ecbaf09777a829de57f5b641fec09fe87434.tar.gz
eclipse.platform.swt-1157ecbaf09777a829de57f5b641fec09fe87434.tar.xz
eclipse.platform.swt-1157ecbaf09777a829de57f5b641fec09fe87434.zip
Rename internal SpiesPlugin class to SpiesConstant to avoid confusing it
with an activator Bug 502839 changed it from activator to a a simple class. Lets rename it and change to interface to make its usage clear. Change-Id: Idb0ebf0acba4bafb3297b429e466aa074d794888 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180763 Reviewed-by: Marc-André Laperle <malaperle@gmail.com>
-rw-r--r--bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesConstants.java (renamed from bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesPlugin.java)6
-rw-r--r--bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/views/SpyView.java2
2 files changed, 5 insertions, 3 deletions
diff --git a/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesPlugin.java b/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesConstants.java
index d1f7add9a4..17839ee955 100644
--- a/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesPlugin.java
+++ b/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesConstants.java
@@ -12,9 +12,11 @@
package org.eclipse.swt.tools.internal;
/**
- * Class containing constants pertaining to the Spies plug-in.
+ * Interface containing constants for the Spies plug-in.
+ *
*/
-public final class SpiesPlugin {
+
+public interface SpiesConstants {
/**
* Identifies the spies plug-in.
*/
diff --git a/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/views/SpyView.java b/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/views/SpyView.java
index b05dd6303e..e1ccca3cfd 100644
--- a/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/views/SpyView.java
+++ b/bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/views/SpyView.java
@@ -37,7 +37,7 @@ public class SpyView extends ViewPart {
static final int TIMEOUT = 100;
private static final ImageDescriptor SPY_IMAGE_DESCRIPTOR = ImageDescriptor.createFromURL(
- FileLocator.find(Platform.getBundle(SpiesPlugin.PLUGIN_ID), new Path("icons/spy.png"), null));
+ FileLocator.find(Platform.getBundle(SpiesConstants.PLUGIN_ID), new Path("icons/spy.png"), null));
/**
* This is a callback that will allow us
* to create the viewer and initialize it.

Back to the top