diff options
| author | Simeon Andreev | 2021-05-12 15:20:27 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2021-05-17 11:16:42 +0000 |
| commit | 054088157c7b7805fd1e1f118827afe06228ed38 (patch) | |
| tree | 3535f13419dc3141baa6c647f8dc81aa4be07343 | |
| parent | 6f54acc4b24e1d47f61e421973bd052db1011e30 (diff) | |
| download | eclipse.platform.swt-054088157c7b7805fd1e1f118827afe06228ed38.tar.gz eclipse.platform.swt-054088157c7b7805fd1e1f118827afe06228ed38.tar.xz eclipse.platform.swt-054088157c7b7805fd1e1f118827afe06228ed38.zip | |
Bug 573472 - [GTK3] Program.getPrograms() leaks native memory
With this change, the result of g_app_info_get_all() is correctly freed
in Program.getPrograms(). This prevents a native memory leak.
Change-Id: I0e8a7f0be2baa4a763176e0e91c262adf38742d3
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180539
Tested-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
| -rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT Program/gtk/org/eclipse/swt/program/Program.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Program/gtk/org/eclipse/swt/program/Program.java b/bundles/org.eclipse.swt/Eclipse SWT Program/gtk/org/eclipse/swt/program/Program.java index 1bcba8851d..55a3ef59f6 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT Program/gtk/org/eclipse/swt/program/Program.java +++ b/bundles/org.eclipse.swt/Eclipse SWT Program/gtk/org/eclipse/swt/program/Program.java @@ -306,7 +306,6 @@ static Program gio_getProgram (Display display, long application) { } OS.g_free(icon_name); } - OS.g_object_unref(icon); } return program.command != null ? program : null; } @@ -328,6 +327,7 @@ static Program[] getPrograms(Display display) { program = gio_getProgram(display, application); if (program != null) programs.add(program); // } + OS.g_object_unref(application); } list = OS.g_list_next(list); } |