diff options
author | Alexandr Miloslavskiy | 2020-05-18 15:42:41 +0000 |
---|---|---|
committer | Niraj Modi | 2020-05-19 07:38:10 +0000 |
commit | c9cfc11cb0c2c3c9f1cf1880fe8d587600943046 (patch) | |
tree | 355b3aad3d34071001977fdf6d1c710cda5b3bbf | |
parent | b69209f789e98f492fdd732764390b5040c8b863 (diff) | |
download | eclipse.platform.swt-c9cfc11cb0c2c3c9f1cf1880fe8d587600943046.tar.gz eclipse.platform.swt-c9cfc11cb0c2c3c9f1cf1880fe8d587600943046.tar.xz eclipse.platform.swt-c9cfc11cb0c2c3c9f1cf1880fe8d587600943046.zip |
Bug 562193 - [Win32] Enable Custom DarkTheme on Windows
Change-Id: I67a0c70d9820ce79c64dd7556b116df1e1f073e5
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
-rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java | 15 | ||||
-rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java | 7 |
2 files changed, 11 insertions, 11 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java b/bundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java index f75d045cc0..53c4e2ded4 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java +++ b/bundles/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java @@ -2326,15 +2326,14 @@ public static final long SendMessage (long hWnd, int Msg, long wParam, TCHAR lPa } /** - * This method enables below listed dark theme experimental feature(calling it - * experimental because it depends on undocumented API on Windows platform which - * may or may not be exposed as public in it's current form) as supported on - * Windows10 only:<br> - * scroll-bar + * Experimental API for dark theme. * <p> - * Note: This operation is a hint and is not supported on platforms that do not - * have this concept. - * </p> + * On Windows, there is no OS API for dark theme yet, and this method only + * configures various tweaks. Some of these tweaks have drawbacks. The tweaks + * are configured with defaults that fit Eclipse. Non-Eclipse applications are + * expected to configure individual tweaks instead of calling this method. + * Please see <code>Display#setData()</code> and documentation for string keys + * used there. * * @param isDarkTheme <code>true</code> for dark theme */ diff --git a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java index b25dc66b7a..8418babd7d 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java +++ b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java @@ -167,12 +167,13 @@ public class Display extends Device { static final boolean disableCustomThemeTweaks = Boolean.valueOf(System.getProperty("org.eclipse.swt.internal.win32.disableCustomThemeTweaks")); //$NON-NLS-1$ /** * Changes Windows theme to 'DarkMode_Explorer' for Controls that can benefit from it. - * Effects:<br> + * Effects as of Windows 10 version 1909:<br> * <ul> * <li>Dark scrollbars - this is the most important change for many applications.</li> * <li>Tree - dark theme compatible expander icon.</li> - * <li>Tree, Table - dark theme compatible colors for selected item.</li> - * <li>Other effects may be present (currently Windows dark theme is only partially implemented).</li> + * <li>Tree - dark theme compatible colors for selected and hovered items.</li> + * <li>Table - uses older theme. It for example doesn't have mouse hover item highlight.</li> + * <li>The list is not exhaustive. Also, effects can change, because Windows dark theme is not yet official.</li> * </ul> * Limitations:<br> * <ul> |