diff options
author | Eric Williams | 2016-05-05 16:14:38 +0000 |
---|---|---|
committer | Eric Williams | 2016-05-09 14:30:54 +0000 |
commit | e02ee8bc32f264213b60930165dc7d9aa7e2e7ae (patch) | |
tree | d29d0ac84b17c87bde09c2d741b2d1cb050b2cd3 | |
parent | 33edb075896957ada25a83632ce0c6e0fa487d2c (diff) | |
download | eclipse.platform.swt-e02ee8bc32f264213b60930165dc7d9aa7e2e7ae.tar.gz eclipse.platform.swt-e02ee8bc32f264213b60930165dc7d9aa7e2e7ae.tar.xz eclipse.platform.swt-e02ee8bc32f264213b60930165dc7d9aa7e2e7ae.zip |
Bug 493036: [GTK3] Tabs within an editor have bad background (EGerrit)
Using GtkNotebook {background: ... ;} as a selector for the background
color of a TabFolder results in the background color bleeding outside of
the area enclosed by the border. This results in weird looking colors.
The fix is to use the GtkNotebook.header selector instead.
Tested on GTK3.20, 3.18, 3.16, and 3.14. GTK2 is unaffected, no
additional AllNonBrowser JUnit tests fail on GTK3.
Change-Id: I05e80f54aea3c82a55407a94967f41f71cab4864
Signed-off-by: Eric Williams <ericwill@redhat.com>
-rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java index 348817f896..0d743401df 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java +++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java @@ -746,7 +746,7 @@ void reskinChildren (int flags) { void setBackgroundColor (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) { if (OS.GTK_VERSION >= OS.VERSION(3, 16, 0)) { // Form background string - String name = OS.GTK_VERSION >= OS.VERSION(3, 20, 0) ? "notebook header" : "GtkNotebook"; + String name = OS.GTK_VERSION >= OS.VERSION(3, 20, 0) ? "notebook header" : "GtkNotebook.header"; String css = name + " {background-color: " + display.gtk_rgba_to_css_string (rgba) + ";}"; // Cache background |