Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLakshmi Shanmugam2020-08-06 10:42:54 +0000
committerLakshmi Shanmugam2020-08-06 10:42:54 +0000
commitc732444ac6c69c3b1d9d2abbb19afa8ac9a2d758 (patch)
tree7b9e8f7e24a499ac0d73a9e65d659969de3cd5dd
parentfc90bbad46fa9c14ca3b5476a825ad76746d7aa7 (diff)
downloadeclipse.platform.swt-c732444ac6c69c3b1d9d2abbb19afa8ac9a2d758.tar.gz
eclipse.platform.swt-c732444ac6c69c3b1d9d2abbb19afa8ac9a2d758.tar.xz
eclipse.platform.swt-c732444ac6c69c3b1d9d2abbb19afa8ac9a2d758.zip
Bug 564453 - Test failures in SWT on Mac
Removed temp code for screenshot. On Mac test machine, SWT.SetData is not being sent for the root item. Not sure why. So, set root item to top[0] if it's null. Change-Id: Ibbb8d43c39306dc11270857001f62e0d7199a387
-rw-r--r--tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java10
1 files changed, 3 insertions, 7 deletions
diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java
index 6794654d24..ec8b09da0c 100644
--- a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java
+++ b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Tree.java
@@ -33,7 +33,6 @@ import org.eclipse.swt.widgets.Event;
import org.eclipse.swt.widgets.Tree;
import org.eclipse.swt.widgets.TreeColumn;
import org.eclipse.swt.widgets.TreeItem;
-import org.eclipse.test.Screenshots;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
@@ -935,6 +934,9 @@ public void test_Virtual() {
top[0] = item;
item.setText("top");
} else {
+ if (top[0] == null) {
+ top[0] = tree.getItem(0);
+ }
if (top[0] != null) {
int index = top[0].indexOf(item);
item.setText("Item " + index);
@@ -961,12 +963,6 @@ public void test_Virtual() {
}
}
}
- // temp code to capture screenshot
- if (SwtTestUtil.isCocoa) {
- Screenshots.takeScreenshot(getClass(), testName.getMethodName());
- // check if setData is called for root item
- assertTrue("SetData not called for top item", top[0] != null);
- }
// the "* 2" allows some surplus for platforms that pre-fetch items to improve scrolling performance:
assertTrue("SetData callback count not in range: " + dataCounter[0],

Back to the top